1851817 - Make GTK nsClipboard use nsBaseClipboard

Status: RESOLVED FIXED

(Core :: Widget: Gtk, task, P2)

Comment 1

[Edgar Chen [:edgar] (OOO untils 09/01, slow response)]

Then we can merge ClipboardSetDataHelper and nsBaseClipboard.

Comment 2

[Edgar Chen [:edgar] (OOO untils 09/01, slow response)]

Attachment: Bug 1851817 - Part 1: Add AsyncHasNativeClipboardDataMatchingFlavors; r?spohl!,stransky!

This is mainly added for GTK which supports getting clipboard data asynchrously.
For other platforms that don't support asynchrously reading, they could use
the default implementation which just wraps the HasNativeClipboardDataMatchingFlavors
instead.

Comment 3

[Edgar Chen [:edgar] (OOO untils 09/01, slow response)]

Attachment: Bug 1851817 - Part 2: Add AsyncGetNativeClipboardData; r?spohl!,stransky!

This is mainly added for GTK which supports getting clipboard data asynchrously.
For other platforms that don't support asynchrously reading, they could use
the default implementation which just wraps the GetNativeClipboardData instead.

Depends on D188249

Comment 4

[Edgar Chen [:edgar] (OOO untils 09/01, slow response)]

Attachment: Bug 1851817 - Part 3: Make GTK support clipboard data sequence number; r?stransky

Depends on D188250

Comment 5

[Edgar Chen [:edgar] (OOO untils 09/01, slow response)]

Attachment: Bug 1851817 - Part 4: Make GTK nsClipboard use nsBaseClipboard; r?stransky

Depends on D188251

Comment 6

[Edgar Chen [:edgar] (OOO untils 09/01, slow response)]

Attachment: Bug 1851817 - Part 5: Merge ClipboardSetDataHelper into nsBaseClipboard; r?spohl

Depends on D188252

Comment 7

[Edgar Chen [:edgar] (OOO untils 09/01, slow response)]

https://treeherder.mozilla.org/jobs?repo=try&revision=a246db71fa7f3a131c51e253052da93a750fbaa4

Comment 8

[Edgar Chen [:edgar] (OOO untils 09/01, slow response)]

https://treeherder.mozilla.org/jobs?repo=try&revision=e676ecf42d9ca540423516b80500f91dc4cbe340

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3c15030aa8a
Part 1: Add AsyncHasNativeClipboardDataMatchingFlavors; r=spohl,stransky
https://hg.mozilla.org/integration/autoland/rev/b46e4efa80ae
Part 2: Add AsyncGetNativeClipboardData; r=spohl,stransky
https://hg.mozilla.org/integration/autoland/rev/0ea5e417de98
Part 3: Make GTK support clipboard data sequence number; r=stransky
https://hg.mozilla.org/integration/autoland/rev/7c035f460830
Part 4: Make GTK nsClipboard use nsBaseClipboard; r=stransky
https://hg.mozilla.org/integration/autoland/rev/72e7e4417cc9
Part 5: Merge ClipboardSetDataHelper into nsBaseClipboard; r=spohl

Comment 10

[Sandor Molnar[:smolnar]]

Backed out for causing wpt failures on clipboard-apis/async-promise-write-blobs-read-blobs.https.html

Backout link: https://hg.mozilla.org/integration/autoland/rev/f4ddbf902f18184f9cbac9a8027b7816851c4e30

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | /clipboard-apis/async-promise-write-blobs-read-blobs.https.html | Verify write and read clipboard (multiple types) with promise to Blobs - assert_equals: expected 2 but got 1

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c475be718c06
Part 1: Add AsyncHasNativeClipboardDataMatchingFlavors; r=spohl,stransky
https://hg.mozilla.org/integration/autoland/rev/586d745c3b53
Part 2: Add AsyncGetNativeClipboardData; r=spohl,stransky
https://hg.mozilla.org/integration/autoland/rev/a0e437dbd349
Part 3: Make GTK support clipboard data sequence number; r=stransky
https://hg.mozilla.org/integration/autoland/rev/dd62e985e214
Part 4: Make GTK nsClipboard use nsBaseClipboard; r=stransky
https://hg.mozilla.org/integration/autoland/rev/7cc8baac415e
Part 5: Merge ClipboardSetDataHelper into nsBaseClipboard; r=spohl

Comment 12

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c475be718c06
https://hg.mozilla.org/mozilla-central/rev/586d745c3b53
https://hg.mozilla.org/mozilla-central/rev/a0e437dbd349
https://hg.mozilla.org/mozilla-central/rev/dd62e985e214
https://hg.mozilla.org/mozilla-central/rev/7cc8baac415e