1852947 - Consider redesigning the async get API in nsIClipboard

Status: RESOLVED FIXED

(Core :: DOM: Copy & Paste and Drag & Drop, enhancement)

Description

[Edgar Chen [:edgar]]

In bug 1755863, we introduce two async get API in nsIClipboard to make async clipboard API really read the clipboard data asynchronously.

When user read the clipboard data through async clipboard API, it gets the available type first, and then get the actual data for s certain type. There's a potential race condition concern if the clipboard has different data on it when we check the types compared to when we actually get the data. Currently, we get the actual data immediate after getting available types (this also follows spec), so there is only a small chance to hit such racing problem. However, if we would like to get the data only when getType() is called (bug 1691825), that will become a serious issue.

Also, bug 1777448 would like to have a way to track the clipboard data and not show the paste contextmenu when the clipboard data is written by the same-origin page. That also requires a better way of tracking read request and the actual clipboard data/available types and invaliding the request when the clipboard data in system is changed.

Comment 1

[Edgar Chen [:edgar]]

And we could also have some tests then.

Comment 2

[Edgar Chen [:edgar]]

Attachment: Bug 1852947 - Part 1: Rename nsIAsyncSetClipboardDataCallback to nsIAsyncClipboardRequestCallback; r?nika

Comment 3

[Edgar Chen [:edgar]]

Attachment: Bug 1852947 - Redesign the async clipboard read API; r?nika

Comment 4

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/jobs?repo=try&revision=60e33815341f09242cdb015c96873f94e5496201

Comment 5

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&revision=5d13b13ae30615e161831713c29965b97ea1ea27

Comment 6

[Edgar Chen [:edgar]]

Attachment: Bug 1852947 - Part 2: Add function attribute to nsIAsyncClipboardRequestCallback; r?nika

Depends on D188526

Comment 7

[Phabricator Automation]

Comment on attachment 9353787 [details]
Bug 1852947 - Part 1: Rename nsIAsyncSetClipboardDataCallback to nsIAsyncClipboardRequestCallback; r?nika

Revision D188526 was moved to bug 1861927. Setting attachment 9353787 [details] to obsolete.

Comment 8

[Phabricator Automation]

Comment on attachment 9359322 [details]
Bug 1852947 - Part 2: Add function attribute to nsIAsyncClipboardRequestCallback; r?nika

Revision D191409 was moved to bug 1861927. Setting attachment 9359322 [details] to obsolete.

Comment 9

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/jobs?repo=try&revision=5e0f21d22da92bfae8f313859f76cd479bb0a18e

Comment 10

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&revision=5003e4fcdb0295c8c34cbf0a39dd8f8be3433ed7

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8561b4726a2
Redesign the async clipboard read API; r=nika

Comment 12

[Norisz Fay [:noriszfay]]

Backed out for causing bustage on nsClipboardProxy.cpp

Backout link

Push with failures

Failure log

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7355802744d1
Redesign the async clipboard read API; r=nika

Comment 14

[Noemi Erli[:noemi_erli]]

Backed out changeset 7355802744d1 (Bug 1852947) for causing failures in test_clipboard_asyncGetData.html CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=EGdBMZZiSoi-ih9b5FvlHg.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cusercancel&revision=7355802744d16bb527adbd62a51c1941fe304c20

Log: https://treeherder.mozilla.org/logviewer?job_id=435575766&repo=autoland&lineNumber=19031
https://treeherder.mozilla.org/logviewer?job_id=435577110&repo=autoland&lineNumber=2401
https://treeherder.mozilla.org/logviewer?job_id=435575814&repo=autoland&lineNumber=18442

Backout: https://hg.mozilla.org/integration/autoland/rev/7b73b48fb1cd3b655cf7eb816c0ccca1e2b69673

Comment 15

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&revision=c62bbf5df651387ec207d5a1a944d7e1daa4a02c

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0ff38a7d9fb
Redesign the async clipboard read API; r=nika

Comment 17

[Noemi Erli[:noemi_erli]]

Backed out changeset b0ff38a7d9fb (Bug 1852947) for causing aInstanceSize related assertion failures

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=adcfhCxMTg6wq0LmbfkqzQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=os%2Cx%2C10.15%2Cwebrender%2Cdebug%2Cmochitests%2Ctest-macosx1015-64-qr%2Fdebug-mochitest-browser-a11y%2Cba&revision=b0ff38a7d9fbd2c85645e2983b026156b028368d

Log: https://treeherder.mozilla.org/logviewer?job_id=435872764&repo=autoland&lineNumber=27490
and some almost perma tier2 failures: https://treeherder.mozilla.org/logviewer?job_id=435872506&repo=autoland&lineNumber=18263

Backout: https://hg.mozilla.org/integration/autoland/rev/4d951aaaeb357f1f837c064f3c0f2670aedf8615

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9ca7370b303
Redesign the async clipboard read API; r=nika

Comment 19

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/b9ca7370b303