1851840 - [Foxfooding] Fakespot Sidebar could have a border to clearly separate itself from the page content

Status: VERIFIED FIXED

(Firefox :: Shopping, enhancement, P2)

Description

[Anna Yeddi [:ayeddi]]

Attachment: Amazon-scrolled-PDP-with-Light-theme-sidebar-on-Mac.png

Preconditions

• Set the browser.shopping.experience2023.enabled - TRUE
• Set the browser.shopping.experience2023.optedIn - 1

Steps to reproduce

1. Reach https://www.amazon.com/dp/B09F56RRF8/ref=vp_d_cpf-substitute-widget_pd?_encoding=UTF8&pf_rd_p=f3e0f858-bc1b-4cf8-bdca-f6e1481f1fbe&pf_rd_r=H70ERT7R4QGKSD4DH14X&pd_rd_wg=QXmZV&pd_rd_i=B09F56RRF8&pd_rd_w=LWAch&content-id=amzn1.sym.f3e0f858-bc1b-4cf8-bdca-f6e1481f1fbe&pd_rd_r=28393c3e-7f14-46bb-878a-82ec1fbb043f or any other Amazon/Walmart/BestBuy product

Expected

• The Fakespot shopping sidebar could have a border to separate it from the webpage content.

Actual result

• There is no clear indication that the sidebar is separate from the page content itself.

Notes

• This was brought up during the High Contrast Mode bug 1849703 review by Itiel and it does feel like a beneficial change, especially when the Light Theme of Fx is used and especially for users with cognitive difficulties because it would help clarify that the Shopping sidebar is, in fact, not provided by the vendor website.

Comment 1

[Anna Yeddi [:ayeddi]]

Attachment: BestBuy-scrolled-PDP-with-Light-theme-on-Win11.png

Comment 2

[:Gijs (he/him)]

From the conversation with UX yesterday, my understanding was that UX explicitly does not want this border outside of HCM. I don't really understand why, and/or if they would be swayed by the explanation in comment 0 as to why the border is helpful (with which I agree). Perhaps they can clarify in a comment here?

Comment 3

[Julian Gaibler]

Oh I think we had a miscommunication then! We don't want the borders around the cards but do want a border for the sidebar. Sorry!

Comment 4

[:Gijs (he/him)]

Attachment: Bug 1851840 - add a border to the shopping sidebar everywhere, r?#shopping-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/205446cc9bbb
add a border to the shopping sidebar everywhere, r=desktop-theme-reviewers,Itiel

Comment 6

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/205446cc9bbb

Comment 7

[Rares Doghi, Desktop QA]

This issue verified as fixed in 119 and later builds.