1851930 - Default Agent background task takes long time to exit

Status: VERIFIED FIXED

(Toolkit :: Default Browser Agent, defect, P1)

Description

[Nick Rishel [:nrishel]]

Due to a mistake in setting the minimum runtime instead of the maximum runtime for the Default Agent background task, it takes an exceedingly long time to exit leaving what appears to be a zombie process.

Comment 1

[Nick Rishel [:nrishel]]

Attachment: Bug 1851930 - Pre: Move Default Agent registry mutex out of header into source. r=nalexander,bytesized

We won't be using this outside of the Default Agent, and having this at the header level invites a debugging pain point when a background task doesn't exit and the mutex lifetime is tied to the DefaultAgent XPCOM object instead of the function call lifetime.

Comment 2

[Nick Rishel [:nrishel]]

Attachment: Bug 1851930 - Correct the Default Agent background task to set a maximum (not minimum) runtime. r=nalexander,bytesized

Depends on D187629

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1838754

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/214f0e1df0dd
Pre: Move Default Agent registry mutex out of header into source. r=nalexander,bytesized
https://hg.mozilla.org/integration/autoland/rev/f06abc41688e
Correct the Default Agent background task to set a maximum (not minimum) runtime. r=nalexander,bytesized

Comment 5

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/214f0e1df0dd
https://hg.mozilla.org/mozilla-central/rev/f06abc41688e

Comment 6

[Nick Rishel [:nrishel]]

Attachment: Backed out changeset f06abc41688e (Bug 1851930)

Backed out due to changes breaking both Default Agent telemetry and launching Firefox in response to interaction with the Default Agent notifications.

Depends on D190871

Comment 7

[Nick Rishel [:nrishel]]

Attachment: Backed out changeset 214f0e1df0dd (Bug 1851930)

Backed out due to changes breaking both Default Agent telemetry and launching Firefox in response to interaction with the Default Agent notifications.

Depends on D190872

Comment 8

[Donal Meehan [:dmeehan]]

Backed out of beta for Fx119
https://hg.mozilla.org/try/rev/1416c53b941d81e441c8a87af7b2f255830da4e7
https://hg.mozilla.org/try/rev/a92eca45f3c7c7bcc40bf0dcae1ff858b04b3612

Setting Fx119 to disabled, the regressor Bug 1838754 was backed out of beta for Fx119

Comment 9

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/releases/mozilla-release/rev/623e72e6f0d1
Backed out changeset f06abc41688e 
https://hg.mozilla.org/releases/mozilla-release/rev/2cbdac7b5110
Backed out changeset 214f0e1df0dd

Comment 10

[Ina Popescu, Desktop QA]

Is it possible to provide the corresponding STR in order to verify this fix? Thanks

Comment 11

[Virgil Sangerean]

Tested on 120.0b4 Firefox on Windows 10 and saw that the issue is no longer reproducible.

Processes no longer remain hanging after being started from Task Scheduler.