1838754 - Wrap WDBA functionality into XPCOM object.

Status: RESOLVED FIXED

(Toolkit :: Default Browser Agent, task, P3)

Description

[Nick Rishel [:nrishel]]

In service of migrating WDBA to a Firefox Background Task we can take the existing WDBA functionality and wrap it in an XPCOM object, and gradually refactor that to better fit Firefox norms.

Comment 1

[Nick Rishel [:nrishel]]

Attachment: Bug 1838754 - Pre 1: Remove remote kill switch from WDBA. r=nalexander

Comment 2

[Nick Rishel [:nrishel]]

Attachment: Bug 1838754 - Pre 2: Rename Default Agent's main.cpp to DefaultAgent.cpp. r=nalexander

Depends on D183437

Comment 3

[Nick Rishel [:nrishel]]

Attachment: Bug 1838754 - Part 1: Move WDBA into a background task. r=nalexander

Comment 4

[Nick Rishel [:nrishel]]

Attachment: Bug 1838754 - Part 2: Migrate WDBA command line handling out of XPCOM into background task. r=nalexander

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The following patch is waiting for review from an inactive reviewer:

ID	Title	Author	Reviewer Status
D174973	Bug 1838754 - Part 2: Migrate WDBA command line handling out of XPCOM into background task. r=nalexander	nrishel	nalexander: Back Aug 21, 2023

:nrishel, could you please find another reviewer?

For more information, please visit BugBot documentation.

Comment 6

[Nick Rishel [:nrishel]]

Attachment: Bug 1838754 - Pre 3: Normalize moz.build and components.conf build exclusions related to Windows Toast on excluding gcc builds. r=mossop

Depends on D183438

Comment 7

[Nick Rishel [:nrishel]]

Attachment: Bug 1838754 - Part 3: Handle WDBA uninstall task unscheduling in standalone proxy executable so that it's executed with the same permissions as the uninstaller. r=bytesized

This can be reverted once Bug 1710143 lands.

Depends on D174973

Comment 8

[Nick Rishel [:nrishel]]

Attachment: Bug 1838754 - Post: Update documentation for Background Task and Default Browser Agent to reflect the latter being rewritten as the former. r=mossop

Depends on D187068

Comment 9

[Nick Rishel [:nrishel]]

Attachment: Bug 1838754 - Pre 3: Normalize moz.build and components.conf build exclusions related to Windows Toast on excluding gcc builds. r=mossop

Depends on D183438

Comment 10

[Nick Rishel [:nrishel]]

Attachment: Bug 1838754 - Pre 3: Normalize moz.build and components.conf build exclusions related to Windows Toast on excluding gcc builds. r=mossop

Depends on D183438

Comment 11

[Nick Rishel [:nrishel]]

Attachment: Bug 1838754 - Part 4: Ensure default agent notifications run on an MTA thread. r=nalexander

This is necessary as notification callbacks can not occur on an STA thread when the event loop is not running. We currently block while waiting for notification callbacks, therefore the event loop can not run.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a50ccbb53b0
Pre 1: Remove remote kill switch from WDBA. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/af624d29c748
Pre 2: Rename Default Agent's main.cpp to DefaultAgent.cpp. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/c4064dbb85a6
Pre 3: Normalize moz.build and components.conf build exclusions related to Windows Toast on excluding gcc builds. r=mossop
https://hg.mozilla.org/integration/autoland/rev/626918ba3444
Part 1: Move WDBA into a background task. r=nalexander,mossop
https://hg.mozilla.org/integration/autoland/rev/85eb99b90c26
Part 2: Migrate WDBA command line handling out of XPCOM into background task. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/19a063fe4fc3
Part 3: Handle WDBA uninstall task unscheduling in standalone proxy executable so that it's executed with the same permissions as the uninstaller. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/744552ffb916
Part 4: Ensure default agent notifications run on an MTA thread. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/b07c43c2d0e3
Post: Update documentation for Background Task and Default Browser Agent to reflect the latter being rewritten as the former. r=mossop

Comment 13

[Iulian Moraru]

Backed out for causing multiple build bustages.
So far, this has only affected windows.

• Push with failures

• Failure log example 1

• Failure log example 2

• Backout link

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/868fdde83bdc
Pre 1: Remove remote kill switch from WDBA. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/617f15d7dff8
Pre 2: Rename Default Agent's main.cpp to DefaultAgent.cpp. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/ff651e1a09c7
Pre 3: Normalize moz.build and components.conf build exclusions related to Windows Toast on excluding gcc builds. r=mossop
https://hg.mozilla.org/integration/autoland/rev/fb4dfb4d76c1
Part 1: Move WDBA into a background task. r=nalexander,mossop
https://hg.mozilla.org/integration/autoland/rev/27b6015a6b28
Part 2: Migrate WDBA command line handling out of XPCOM into background task. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/ef4f82aa3980
Part 3: Handle WDBA uninstall task unscheduling in standalone proxy executable so that it's executed with the same permissions as the uninstaller. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/1da5e2dc15f9
Part 4: Ensure default agent notifications run on an MTA thread. r=nalexander
https://hg.mozilla.org/integration/autoland/rev/33dc6c6f62d7
Post: Update documentation for Background Task and Default Browser Agent to reflect the latter being rewritten as the former. r=mossop

Comment 15

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/868fdde83bdc
https://hg.mozilla.org/mozilla-central/rev/617f15d7dff8
https://hg.mozilla.org/mozilla-central/rev/ff651e1a09c7
https://hg.mozilla.org/mozilla-central/rev/fb4dfb4d76c1
https://hg.mozilla.org/mozilla-central/rev/27b6015a6b28
https://hg.mozilla.org/mozilla-central/rev/ef4f82aa3980
https://hg.mozilla.org/mozilla-central/rev/1da5e2dc15f9
https://hg.mozilla.org/mozilla-central/rev/33dc6c6f62d7

Comment 16

[Nick Rishel [:nrishel]]

Attachment: Backed out changeset 33dc6c6f62d7 (Bug 1838754)

Backed out due to changes breaking both Default Agent telemetry and launching Firefox in response to interaction with the Default Agent notifications.

Depends on D190874

Comment 17

[Nick Rishel [:nrishel]]

Attachment: Backed out changeset 1da5e2dc15f9 (Bug 1838754)

Backed out due to changes breaking both Default Agent telemetry and launching Firefox in response to interaction with the Default Agent notifications.

Depends on D190875

Comment 18

[Nick Rishel [:nrishel]]

Attachment: Backed out changeset ef4f82aa3980 (Bug 1838754)

Backed out due to changes breaking both Default Agent telemetry and launching Firefox in response to interaction with the Default Agent notifications.

Depends on D190876

Comment 19

[Nick Rishel [:nrishel]]

Attachment: Backed out changeset 27b6015a6b28 (Bug 1838754)

Backed out due to changes breaking both Default Agent telemetry and launching Firefox in response to interaction with the Default Agent notifications.

Depends on D190877

Comment 20

[Nick Rishel [:nrishel]]

Attachment: Backed out changeset fb4dfb4d76c1 (Bug 1838754)

Backed out due to changes breaking both Default Agent telemetry and launching Firefox in response to interaction with the Default Agent notifications.

Depends on D190878

Comment 21

[Nick Rishel [:nrishel]]

Attachment: Backed out changeset ff651e1a09c7 (Bug 1838754)

Backed out due to changes breaking both Default Agent telemetry and launching Firefox in response to interaction with the Default Agent notifications.

Depends on D190879

Comment 22

[Nick Rishel [:nrishel]]

Attachment: Backed out changeset 617f15d7dff8 (Bug 1838754)

Backed out due to changes breaking both Default Agent telemetry and launching Firefox in response to interaction with the Default Agent notifications.

Depends on D190880

Comment 23

[Nick Rishel [:nrishel]]

Attachment: Backed out changeset 868fdde83bdc (Bug 1838754)

Backed out due to changes breaking both Default Agent telemetry and launching Firefox in response to interaction with the Default Agent notifications.

Depends on D190881

Comment 24

[Donal Meehan [:dmeehan]]

Backed out of beta for Fx119
https://hg.mozilla.org/releases/mozilla-beta/rev/689906410d5f8337d185caeadf063e3c3e6f9f81
https://hg.mozilla.org/releases/mozilla-beta/rev/7b48a5cb0983d3967514dec532ff7bf3a455614e
https://hg.mozilla.org/releases/mozilla-beta/rev/bf9343fdee938bc7b06ae4af3883281990931cb7
https://hg.mozilla.org/releases/mozilla-beta/rev/ad3334e56e31a56635ddbe4926e5977a10c0b483
https://hg.mozilla.org/releases/mozilla-beta/rev/045125729d31481ba9f6f30fe2b5869ea3a7c951
https://hg.mozilla.org/releases/mozilla-beta/rev/604f57f4c833dca8001a05cb44eff335e27bdc19
https://hg.mozilla.org/releases/mozilla-beta/rev/dcd3097bd401a9af2787046f5616a510caab3b0a
https://hg.mozilla.org/releases/mozilla-beta/rev/35d5b32779935bc23377e1e78a130338be3a9f4c
https://hg.mozilla.org/releases/mozilla-beta/rev/14b83f35b744b7c9e3dbb1899b46753ea4517e5b

Comment 25

[Nick Rishel [:nrishel]]

Backout only occurred in Beta, this issue is resolved.