1851975 - Open thread in Conversation panel does not remember sorting preferences

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[Nicola Mori]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/117.0

Steps to reproduce:

I open a thread in conversation, define a sort criterion, the close the conversation panel and then open it again

Actual results:

When I set the sorting criterion it works fine, but after re-opening the panel my criterion is lost and the default one is used to sort messages

Expected results:

The conversation panel should remember the last sort setting and apply it when I open a message in conversation.

Comment 1

[Wayne Mery (:wsmwk)]

Did it "work" in version 102?

Comment 2

[Nicola Mori]

Yes it worked in version 102, it is broken since version 115.

Comment 3

[Wayne Mery (:wsmwk)]

Nicola,
IIRC this was fixed. Is it work for you now?

Comment 5

[Nicola Mori]

No, the problem is still present in Thunderbird 115.7.0. No matter what visualization preferences I set, the next time I open a conversation it is displayed as threaded and ordered by date with older first. This happens also in safe mode.

Comment 6

[Hartmut Welpmann [:welpy-cw]]

While the state of the columns is persisted, the sort type and order are not. The following patch tries to improve the situation by at least applying the default settings as defined in the preferences, so changing mailnews.default_sort_type and mailnews.default_sort_order in the config editor would have an effect on conversation views as well (as mailnews.default_view_flags already has).

Comment 7

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1851975 - Get default sort for synthetic views from preferences. r=#thunderbird-reviewers

The default sort order and type for synthetic views such as conversations are hard coded. Use
the mailnews.default_sort_order and mailnews.default_sort_type preferences instead.

This patch also restores the missing sort indicator when a synthetic view is opened.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/28cc2922f0ce
Get default sort for synthetic views from preferences. r=mkmelin

Comment 9

[Magnus Melin [:mkmelin] (away, back Aug 4)]

comm/mail/base/test/browser/browser_mailContext.js is failing. Will back out.

Comment 10

[Magnus Melin [:mkmelin] (away, back Aug 4)]

Backout: https://hg.mozilla.org/comm-central/rev/14ddb94760a357dfce95262c03291a543555dda1

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/17239bec4e1c
Get default sort for synthetic views from preferences. r=mkmelin