1851992 - Implement interface to send data stop notification to stream listeners

Status: RESOLVED FIXED

(Core :: Networking: HTTP, enhancement, P2)

Description

[Sunil Mayya]

We would like to send a OMT message to stream listners to notify them that there wont be any more ODA notifications sent to them and hence, they can start processing the data.
To do this we will need a new interface. This will be implemented by this bug.
For start, we will send these notifications to css and html5 listeners.

Comment 1

[Sunil Mayya]

Attachment: Bug 1851992 - implement nsIThreadRetargetableStreamListener::OnDataFinished to send OMT data stop notification to thread retargetable stream listeners. r=#necko,jesup

Comment 2

[edgul]

Attachment: Bug 1851992 - moving html5 stream parser's OnStopRequest off main thread. r=#necko,jesup

Comment 3

[Sunil Mayya]

Attachment: WIP: Bug 1851992 - uncomment onstop request changes

Comment 4

[Sunil Mayya]

Attachment: Bug 1851992 - implement nsIThreadRetargetableStreamListener::OnDataFinished to multiple listeners. r=#necko,jesup

Depends on D187832

Comment 5

[Sunil Mayya]

Attachment: WIP: Bug 1851992 - add pref to control sending ondata finished from HttpChannelChild and Html5Parser

Comment 6

[Sunil Mayya]

Attachment: Bug 1851992 - send onDataFinished notifications from nsInputStreamPump. r=#necko,jesup

Depends on D187833

Comment 7

[Sunil Mayya]

Attachment: Bug 1851992 - implement OnDataFinished for CSSLoader. r=#necko,jesup,emilio

Depends on D188757

Comment 8

[Sunil Mayya]

Attachment: Bug 1851992 - implement empty nsIThreadRetargetableStreamListener::OnDataFinished for stream loader. r=#necko,jesup,emilio

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/03c17255f1af
implement nsIThreadRetargetableStreamListener::OnDataFinished to send OMT data stop notification to thread retargetable stream listeners. r=necko-reviewers,jesup,valentin
https://hg.mozilla.org/integration/autoland/rev/79969d9eb5cd
moving html5 stream parser's OnStopRequest off main thread. r=necko-reviewers,edgul,jesup,valentin,hsivonen
https://hg.mozilla.org/integration/autoland/rev/fa61d4e76827
implement nsIThreadRetargetableStreamListener::OnDataFinished to multiple listeners. r=necko-reviewers,extension-reviewers,jesup,rpl
https://hg.mozilla.org/integration/autoland/rev/95e4df69007a
send onDataFinished notifications from nsInputStreamPump. r=necko-reviewers,jesup
https://hg.mozilla.org/integration/autoland/rev/d28399b3d947
implement empty nsIThreadRetargetableStreamListener::OnDataFinished for stream loader. r=emilio

Comment 10

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d354d93ae06b
Backed out 5 changesets for causing multiple failures

Comment 11

[Cristina Horotan [:chorotan]]

Backed out 5 changesets (Bug 1851992) for causing multiple failures

Backout: https://hg.mozilla.org/integration/autoland/rev/d354d93ae06b28127112934f9ed4cb28415fa182

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=d28399b3d947ad20bc08fa1aa7ca71ee8940a7c2

Failure logs:
https://treeherder.mozilla.org/logviewer?job_id=432788946&repo=autoland&lineNumber=9479
https://treeherder.mozilla.org/logviewer?job_id=432787146&repo=autoland&lineNumber=9125

Comment 12

[Sunil Mayya]

Attachment: Bug 1851992 - Skip sending OnDataFinished to listeners if StreamFilterParent::mState is suspended. r=rpl,#necko

Depends on D191097

Comment 13

[Sunil Mayya]

Attachment: Bug 1851992 - move assignment of mTransferSize,mEncodedBodySize from HttpChannelChild::OnStopRequest to HttpChannelChild::OnStopRequest::ProcessOnStopRequest. r=#necko

Depends on D191290

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/38c40d735ab7
implement nsIThreadRetargetableStreamListener::OnDataFinished to send OMT data stop notification to thread retargetable stream listeners. r=necko-reviewers,jesup,valentin
https://hg.mozilla.org/integration/autoland/rev/f9f9143ac713
moving html5 stream parser's OnStopRequest off main thread. r=necko-reviewers,edgul,jesup,valentin,hsivonen
https://hg.mozilla.org/integration/autoland/rev/46e18c56dd39
implement nsIThreadRetargetableStreamListener::OnDataFinished to multiple listeners. r=necko-reviewers,extension-reviewers,jesup,rpl
https://hg.mozilla.org/integration/autoland/rev/673df3f83249
send onDataFinished notifications from nsInputStreamPump. r=necko-reviewers,jesup
https://hg.mozilla.org/integration/autoland/rev/c9d322362e22
implement empty nsIThreadRetargetableStreamListener::OnDataFinished for stream loader. r=emilio
https://hg.mozilla.org/integration/autoland/rev/3ceaf46f8f55
move assignment of mTransferSize,mEncodedBodySize from HttpChannelChild::OnStopRequest to HttpChannelChild::OnStopRequest::ProcessOnStopRequest. r=necko-reviewers,jesup

Comment 15

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/38c40d735ab7
https://hg.mozilla.org/mozilla-central/rev/f9f9143ac713
https://hg.mozilla.org/mozilla-central/rev/46e18c56dd39
https://hg.mozilla.org/mozilla-central/rev/673df3f83249
https://hg.mozilla.org/mozilla-central/rev/c9d322362e22
https://hg.mozilla.org/mozilla-central/rev/3ceaf46f8f55

Comment 16

[Narcis Beleuzu [:NarcisB]]

Backed out for DT failure on browser_net_image_cache.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/2d73b37b48b3c0d49e800d71641f3283ae9ae9b6
Log link: https://treeherder.mozilla.org/logviewer?job_id=433555456&repo=autoland&lineNumber=7649

Comment 17

[Sunil Mayya]

Attachment: Bug 1851992 - ensure all of the OnProgress updates are sent before triggering OnDataFinished in HttpChannelChild. r=#necko

Depends on D191291

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4517b343b411
implement nsIThreadRetargetableStreamListener::OnDataFinished to send OMT data stop notification to thread retargetable stream listeners. r=necko-reviewers,jesup,valentin
https://hg.mozilla.org/integration/autoland/rev/f7fe117ca37d
moving html5 stream parser's OnStopRequest off main thread. r=necko-reviewers,edgul,jesup,valentin,hsivonen
https://hg.mozilla.org/integration/autoland/rev/fcb29a7d62eb
implement nsIThreadRetargetableStreamListener::OnDataFinished to multiple listeners. r=necko-reviewers,extension-reviewers,jesup,rpl
https://hg.mozilla.org/integration/autoland/rev/4471b2edc794
send onDataFinished notifications from nsInputStreamPump. r=necko-reviewers,jesup
https://hg.mozilla.org/integration/autoland/rev/d2e0fddb380e
implement empty nsIThreadRetargetableStreamListener::OnDataFinished for stream loader. r=emilio
https://hg.mozilla.org/integration/autoland/rev/f21cf0e9ff8e
move assignment of mTransferSize,mEncodedBodySize from HttpChannelChild::OnStopRequest to HttpChannelChild::OnStopRequest::ProcessOnStopRequest. r=necko-reviewers,jesup
https://hg.mozilla.org/integration/autoland/rev/e480891bbd3b
ensure all of the OnProgress updates are sent before triggering OnDataFinished in HttpChannelChild. r=necko-reviewers,jesup

Comment 19

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/4517b343b411
https://hg.mozilla.org/mozilla-central/rev/f7fe117ca37d
https://hg.mozilla.org/mozilla-central/rev/fcb29a7d62eb
https://hg.mozilla.org/mozilla-central/rev/4471b2edc794
https://hg.mozilla.org/mozilla-central/rev/d2e0fddb380e
https://hg.mozilla.org/mozilla-central/rev/f21cf0e9ff8e
https://hg.mozilla.org/mozilla-central/rev/e480891bbd3b

Comment 20

[Phabricator Automation]

Comment on attachment 9355381 [details]
Bug 1851992 - implement OnDataFinished for CSSLoader. r=#necko,jesup,emilio

Revision D189403 was moved to bug 1864817. Setting attachment 9355381 [details] to obsolete.