Please update Herald rule for "desktop-theme-reviewers" group
Categories
(Conduit :: Phabricator, task)
Tracking
(Not tracked)
People
(Reporter: dao, Assigned: dkl)
References
Details
+++ This bug was initially created as a clone of Bug #1835857 +++
We'd like to further update or split https://phabricator.services.mozilla.com/H274 to better differentiate between theme code strictly owned within the Desktop Theme module, and stylesheets owned by other modules that need to integrate with themes. So we'd like to make it a blocking review for things in browser/themes/ and toolkit/themes/, and a non-blocking one for all other .css files in browser/ and toolkit/. I.e.:
blocking: @^/?(browser|toolkit)/themes/@
non-blocking: @^/?(browser|toolkit)/.*\.css$@
... while also ensuring the non-blocking rule doesn't override the blocking one.
Additionally, please remove "Author is not any of" and "Reviewers include none of" altogether, as keeping it up to date with the list of peers is not as easy as we'd like, and it's been a source of confusion for some people, and it doesn't seem to be a thing we do for other review groups.
Thank you!
|
Assignee | |
Updated•1 year ago
|
|
|
Assignee | |
Comment 1•1 year ago
|
||
(In reply to Dão Gottwald [:dao] from comment #0)
+++ This bug was initially created as a clone of Bug #1835857 +++
We'd like to further update or split https://phabricator.services.mozilla.com/H274 to better differentiate between theme code strictly owned within the Desktop Theme module, and stylesheets owned by other modules that need to integrate with themes. So we'd like to make it a blocking review for things in
browser/themes/andtoolkit/themes/, and a non-blocking one for all other.cssfiles inbrowser/andtoolkit/. I.e.:blocking:
@^/?(browser|toolkit)/themes/@non-blocking:
@^/?(browser|toolkit)/.*\.css$@... while also ensuring the non-blocking rule doesn't override the blocking one.
I will need to break this rule up into 2 rules then, one for the blocking and one for the non-blocking.
Additionally, please remove "Author is not any of" and "Reviewers include none of" altogether, as keeping it up to date with the list of peers is not as easy as we'd like, and it's been a source of confusion for some people, and it doesn't seem to be a thing we do for other review groups.
Done
|
|
Assignee | |
Comment 2•1 year ago
|
||
Description
•