1835857 - Please update Herald rule for "desktop-theme-reviewers" group

Status: RESOLVED FIXED

(Conduit :: Phabricator, task)

Description

[Dão Gottwald [:dao]]

+++ This bug was initially created as a clone of Bug #1646121 +++

We need to update https://phabricator.services.mozilla.com/H274 to account for the fact that stylesheets aren't required to be in browser/themes/ or toolkit/themes/ anymore. This has been the case for many years but was an oversight in bug 1646121. In addition to covering all files in browser/themes/ and toolkit/themes/, the Herald rule should cover all .css files in browser/ and toolkit/.

The review should remain non-blocking as we don't want to be a full-blown gatekeeper or change who ultimately owns those stylesheets.

Additionally, could you please update "Author is not any of" and "Reviewers include none of" to be in line with https://firefox-source-docs.mozilla.org/mots/index.html#desktop-theme, i.e. remove:

• https://phabricator.services.mozilla.com/p/ntim/

and add:

• https://phabricator.services.mozilla.com/p/amy/
• https://phabricator.services.mozilla.com/p/Itiel/
• https://phabricator.services.mozilla.com/p/sfoster/

Thank you!

Comment 1

[David Lawrence [:dkl]]

Ok. Updated. Let's give this a try.

Comment 2

[Dão Gottwald [:dao]]

There's been a sort of typo it seems. Could you please replace @amychan331 with @amy? Thanks!

Comment 3

[David Lawrence [:dkl]]

(In reply to Dão Gottwald [:dao] from comment #2)

There's been a sort of typo it seems. Could you please replace @amychan331 with @amy? Thanks!

Sorry bout that. Fixed.