1852141 - Consider removing position:fixed from the shopping-container.

Status: RESOLVED DUPLICATE of bug 1852302

(Firefox :: Shopping, defect, P3)

Description

[:Gijs (he/him)]

See discussion in bug 1851657.

Removing this will require at least fixing bug 1851834 to set the bg color on the body/root rather than the individual element. I'm not sure if it'd break anything else, especially wrt the stickiness of the header and/or the injected onboarding UI.

Comment 1

[Daniel Holbert [:dholbert]]

As an incremental step towards removal, we might consider switching to position:absolute instead of position:fixed.

Sizing/positioning-wise, there should be no difference, based on how we're using this element right now; and if anything happens to overflow (e.g. via the user activating full-page zoom on the sidebar per bug 1851657, or perhaps using a larger font than we expect, or some other sort of local customization), then they'll be able to reach the overflowing content with a scrollbar (vs. no scrollbars get generated for position:fixed).

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jhirsch, could you have a look please?

For more information, please visit BugBot documentation.

Comment 3

[kpatenio]

Bug 1851839 modifies the header to make it stick to the top of the sidebar by using position: sticky. So this ticket might be rendered obsolete once that lands.

Comment 4

[kpatenio]

Resolving as INVALID since we no longer use position: fixed. From personal testing with Windows 11, main sidebar contents (not onboarding card) scale accordingly when zoomed in and allow for scrolling horizontally/vertically when needed.

Comment 5

[Daniel Holbert [:dholbert]]

bug-resolution-nit: "INVALID" means the reported behavior was not in fact a bug, or not something worth changing, roughly. That's not the case here; this bug is titled "Consider removing position:fixed from the shopping-container", and we've now in fact done that, so this was not-at-all invalid. :)

Since the patch to do that landed elsewhere, WORKSFORME is typically what we use if we don't know what fixed it. But in this case it looks like the fix landed in bug 1852302, here:
https://hg.mozilla.org/mozilla-central/rev/eb991ad78cbbeff391e74c5d11fff82f3cdf8c70#l1.8
...so we might as well dupe to that bug, since that's what fixed this.

Comment 6

[kpatenio]

Fair! Thanks for making the correction.