Closed Bug 1852302 Opened 2 years ago Closed 2 years ago

Shopping sidebar loading state width is too narrow

Categories

(Firefox Graveyard :: Shopping, defect, P1)

Product:
Firefox Graveyard
Component:
Shopping
Platform:
Desktop
All
Type:
defect

Tracking

(firefox-esr102 unaffected, firefox-esr115 unaffected, firefox117 unaffected, firefox118 unaffected, firefox119+ verified, firefox120 verified)

Status:
VERIFIED FIXED
Milestone:
119 Branch
Tracking Flags:
Tracking Status
firefox-esr102 --- unaffected
firefox-esr115 --- unaffected
firefox117 --- unaffected
firefox118 --- unaffected
firefox119 + verified
firefox120 --- verified

People

(Reporter: Gijs, Assigned: niklas)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [fidefe-shopping])

Attachments

(1 file)

Bug 1852302 - Shopping sidebar loading state width should fill sidebar. r=#shopping-reviewers
48 bytes, text/x-phabricator-request
Details | Review

This is especially obvious in bug 1852274 with the permanent loading state for offline mode, but you can also see it briefly in the "normal" loading state.

I think this is a recent regression, possibly to do with the header changes?

Addressing bug 1852141 (ie removing position: fixed) fixes this but causes other issues with the header...

QA Whiteboard: [qa-regression-triage]
Severity: -- → S2
Priority: -- → P1
Assignee: nobody → nbaumgardner
Status: NEW → ASSIGNED

Tacking for Fx119 since it was triaged as S2

tracking-firefox119: --- → +

Steps used:

  1. Launch the build with a new profile
  2. Make sure "browser.shopping.experience2023.enabled" is true
  3. Load a product page like this
  4. Click the "Analyse Reviews" or "Yes, try it" button on the Shopping sidebar
  5. Observe the shopping sidebar loading state width
    Expected: The box-like UI elements are stretching to the right end of the sidebar
    Actual: The box-like UI elements are NOT stretching to the right end of the sidebar, not using the whole area.
  6. The loading state is quite short (fast) so it is hard to observe; You can just reload it (maybe in a new tab) again to retest safely.

Mozregression results:
Found commit message:
Bug 1847307 - Insert final shopping copy r=shopping-reviewers,fluent-reviewers,desktop-theme-reviewers,Gijs,flod
Differential Revision: https://phabricator.services.mozilla.com/D186540

QA Whiteboard: [qa-regression-triage]
status-firefox118: --- → unaffected
Keywords: regressionwindow-wanted
Regressed by: 1847307

Set release status flags based on info from the regressing bug 1847307

status-firefox117: --- → unaffected
status-firefox-esr102: --- → unaffected
status-firefox-esr115: --- → unaffected
Pushed by nbaumgardner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eb991ad78cbb Shopping sidebar loading state width should fill sidebar. r=shopping-reviewers,kpatenio

https://hg.mozilla.org/mozilla-central/rev/eb991ad78cbb

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox119: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 119 Branch
Duplicate of this bug: 1852614
Regressions: 1853316
Regressions: 1854427
Duplicate of this bug: 1852141

Verified as fixed in 119.0, 120.0b1 and our latest Nightly build 121.0a1 (2023-10-24).

Status: RESOLVED → VERIFIED
status-firefox119: fixed → verified
status-firefox120: --- → verified
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: