1852223 - Handle intercepted requests in the authRequired phase

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P2)

Description

[Julian Descottes [:jdescottes]]

When the network.AuthRequired event is implemented, we should start handling intercepted requests in the corresponding phase.

Comment 1

[Julian Descottes [:jdescottes]]

That should be a rather straightforward followup to Bug 1826198, picking this now.

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1852223 - [bidi] Handle intercepted requests in the authRequired phase

Depends on D189517

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1852223 - [wdspec] Add tests for network.addIntercept in authRequired phase

Depends on D191236

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e7a2180e566
[bidi] Handle intercepted requests in the authRequired phase r=webdriver-reviewers,Sasha
https://hg.mozilla.org/integration/autoland/rev/b8d7a9ec9aa2
[wdspec] Add tests for network.addIntercept in authRequired phase r=webdriver-reviewers,Sasha

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/43017 for changes under testing/web-platform/tests

Comment 6

[Serban Stanca [:SerbanS]]

Backed out for causing dt failures in browser_networkobserver_auth_listener.js.

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | devtools/shared/network-observer/test/browser/browser_networkobserver_auth_listener.js | network event has the expected ResponseStart flag - Got false, expected true

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Sasha is going to have a look into that while Julian is out.

Comment 9

[Alexandra Borovova [:Sasha]]

Attachment: Bug 1852223 - [wdpspec] Enable tests for network.addIntercept in authRequired phase.

Depends on D194608

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/292eac48413b
[bidi] Handle intercepted requests in the authRequired phase r=webdriver-reviewers,Sasha
https://hg.mozilla.org/integration/autoland/rev/17acda52a2b8
[wdpspec] Enable tests for network.addIntercept in authRequired phase. r=webdriver-reviewers,whimboo

Comment 11

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/292eac48413b
https://hg.mozilla.org/mozilla-central/rev/17acda52a2b8