Closed Bug 1852324 Opened 1 years ago Closed 1 years ago

Fix ads not appearing with `adsEnabledByUser: true` due to markup

Categories

(Firefox :: Shopping, defect, P3)

Product:
Firefox
Component:
Shopping
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: kpatenio, Unassigned)

References

Details

There's a small markup error with analysis-explainer that causes any available ads to not render when a user enables them. We render the ad by calling this.recommendationTemplate, but it does not currently function due to the markup error.

We won't ship with ads for 119, so it isn't high priority/severity at the moment.

Severity: -- → S3
Priority: -- → P3

Actually, since we're modifying the analysis-explainer in Bug 1852285, I went ahead and fixed the markup in my patch for that bug. Once the patch lands, it should resolve this ticket.

See Also: → 1852262

Issue is now resolved. Marking as WORKSFORME.

Status: NEW → RESOLVED
Closed: 1 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.