1852659 - Content not clipped in auxiliary/dialog windows with rounded bottom corners

Status: NEW

(Core :: Widget: Gtk, defect)

Description

[abrarsl2002]

Attachment: Screenshot from 2023-09-12 08-36-22.png

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.4 Safari/605.1.15

Steps to reproduce:

Firefox Nightly 119.0a1 (2023-09-10) (64-bit) on Linux with newly added rounded corners.

Open any auxiliary/dialog window such as,

Browser Console,
Dev Tools Window,
About Window,
Profile Manager,
Library (Downloads, History, Bookmarks).

Actual results:

The contents of the windows have not been clipped.

Expected results:

The contents should be clipped at the window corners.

Comment 1

[abrarsl2002]

Please ignore the UA in the report. I used a different browser to submit the bug.

Comment 2

[ttntm]

Attachment: Screenshot from 2023-09-13 10-25-26.png

I'm noticing the same issue in FF Dev. Edt. 118.0b8 (64-bit), both in pop ups/dialog windows and the main browser window.

Comment 3

[Dana Lucaci, Desktop QA]

Reproduced the issue with Firefox 119.0a1 (2023-09-10) on Ubuntu 22.04. Indeed when I opened one of the auxiliary/dialog window the content of the windows have not been clipped.
Marking issue as new for engineering input. Thank you.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Emilio, any idea here?
Thanks.

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Yeah this is kind of expected since we implemented the clipping using CSS on browser.css. We could just move it to somewhere shared, but we kinda need to come up with some better approach anyways to fix the performance issues.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Can someone that can reproduce this attach about:support information? In particular, are you on Wayland or X11? Any GTK theme that isn't the default?

I can't reproduce this on either GNOME nor KDE with either Wayland or X11, so I'm confused since comment 3 indicates it should repro there :)

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Attachment: Screenshot of what I see.

Comment 9

[abrarsl2002]

Attachment: Support Info

Comment 10

[abrarsl2002]

I can't reproduce the clipping issue with xwayland. The corners are simply not rounded at all.

Comment 11

[ttntm]

Attachment: about:config output

I have reverted to the default theme, can confirm what abrarsl2002 mentioned in the last comment: bottom borders not rounded at all.

I proceeded to install a gnome extension called Rounded window Corners (https://extensions.gnome.org/extension/5237/rounded-window-corners/) an relogged.

Result: FF bottom corners are rounded and content is properly clipped.

IDK what to make of it, but it looks like it's unrelated to FF's code in my case.

I'm attaching about:support anyway, just in case:

Comment 12

[ttntm]

I have reverted to the default theme, can confirm what abrarsl2002 mentioned in the last comment: bottom borders not rounded at all.

I proceeded to install a gnome extension called Rounded window Corners (https://extensions.gnome.org/extension/5237/rounded-window-corners/) an relogged.

Result: FF bottom corners are rounded and content is properly clipped.

IDK what to make of it, but it looks like it's unrelated to FF's code in my case.

I've attached about:support output anyway, just in case.

Comment 13

[Emilio Cobos Álvarez (:emilio)]

(In reply to abrarsl2002 from comment #10)

I can't reproduce the clipping issue with xwayland. The corners are simply not rounded at all.

That's the expected behavior on Wayland too. It seems you have an adw-gtk3-dark theme. Does using plain Adwaita fix it? Do you have an extension like comment 12 or so?

Comment 14

[abrarsl2002]

I tried again with plain Adwaita. The problem still occurs.

Comment 15

[abrarsl2002]

Attachment: adwaita_wayland.png

Comment 16

[abrarsl2002]

Attachment: adwaita_xwayland.png

Comment 17

[Emilio Cobos Álvarez (:emilio)]

Any gnome extension or so? I can't reproduce that.

Comment 18

[abrarsl2002]

Both of those images were taken with plain Adwaita. The buggy one was with native Wayland FF and the other one is Xwayland FF via setting MOZ_ENABLE_WAYLAND=0

Comment 19

[abrarsl2002]

No GNOME extensions or anything weird being done server side as far as I know.

Comment 20

[abrarsl2002]

I installed my FF from https://gitlab.com/projects261/firefox-nightly-flatpak
I'll test with a tarball straight from Mozilla once it's done downloading.

Comment 21

[abrarsl2002]

Issue persists with the tarball and exhibits the same behaviour.