1850827 - Implement rounded bottom corners

Status: REOPENED

(Core :: Widget: Gtk, enhancement)

Description

[Robert Mader [:rmader]]

We already do that on other platforms and GTK-land has moved to the direction as well.

Comment 1

[Robert Mader [:rmader]]

Attachment: WIP: Bug 1850827 - Implement rounded bottom corners

Comment 2

[Robert Mader [:rmader]]

Attachment: Screenshot from 2023-08-30 22-25-24.png

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1850827 - Implement rounded bottom corners in GTK. r=stransky,rmader

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Okay, so I took a look and rebased the patch. Ironically, the Adwaita Gtk3 theme doesn't have bottom corners, so that's why that border shows up. More ironically, this works with Breeze and improves the rendering there :)

The thing is, we can't know if the current gtk theme has bottom rounded corners. The right thing to do would be to query the border-bottom-right/left-radius in the CSD node of the window. That's what GTK does here. But those properties aren't exposed, so we can just query border-radius as a whole, and that just returns the top left radius here...

So unless there's somehow a way to override this (maybe there is... a custom CSS provider or so?) I don't think there's an easy way to do this...

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1850827 - Simplify how we draw window decorations. r=stransky,rmader

This makes the rounded bottom corners work on X11, and makes the top
corner drawing less insane.

Depends on D187343

Comment 6

[bbhtt]

This also solves https://bugzilla.mozilla.org/show_bug.cgi?id=1743981?

Comment 8

[Robert Mader [:rmader]]

For anyone wanting to test: https://treeherder.mozilla.org/jobs?repo=try&revision=4dcf74dec8d8bfac1de6b81a8eb6c67dd0ca6bc7

Comment 9

[Robert Mader [:rmader]]

Attachment: Screenshot from 2023-09-04 09-17-05.png

This looks almost perfect to me, thanks a lot! The only issue I see on Gnome is a slight misalignment of the black border and the transparent area, both at the bottom and at the top. At the bottom it's just a bit more visible IMO.

I attached a screenshot for more easy reasoning.

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Is the one at the top a new thing with these patches or do you see it without them too?

Comment 11

[Emilio Cobos Álvarez (:emilio)]

(I can't reproduce comment 9 neither on mutter nor kwin fwiw, looks perfect here)

Comment 12

[Robert Mader [:rmader]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #10)

Is the one at the top a new thing with these patches or do you see it without them too?

• The top part is also visible in nightly, but only catches my eye when using dark mode (so the title bar color is dark) and over light background. It's easy to miss over dark background and doesn't appear to be a big deal.
• The bottom part is easily visible - but so far I could only reproduce it on https://www.mozilla.org/en-US/firefox/nightly/firstrun/ :)

Tested on two different machines - both dark-mode, one text-scale-factor 1.25 (the other 1.0).

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a7ce0ac3a970
Implement rounded bottom corners in GTK. r=rmader

Comment 14

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a7ce0ac3a970

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b7144975b31
Simplify how we draw window decorations. r=stransky,rmader,desktop-theme-reviewers,dao

Comment 16

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/7b7144975b31

Comment 17

[Emilio Cobos Álvarez (:emilio)]

Reopening because of scrolling perf regressions (bug 1852584).

Comment 18

[Emilio Cobos Álvarez (:emilio)]

Trying to re-enable with the changes in bug 1854360: https://treeherder.mozilla.org/perfherder/compare?originalProject=try&originalRevision=cf7b6dc64b0448623c37497c3c9b87b0cc95870a&newProject=try&newRevision=81be162c499fafd8e58d82df88b3cbf111b5b92d

Comment 19

[Kimiblock Moe]

It seems that rounded corners disappears when visiting a website with blurred elements.

Example: https://build.archlinuxcn.org/~auxiliarypower/map.html