1852733 - Chat account manager has black text color on dark buttons

Status: RESOLVED FIXED

(Thunderbird :: Theme, defect)

Description

[Martin Giger [:freaktechnik]]

Attachment: image.png

STR:

• Add a chat account
• Set system to dark theme
• Open chat account manager ("Show Accounts" button in chat tab)

Expected results:
The buttons for the account item have the same label color as the ones in the window footer (or at least a text color with appropriate contrast).

Actual result:
The buttons have black text on a dark grey background.

(I've only tested this back to beta, very possible this affects ESR as well)

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Bug 1852733 - Chat fixes after bug 1843044 landing. r=#thunderbird-front-end-reviewers

Comment 2

[Martin Giger [:freaktechnik]]

I do see this on beta, so 118 is very much affected. I can try to get a regression range, actually.

Comment 3

[Martin Giger [:freaktechnik]]

So using mozregression I found out that we always had black text on the label of those buttons, but we used to have a lighter background for those buttons until https://hg.mozilla.org/comm-central/pushloghtml?fromchange=114d9cd1e98a0e837e510e317e5ea44f99f967bd&tochange=1541f34dc859c4bba36787d99138a1ed7107497f

And while contrast wasn't great, it was much better than it is now. The background matched the one of the footer buttons, but the label color never did, weirdly enough.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d4220e013091
Chat fixes after bug 1843044 landing. r=freaktechnik