1852746 - listAttachments() is empty for encrypted messages

Status: RESOLVED FIXED

(Thunderbird :: Add-Ons: Extensions API, defect)

Description

[tim.heithecker]

Attachment: debugencryptedattachments.xpi

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/117.0

Steps to reproduce:

Execute messages.listAttachments with the id of an encrypted message that has attachments.

E.g. as in the “background.js” file of the attached add-on:

messenger.messageDisplay.onMessageDisplayed.addListener((tab, message) => {
  messenger.messages.listAttachments(message.id).then(console.debug)
})

Actual results:

The returned array is empty. It does not contain the attachments.
I also tried version 118.0b3 and got the same results.

Expected results:

The returned array should contain the attachments. Just like it worked in older versions and still works for unencrypted messages.

Comment 1

[mauricemeedendorp]

I am seeing this problem too, but with unencrypted emails.

It seems that emails where a PDF file is attached with the Content-Type: application/octet-stream are not properly listed in the listAttachments function, even though they are listed in the attachment pane when opening the email.

An example email where this occurs (with private information removed) is attached.

Comment 2

[mauricemeedendorp]

Attachment: example.eml

Comment 3

[John Bieling (:TbSync)]

Attachment: WIP: Bug 1852746 - Use MimeTreeEmitter and MimeTreeEncrypter for messages.listAttachments().

Depends on D202210

Comment 4

[John Bieling (:TbSync)]

I will work on this within the next few weeks. The groundwork has been done. We need to fix Bug 1882832 and then this can be implemented.

Comment 5

[John Bieling (:TbSync)]

Attachment: Bug 1852746 - Fix listAttachments() being empty for encrypted messages. r=#thunderbird-reviewers

This is a regression from switching to the MimeTreeEmitter. The old
implementation always tried to decrpypt the message for attachment
extraction. The new implementation did not, which is fixed by this patch.

This also adds an extended test to actually check listAttachments() on
an encrypted message (including nested messages).

Note: getRaw() and getFull() have an option to work on the original or
on the decrypted message. This patch does not add the same option for
listAttachments(). We currently do not handle encrypted parts as
"attachments" (this is why listAttachments() did not return the
raw encrypted part before this patch) and there has not been a request
to access the raw enrcrypted part. We may come back to this at a later time.

The changes in utils.js are fixing an incomplete type check. Only
boolean, number and string variables where type checked,
but not date for example. This patch also adds some more verbose
output to make it easier to track errors.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/44bca50b447a
Fix listAttachments() being empty for encrypted messages. r=mkmelin

Comment 7

[John Bieling (:TbSync)]

Comment on attachment 9406249 [details]
Bug 1852746 - Fix listAttachments() being empty for encrypted messages. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): Regression from switching to a different parser method
User impact if declined: listAttachments() does not return attachments of encrypted messages
Testing completed (on c-c, etc.): a few days (missed landing on 128 by a few days)
Risk to taking this patch (and alternatives if risky): Low

Comment 8

[Wayne Mery (:wsmwk)]

Comment on attachment 9406249 [details]
Bug 1852746 - Fix listAttachments() being empty for encrypted messages. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 9

[Rob Lemley [:rjl]]

Thunderbird 128.0b2:
https://hg.mozilla.org/releases/comm-beta/rev/bbcf34624146