Closed Bug 1852874 Opened 1 years ago Closed 1 year ago

`./mach wpt <test-path> --product chrome` fails due to `mach.site.InstallPipRequirementsException: As part of validation after installing "M:/src\testing\web-platform\tests\tools\wptrunner\requirements.txt" into the "wpt" site`

Categories

(Testing :: web-platform-tests, defect)

Firefox 117
defect

Tracking

(firefox-esr102 unaffected, firefox-esr115 unaffected, firefox117 wontfix, firefox118 wontfix, firefox119 wontfix, firefox120 fixed)

RESOLVED FIXED
120 Branch
Tracking Status
firefox-esr102 --- unaffected
firefox-esr115 --- unaffected
firefox117 --- wontfix
firefox118 --- wontfix
firefox119 --- wontfix
firefox120 --- fixed

People

(Reporter: masayuki, Assigned: jgraham)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(3 files)

When I run ./mach wpt <test-path> --product chrome, I got this error:

 ach.site.InstallPipRequirementsException: As part of validation after installing "M:/src\testing\web-platform\tests\tools\wptrunner\requirements.txt" into the "wpt" site, the site appears to contain installed packages that are incompatible with each other.
 
  File "M:\src\testing\web-platform\mach_commands.py", line 540, in run_wpt
    return run_web_platform_tests(command_context, **params)
  File "M:\src\testing\web-platform\mach_commands.py", line 528, in run_web_platform_tests
    return wpt_runner.run(logger, **params)
  File "m:\src\testing\web-platform\mach_commands_base.py", line 57, in run
    kwargs = self.setup.kwargs_wptrun(kwargs)
  File "M:\src\testing\web-platform\mach_commands.py", line 182, in kwargs_wptrun
    self.virtualenv_manager.install_pip_requirements(
  File "M:\src\python\mach\mach\site.py", line 738, in install_pip_requirements
    raise InstallPipRequirementsException(

mozilla-central revision is 1b3be6b61583. I run this on Windows.

The same happens btw on MacOS as well and it was working for me not that long ago. So it would be good to find the regression range.

OS: Windows 11 → All
Hardware: x86_64 → All

I wonder about mach changes like bug 1808732, but a regression range would indeed be useful.

The actual regressor is bug 1779473, which added support for the toml format to manifestparser.

Tom, can you please have a look? Thanks!

Flags: needinfo?(tmarble)
Regressed by: 1779473
Version: unspecified → Firefox 117

how can this be reproduced, I have ran the command ./mach wpt testing/web-platform/tests/html/editing/dnd/svg/067.svg --product chrome, and 10 minutes of waiting with no output. I am on windows 11:

$ ./mach wpt testing/web-platform/tests/html/editing/dnd/svg/067.svg --product chrome
 0:00.08 INFO Skipping manifest download because existing file is recent

Could you please provide more log details before the failure line? Specifically looking for which package(s) is(are) not installed and the invoking command (e.g. pip).

Flags: needinfo?(tmarble)

how can this be reproduced, I have ran the command ./mach wpt testing/web-platform/tests/html/editing/dnd/svg/067.svg --product chrome, and 10 minutes of waiting with no output.

It sounds like maybe it's taking ages to update the manifest? Try with --mach log-level debug. But also note that file isn't a test.

FWIW on linux this seems to be working, although I'm running into a different bug where we don't seem to be selecting a reasonable value for the browser channel, and it ends up failing when that's None (this might be an upstream regression; it can be worked around by providing --browser-channel).

with some debugging, I see an error, but not related to python packages: ```

with some debugging, I see an error, but not related to python packages. It is too much to put in here, so I will only add the last 50 lines or so:

Successfully installed aioquic-0.9.21
 8:19.67 INFO Set tests_root to C:\Users\elvis\mozilla-unified\testing\web-platform\tests
 8:19.67 INFO Set metadata_root to C:\Users\elvis\mozilla-unified\testing\web-platform\tests
 8:19.67 INFO Set manifest_download to True
Error running mach:

    mach wpt testing/web-platform/tests/html/editing/dnd/svg/017.xhtml --product chrome --log-mach-verbose --log-mach-level debug

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke ``./mach busted`` to check if this issue is already on file. If it
isn't, please use ``./mach busted file wpt`` to report it. If ``./mach busted`` is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

TypeError: join() argument must be str, bytes, or os.PathLike object, not 'NoneType'

  File "C:\Users\elvis\mozilla-unified\testing\web-platform\mach_commands.py", line 540, in run_wpt
    return run_web_platform_tests(command_context, **params)
  File "C:\Users\elvis\mozilla-unified\testing\web-platform\mach_commands.py", line 528, in run_web_platform_tests
    return wpt_runner.run(logger, **params)
  File "c:\users\elvis\mozilla-unified\testing\web-platform\mach_commands_base.py", line 57, in run
    kwargs = self.setup.kwargs_wptrun(kwargs)
  File "C:\Users\elvis\mozilla-unified\testing\web-platform\mach_commands.py", line 190, in kwargs_wptrun
    kwargs = run.setup_wptrunner(venv, **kwargs)
  File "C:\Users/elvis/mozilla-unified\testing\web-platform\tests\tools\wpt\run.py", line 862, in setup_wptrunner
    setup_cls.setup(kwargs)
  File "C:\Users/elvis/mozilla-unified\testing\web-platform\tests\tools\wpt\run.py", line 189, in setup
    self.setup_kwargs(kwargs)
  File "C:\Users/elvis/mozilla-unified\testing\web-platform\tests\tools\wpt\run.py", line 345, in setup_kwargs
    binary = self.browser.find_binary(venv_path=self.venv.path, channel=browser_channel)
  File "C:\Users/elvis/mozilla-unified\testing\web-platform\tests\tools\wpt\browser.py", line 1194, in find_binary
    path = self._find_binary_in_directory(self._get_browser_binary_dir(venv_path, channel))
  File "C:\Users/elvis/mozilla-unified\testing\web-platform\tests\tools\wpt\browser.py", line 100, in _get_browser_binary_dir
    dest = os.path.join(dest, "browsers", channel)
  File "C:\mozilla-build\python3\lib\ntpath.py", line 117, in join
    genericpath._check_arg_types('join', path, *paths)
  File "C:\mozilla-build\python3\lib\genericpath.py", line 152, in _check_arg_types
    raise TypeError(f'{funcname}() argument must be str, bytes, or '

Sentry event ID: 899b0130a8a84ed5ac70a99c8421b0aa
Sentry is attempting to send 0 pending error messages
Waiting up to 2 seconds
Press Ctrl-Break to quit

I am running off the tip of autoland from September 12th about 7pm EDT.

That's the error I mentioned in Comment 6, which I think is probably an upstream change, and can be worked around with --browser-channel=dev.

I've Chrome canary installed and run with the following command:

mach wpt --product chrome testing/web-platform/tests/webdriver/tests/bidi/browsing_context/reload --browser-channel=experimental

it looks like filelock 3.12.3 has requirement typing-extensions>=4.7.1; python_version < "3.11", but you have typing-extensions 3.10.0.0. is the conflict. What uses filelock or typing-extensions, maybe toml/tomlkit?

I see we have typing-extensions 3.10.0 vendored in-tree as a third_party python: https://searchfox.org/mozilla-central/source/third_party/python/typing_extensions, maybe that needs to be updated? That was added >2 years ago.

Flags: needinfo?(tmarble)

As far as I can tell neither toml nor tomlkit require filelock nor typing-extensions.

In fact I don't think filelock is used at all.. the only partial reference I could find was:

$ find . -name '*.py' | xargs grep filelock
./mozbase/lib/python3.10/site-packages/pygments/lexers/teraterm.py:                r'filelock|'
./mozbase/lib/python3.10/site-packages/pygments/lexers/_lasso_builtins.py:        'error_code_filelocked',
./mozbase/lib/python3.10/site-packages/pygments/lexers/_lasso_builtins.py:        'error_msg_filelocked',
$

I did find several packages that use typing-extensions, this may give us a hint:

$ find . -name '*.py' | xargs grep -E '(import|from) (filelock|typing_extensions)' | grep -v ./mozbase | cut -d/ -f1-4 | sort -u
./testing/web-platform/tests
./third_party/python/aiohttp
./third_party/python/arrow
./third_party/python/click
./third_party/python/fluent.syntax
./third_party/python/importlib_metadata
./third_party/python/Jinja2
./third_party/python/jsonschema
./third_party/python/MarkupSafe
./third_party/python/packaging
./third_party/python/sentry_sdk
$

I will next try to dig into the versions required for those packages.

What do we need to do to determine if filelock can be safely removed?

Flags: needinfo?(tmarble)

(In reply to Tom Marble from comment #12)

What do we need to do to determine if filelock can be safely removed?

I would say to run a try build with various types of wpt tests included. But James might have a better answer.

Flags: needinfo?(james)

It actually looks like that the failure has changed (at least for me). Now I see one of the following depending on which test type I actually run:

General wpt:


TypeError: join() argument must be str, bytes, or os.PathLike object, not 'NoneType'

  File "/Users/henrik/code/gecko/testing/web-platform/mach_commands.py", line 543, in run_wpt
    return run_web_platform_tests(command_context, **params)
  File "/Users/henrik/code/gecko/testing/web-platform/mach_commands.py", line 531, in run_web_platform_tests
    return wpt_runner.run(logger, **params)
  File "/Users/henrik/code/gecko/testing/web-platform/mach_commands_base.py", line 57, in run
    kwargs = self.setup.kwargs_wptrun(kwargs)
  File "/Users/henrik/code/gecko/testing/web-platform/mach_commands.py", line 190, in kwargs_wptrun
    kwargs = run.setup_wptrunner(venv, **kwargs)
  File "/Users/henrik/code/gecko/testing/web-platform/tests/tools/wpt/run.py", line 862, in setup_wptrunner
    setup_cls.setup(kwargs)
  File "/Users/henrik/code/gecko/testing/web-platform/tests/tools/wpt/run.py", line 189, in setup
    self.setup_kwargs(kwargs)
  File "/Users/henrik/code/gecko/testing/web-platform/tests/tools/wpt/run.py", line 345, in setup_kwargs
    binary = self.browser.find_binary(venv_path=self.venv.path, channel=browser_channel)
  File "/Users/henrik/code/gecko/testing/web-platform/tests/tools/wpt/browser.py", line 1194, in find_binary
    path = self._find_binary_in_directory(self._get_browser_binary_dir(venv_path, channel))
  File "/Users/henrik/code/gecko/testing/web-platform/tests/tools/wpt/browser.py", line 100, in _get_browser_binary_dir
    dest = os.path.join(dest, "browsers", channel)
  File "/Users/henrik/.pyenv/versions/3.9.10/lib/python3.9/posixpath.py", line 90, in join
    genericpath._check_arg_types('join', a, *p)
  File "/Users/henrik/.pyenv/versions/3.9.10/lib/python3.9/genericpath.py", line 152, in _check_arg_types
    raise TypeError(f'{funcname}() argument must be str, bytes, or '

Wdspec:

TypeError: join() argument must be str, bytes, or os.PathLike object, not 'Product'

  File "/Users/henrik/code/gecko/testing/web-platform/mach_commands.py", line 543, in run_wpt
    return run_web_platform_tests(command_context, **params)
  File "/Users/henrik/code/gecko/testing/web-platform/mach_commands.py", line 531, in run_web_platform_tests
    return wpt_runner.run(logger, **params)
  File "/Users/henrik/code/gecko/testing/web-platform/mach_commands_base.py", line 57, in run
    kwargs = self.setup.kwargs_wptrun(kwargs)
  File "/Users/henrik/code/gecko/testing/web-platform/mach_commands.py", line 199, in kwargs_wptrun
    meta_dir = os.path.join(
  File "/Users/henrik/.pyenv/versions/3.9.10/lib/python3.9/posixpath.py", line 90, in join
    genericpath._check_arg_types('join', a, *p)
  File "/Users/henrik/.pyenv/versions/3.9.10/lib/python3.9/genericpath.py", line 152, in _check_arg_types
    raise TypeError(f'{funcname}() argument must be str, bytes, or '

Instead of defaulting a known set of args, apply the defaults the frontend would itself apply.

Also fix the fact that the product kwarg is more eagerly converted into a Product class instance.

Assignee: nobody → james
Status: NEW → ASSIGNED

Actually with James' patch applied and the wpt virtualenv removed at the following location it works for me now!

~/.mozbuild/srcdirs/<something unique here>/_virtualenvs/wpt

Set release status flags based on info from the regressing bug 1779473

:masayuki does this work for you if you delete and recreate the wpt virtualenv (I think clobber should do this, but you can also do it manually by removing .mozbuild/srcdirs/<unique path per source tree>/_virtualenvs/wpt if a clobber doesn't work).

Flags: needinfo?(james) → needinfo?(masayuki)

Unfortunately, I fail to run a WPT with/without chrome because of "No builds found for version 119.0.6032.2" even though the CI is green for the version.

However, I found a bug of the patch. Once I apply your patch, the --browser-channel is ignored and always treated as canary.

Flags: needinfo?(masayuki)

Not found error log:

$ ./mach wpt testing/web-platform/tests/uievents/mouse/mousemove_prevent_default_action.tentative.html --product chrome --browser-channel stable
 0:00.01 INFO Skipping manifest download because existing file is recent
Requirement already satisfied: html5lib==1.1 in c:\users\toybox\.mozbuild\srcdirs\src-5cdff21eb229\_virtualenvs\wpt\lib\site-packages (from -r M:/src\testing\web-platform\tests\tools\wptrunner\requirements.txt (line 1)) (1.1)
Requirement already satisfied: mozdebug==0.3.0 in c:\users\toybox\.mozbuild\srcdirs\src-5cdff21eb229\_virtualenvs\wpt\lib\site-packages (from -r M:/src\testing\web-platform\tests\tools\wptrunner\requirements.txt (line 2)) (0.3.0)
Requirement already satisfied: mozinfo==1.2.3 in c:\users\toybox\.mozbuild\srcdirs\src-5cdff21eb229\_virtualenvs\wpt\lib\site-packages (from -r M:/src\testing\web-platform\tests\tools\wptrunner\requirements.txt (line 3)) (1.2.3)
Requirement already satisfied: mozlog==8.0.0 in c:\users\toybox\.mozbuild\srcdirs\src-5cdff21eb229\_virtualenvs\wpt\lib\site-packages (from -r M:/src\testing\web-platform\tests\tools\wptrunner\requirements.txt (line 4)) (8.0.0)
Requirement already satisfied: mozprocess==1.3.1 in c:\users\toybox\.mozbuild\srcdirs\src-5cdff21eb229\_virtualenvs\wpt\lib\site-packages (from -r M:/src\testing\web-platform\tests\tools\wptrunner\requirements.txt (line 5)) (1.3.1)
Requirement already satisfied: packaging==23.1 in .\third_party\python\packaging (from -r M:/src\testing\web-platform\tests\tools\wptrunner\requirements.txt (line 6)) (23.1)
Requirement already satisfied: pillow==9.5.0 in c:\users\toybox\.mozbuild\srcdirs\src-5cdff21eb229\_virtualenvs\wpt\lib\site-packages (from -r M:/src\testing\web-platform\tests\tools\wptrunner\requirements.txt (line 7)) (9.5.0)
Requirement already satisfied: requests==2.31.0 in .\third_party\python\requests (from -r M:/src\testing\web-platform\tests\tools\wptrunner\requirements.txt (line 8)) (2.31.0)
Collecting six==1.16.0
  Using cached six-1.16.0-py2.py3-none-any.whl (11 kB)
Collecting urllib3==2.0.4
  Using cached urllib3-2.0.4-py3-none-any.whl (123 kB)
Collecting aioquic==0.9.19
  Using cached aioquic-0.9.19-cp39-cp39-win_amd64.whl (1.0 MB)
Requirement already satisfied: webencodings in c:\users\toybox\.mozbuild\srcdirs\src-5cdff21eb229\_virtualenvs\wpt\lib\site-packages (from html5lib==1.1->-r M:/src\testing\web-platform\tests\tools\wptrunner\requirements.txt (line 1)) (0.5.1)
Requirement already satisfied: distro>=1.4.0 in .\third_party\python\distro (from mozinfo==1.2.3->-r M:/src\testing\web-platform\tests\tools\wptrunner\requirements.txt (line 3)) (1.8.0)
Requirement already satisfied: mozfile>=0.12 in c:\users\toybox\.mozbuild\srcdirs\src-5cdff21eb229\_virtualenvs\wpt\lib\site-packages (from mozinfo==1.2.3->-r M:/src\testing\web-platform\tests\tools\wptrunner\requirements.txt (line 3)) (3.0.0)
Requirement already satisfied: blessed>=1.19.1 in .\third_party\python\blessed (from mozlog==8.0.0->-r M:/src\testing\web-platform\tests\tools\wptrunner\requirements.txt (line 4)) (1.19.1)
Requirement already satisfied: mozterm in c:\users\toybox\.mozbuild\srcdirs\src-5cdff21eb229\_virtualenvs\wpt\lib\site-packages (from mozlog==8.0.0->-r M:/src\testing\web-platform\tests\tools\wptrunner\requirements.txt (line 4)) (1.0.0)
Requirement already satisfied: certifi>=2017.4.17 in .\third_party\python\certifi (from requests==2.31.0->-r M:/src\testing\web-platform\tests\tools\wptrunner\requirements.txt (line 8)) (2022.12.7)
Requirement already satisfied: idna<4,>=2.5 in .\third_party\python\idna (from requests==2.31.0->-r M:/src\testing\web-platform\tests\tools\wptrunner\requirements.txt (line 8)) (2.10)
Requirement already satisfied: charset-normalizer<4,>=2 in .\third_party\python\charset_normalizer (from requests==2.31.0->-r M:/src\testing\web-platform\tests\tools\wptrunner\requirements.txt (line 8)) (3.2.0)
Requirement already satisfied: pylsqpack<0.4.0,>=0.3.3 in c:\users\toybox\.mozbuild\srcdirs\src-5cdff21eb229\_virtualenvs\wpt\lib\site-packages (from aioquic==0.9.19->-r M:/src\testing\web-platform\tests\tools\wptrunner\requirements.txt (line 11)) (0.3.17)
Requirement already satisfied: pyopenssl>=20 in c:\users\toybox\.mozbuild\srcdirs\src-5cdff21eb229\_virtualenvs\wpt\lib\site-packages (from aioquic==0.9.19->-r M:/src\testing\web-platform\tests\tools\wptrunner\requirements.txt (line 11)) (23.2.0)
Requirement already satisfied: cryptography>=3.1 in c:\users\toybox\.mozbuild\srcdirs\src-5cdff21eb229\_virtualenvs\wpt\lib\site-packages (from aioquic==0.9.19->-r M:/src\testing\web-platform\tests\tools\wptrunner\requirements.txt (line 11)) (41.0.4)
Requirement already satisfied: jinxed>=1.1.0 in .\third_party\python\jinxed (from blessed>=1.19.1->mozlog==8.0.0->-r M:/src\testing\web-platform\tests\tools\wptrunner\requirements.txt (line 4)) (1.2.0)
Requirement already satisfied: wcwidth>=0.1.4 in .\third_party\python\wcwidth (from blessed>=1.19.1->mozlog==8.0.0->-r M:/src\testing\web-platform\tests\tools\wptrunner\requirements.txt (line 4)) (0.2.5)
Requirement already satisfied: cffi>=1.12 in c:\users\toybox\.mozbuild\srcdirs\src-5cdff21eb229\_virtualenvs\wpt\lib\site-packages (from cryptography>=3.1->aioquic==0.9.19->-r M:/src\testing\web-platform\tests\tools\wptrunner\requirements.txt (line 11)) (1.15.1)
Requirement already satisfied: pycparser in c:\users\toybox\.mozbuild\srcdirs\src-5cdff21eb229\_virtualenvs\wpt\lib\site-packages (from cffi>=1.12->cryptography>=3.1->aioquic==0.9.19->-r M:/src\testing\web-platform\tests\tools\wptrunner\requirements.txt (line 11)) (2.21)
Requirement already satisfied: ansicon in .\third_party\python\ansicon (from jinxed>=1.1.0->blessed>=1.19.1->mozlog==8.0.0->-r M:/src\testing\web-platform\tests\tools\wptrunner\requirements.txt (line 4)) (1.89.0)
Installing collected packages: urllib3, six, aioquic
  Attempting uninstall: urllib3
    Found existing installation: urllib3 1.26.0
    Not uninstalling urllib3 at m:\src\third_party\python\urllib3, outside environment C:\Users\toybox\.mozbuild\srcdirs\src-5cdff21eb229\_virtualenvs\wpt
    Can't uninstall 'urllib3'. No files were found to uninstall.
  Attempting uninstall: six
    Found existing installation: six 1.13.0
    Not uninstalling six at m:\src\third_party\python\six, outside environment C:\Users\toybox\.mozbuild\srcdirs\src-5cdff21eb229\_virtualenvs\wpt
    Can't uninstall 'six'. No files were found to uninstall.
  Attempting uninstall: aioquic
    Found existing installation: aioquic 0.9.21
    Uninstalling aioquic-0.9.21:
      Successfully uninstalled aioquic-0.9.21
Successfully installed aioquic-0.9.19 six-1.16.0 urllib3-2.0.4
Collecting aioquic==0.9.21
  Using cached aioquic-0.9.21-cp37-abi3-win_amd64.whl (1.0 MB)
Requirement already satisfied: pylsqpack<0.4.0,>=0.3.3 in c:\users\toybox\.mozbuild\srcdirs\src-5cdff21eb229\_virtualenvs\wpt\lib\site-packages (from aioquic==0.9.21->-r M:/src\testing\web-platform\tests\tools\wptrunner\requirements_chromium.txt (line 1)) (0.3.17)
Requirement already satisfied: certifi in .\third_party\python\certifi (from aioquic==0.9.21->-r M:/src\testing\web-platform\tests\tools\wptrunner\requirements_chromium.txt (line 1)) (2022.12.7)
Requirement already satisfied: pyopenssl>=22 in c:\users\toybox\.mozbuild\srcdirs\src-5cdff21eb229\_virtualenvs\wpt\lib\site-packages (from aioquic==0.9.21->-r M:/src\testing\web-platform\tests\tools\wptrunner\requirements_chromium.txt (line 1)) (23.2.0)
Requirement already satisfied: cryptography!=40.0.0,!=40.0.1,<42,>=38.0.0 in c:\users\toybox\.mozbuild\srcdirs\src-5cdff21eb229\_virtualenvs\wpt\lib\site-packages (from pyopenssl>=22->aioquic==0.9.21->-r M:/src\testing\web-platform\tests\tools\wptrunner\requirements_chromium.txt (line 1)) (41.0.4)
Requirement already satisfied: cffi>=1.12 in c:\users\toybox\.mozbuild\srcdirs\src-5cdff21eb229\_virtualenvs\wpt\lib\site-packages (from cryptography!=40.0.0,!=40.0.1,<42,>=38.0.0->pyopenssl>=22->aioquic==0.9.21->-r M:/src\testing\web-platform\tests\tools\wptrunner\requirements_chromium.txt (line 1)) (1.15.1)
Requirement already satisfied: pycparser in c:\users\toybox\.mozbuild\srcdirs\src-5cdff21eb229\_virtualenvs\wpt\lib\site-packages (from cffi>=1.12->cryptography!=40.0.0,!=40.0.1,<42,>=38.0.0->pyopenssl>=22->aioquic==0.9.21->-r M:/src\testing\web-platform\tests\tools\wptrunner\requirements_chromium.txt (line 1)) (2.21)
Installing collected packages: aioquic
  Attempting uninstall: aioquic
    Found existing installation: aioquic 0.9.19
    Uninstalling aioquic-0.9.19:
      Successfully uninstalled aioquic-0.9.19
Successfully installed aioquic-0.9.21
 0:05.59 INFO Set tests_root to M:\src\testing\web-platform\tests
 0:05.59 INFO Set metadata_root to M:\src\testing\web-platform\tests
 0:05.59 INFO Set manifest_download to True
 0:05.59 INFO Interpreting channel 'nightly' as 'canary'
 0:06.05 ERROR A valid MojoJS version cannot be found for browser binary version 119.0.6032.2.
 0:06.05 INFO MojoJS is disabled for this run.
Download and install chromedriver [Y/n]?
 0:08.35 INFO Searching for ChromeDriver downloads for version 119.0.6032.2.
 0:08.45 INFO No builds found for version 119.0.6032.
Error running mach:

    mach wpt testing/web-platform/tests/uievents/mouse/mousemove_prevent_default_action.tentative.html --product chrome --browser-channel stable

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke ``./mach busted`` to check if this issue is already on file. If it
isn't, please use ``./mach busted file wpt`` to report it. If ``./mach busted`` is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

tools.wpt.browser.DownloadNotFoundError: No ChromeDriver download found to match browser version 119.0.6032.2

  File "M:\src\testing\web-platform\mach_commands.py", line 542, in run_wpt
    return run_web_platform_tests(command_context, **params)
  File "M:\src\testing\web-platform\mach_commands.py", line 530, in run_web_platform_tests
    return wpt_runner.run(logger, **params)
  File "m:\src\testing\web-platform\mach_commands_base.py", line 57, in run
    kwargs = self.setup.kwargs_wptrun(kwargs)
  File "M:\src\testing\web-platform\mach_commands.py", line 189, in kwargs_wptrun
    kwargs = run.setup_wptrunner(venv, **kwargs)
  File "M:\src\testing\web-platform\tests\tools\wpt\run.py", line 862, in setup_wptrunner
    setup_cls.setup(kwargs)
  File "M:\src\testing\web-platform\tests\tools\wpt\run.py", line 189, in setup
    self.setup_kwargs(kwargs)
  File "M:\src\testing\web-platform\tests\tools\wpt\run.py", line 377, in setup_kwargs
    webdriver_binary = self.browser.install_webdriver(
  File "M:\src\testing\web-platform\tests\tools\wpt\browser.py", line 1254, in install_webdriver
    chromedriver_path = self.install_webdriver_by_version(version, dest, channel)
  File "M:\src\testing\web-platform\tests\tools\wpt\browser.py", line 1266, in install_webdriver_by_version
    raise DownloadNotFoundError(

Ah, if I manually download the driver and put into .mozbuild\srcdirs\src-5cdff21eb229\_virtualenvs\wpt\Scripts\chrome, I succeed to run the test!

Pushed by james@hoppipolla.co.uk: https://hg.mozilla.org/integration/autoland/rev/e804061ee17a Make the way we invoke wpt frontend more robust, r=whimboo
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch
No longer blocks: 1850472
See Also: → 1850472

The patch landed in nightly and beta is affected.
:jgraham, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox119 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(james)
Flags: needinfo?(james)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: