1852879 - [Linux] Title bar is not displayed for the About Nightly window

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect, P2)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif] [PTO 15-29 Aug, please ni? :mboldan]]

Attachment: image.png

Found in

• 119.0a1 (2023-09-12)

Affected versions

• 119.0a1 (2023-09-12)

Tested platforms

• Affected platforms: Ubuntu 20, Ubuntu 22
• Unaffected platforms: macOS 12, Windows 10x64

Steps to reproduce

1. Open App Menu > About Nightly

Expected result

• Title bar alongside minimize, maximize, and close buttons are displayed.

Actual result

• Title bar is not displayed.

Regression

• Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=8848a488540ba7bee842078775b60fe2f3171556&tochange=a28fc8d4ff32a17df441bb783437f7385fafc62a

Additional notes

• Attached a screenshot.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:stransky, since you are the author of the regressor, bug 1852724, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Sure, will look at it ASAP.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1852879 [Linux] Disable system titlebar early only for toplevel windows without parent r?emilio

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1852879 [Linux] Polish gtk_window_set_titlebar() calls r?emilio

Depends on D188072

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb0929724e33
[Linux] Disable system titlebar early only for toplevel windows without parent r=emilio
https://hg.mozilla.org/integration/autoland/rev/5c2b84502e3e
[Linux] Polish gtk_window_set_titlebar() calls r=emilio

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox119 (nightly). We have limited time to fix this, the soft freeze is in 8 days. However, the bug still has low priority and has low severity.

:gcp, could you please increase the priority and increase the severity for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/cb0929724e33
https://hg.mozilla.org/mozilla-central/rev/5c2b84502e3e

Comment 10

[Giorgia Nichita, Release Desktop QA]

Reproduced on an affected Nightly build from 2023-09-12 on Ubuntu 22.04.
Verified as fixed on Firefox 119.0b5 (20231004091611) on Ubuntu 22 and Ubuntu 20.