Android Firefox not following device theme to dark/light when device switches theme automatically
Categories
(Fenix :: General, defect)
Tracking
(Not tracked)
People
(Reporter: s.svetoslav, Unassigned)
Details
(Whiteboard: [qa-triaged])
Firefox for Android
Steps to reproduce:
Using Samsung Galaxy S22 Ultra Exynos version - SM-S908BZKGEUX
One UI 5.1, Android 13
I've set up my phone to switch between light and dark device themes on sunrise/sunset. Firefox is set to follow the device theme, but it fails to switch its theme when the phone switches its. It will continue running in light or dark theme irrespective of the device theme.
I can clear the Firefox card in the multitasking carousel, and only then, when Firefox starts over, it would have the right theme.
Actual results:
Firefox should follow and switch themes when device does.
Expected results:
Firefox does not switch to the device's theme, when it's changed.
|
||
Comment 1•1 year ago
|
||
The Bugbug bot thinks this bug should belong to the 'Firefox::Theme' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.
|
Reporter | |
Updated•1 year ago
|
|
||
Comment 2•1 year ago
|
||
I'm afraid I don't know how much of the style system is used by Fenix, so this may belong in Toolkit::Theme, but I'll redirect to Fenix for triage.
|
|
||
Comment 3•1 year ago
|
||
The severity field is not set for this bug.
:jonalmeida, could you have a look please?
For more information, please visit BugBot documentation.
|
||
Comment 4•1 year ago
|
||
I'm not able to reproduce this on 118 or 119 on either my Pixel 6a nor my Samsung A51. Flagging this for the QA team that may have an S22 and can reproduce it.
The browser UI and web content (I used duck.com) are immediately responsive and switch to light/dark theme is changed.
|
||
Comment 5•1 year ago
|
||
Samsung A52 on 118 having the same issue. Firefox is in dark mode, but Android in Light mode. If I try switching Android back to Dark and then Light again, Firefox gets into this weird in-between state. Some screen captures are in the OneDrive link below.
https://1drv.ms/f/s!Aiy2mXWyGJtziao_1M4_IyaeV0Sfjg
|
||
Comment 6•1 year ago
|
||
Hello,
I've not been able to reproduce the issue using the latest Nightly (120.0a1), using Samsung Galaxy S22 Ultra (Android 13) and Samsung Galaxy S22 (Android 13).
Could you please send a video regarding issue?
Thank you!
|
|
||
Updated•1 year ago
|
|
|
||
Updated•1 year ago
|
|
|
||
Updated•1 year ago
|
|
|
Reporter | |
Comment 7•1 year ago
|
||
I tried reproducing the bug again on the latest version - 118.1.1 and I was unable to. I tried triggering Dark mode manually. This time FIrefox (Fenix) would switch correctly to dark theme. You could set the phone (Samsung Galaxy S22 Ultra) to switch to Dark mode at predefined time of the day. So I set it to 2 minutes into the future. You have to switch off the screen for the switch to occur, which is what I did, but I still couldn't reproduce it.
Either something was changed between v. 117 and v. 118, or the bug occurs in very specific situations.
However, my previous experience was exactly like the screenshots by Ryan Gleeson (gleeson.ryanj@gmail.com).
I will wait until tonight to see if triggering Dark mode at sunset will switch Firefox's theme properly, and will post the video, if the bug does occur.
|
|
Reporter | |
Comment 8•1 year ago
|
||
I managed to reproduce the bug. It is currently daytime in my time zone. My phone is in light theme. Firefox (Fenix) is still stuck in dark mode since last night. The settings panel seems to be in some middle ground between light and dark modes. The theme is light, but all the fonts are white (for make them readable on a dark background), which makes it impossible to check any of the settings.
|
|
Reporter | |
Comment 9•11 months ago
|
||
One more video from tonight. This time it wouldn't switch to dark mode, even though the rest of the phone's apps are in dark mode already. I went to the settings panel and it, again, stuck in this inbetween mode. It switched to dark mode only after I exited the settings panel, but it still "thinks" it's in light mode, because it websites, which have both light and dark theme would load in their light version.
|
||
Updated•10 months ago
|
|
||
Comment 10•8 months ago
|
||
See Bug 1873022, I think it's the same issue.
Actually I think there are two issues, not sure if they are related
(1) Firefox does not always respect a switch from Dark to Light theme or vice versa, perhaps when the switch is scheduled not manually invoked. Firefox's theme is consistent throughout the browser but not consistent with the phone's theme
(2) this weird inconsistent intermediate state with unreadable text on some menus and the status bar.
I am still trying to get reliable STR for (1), bug 1873022 has STR for (2) but they don't seem to work on all phones. Hmmmm
|
|
Reporter | |
Comment 11•8 months ago
|
||
(In reply to Mark from comment #10)
See Bug 1873022, I think it's the same issue.
Actually I think there are two issues, not sure if they are related
(1) Firefox does not always respect a switch from Dark to Light theme or vice versa, perhaps when the switch is scheduled not manually invoked. Firefox's theme is consistent throughout the browser but not consistent with the phone's theme
(2) this weird inconsistent intermediate state with unreadable text on some menus and the status bar.I am still trying to get reliable STR for (1), bug 1873022 has STR for (2) but they don't seem to work on all phones. Hmmmm
Yes, it does look like it is the same bug, although it is present in the stable version, not just the Beta.
Description
•