1873022 - Dark Mode not respected for links opened in Nightly/Beta from other apps

Status: NEW

(Fenix :: Design System and Theming, defect)

Description

[Mark]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:123.0) Gecko/20100101 Firefox/123.0

Steps to reproduce:

I think this only works on Nightly and Beta...

email yourself a link to bugzilla.mozilla.org
open the email so the link is ready to go
clean install Firefox Beta 122.0b5
set as default browser
set phone to light mode
in Firefox Beta, manually type bugzilla.mozilla.org into URL bar & navigate
tap Browse at the top of the page
you have tab 1 open on bugzilla.mozilla.org/describecomponents.cgi
switch phone to dark mode
bugzilla.mozilla.org/describecomponents.cgi goes dark
-> CORRECT BEHAVIOR
swap to email app and tap bugzilla.mozilla.org link you emailed earlier
bugzilla.mozilla.org opens in tab 2 in light mode
-> INCORRECT BEHAVIOR, SHOULD BE DARK
swap tabs to tab 1, bugzilla.mozilla.org/describecomponents.cgi is now in light mode
-> INCORRECT BEHAVIOR, SHOULD BE DARK
switch phone to light mode and back to dark mode
everything is now in dark mode as it should be

The same happens with Dark Reader add-on, it gets its knickers in a twist

I don't think this happens on 120 Stable, but it does happen on Beta and Nightly

Galaxy S21 FE, Android 14

Comment 1

[Mark]

Probably the same bug, not sure

In Firefox Beta 122.0b5, I think in Nightly too

Set phone to light mode
Set Firefox Settings > Customise > Follow Device Theme
Close all tabs
Close Firefox
Set phone to Dark mode
Launch Firefox Beta
Type bugzilla.mozilla.org & navigate
You have to manually type the URL don’t use a shortcut
Screen appears in Dark mode
Notification bar + content + toolbar all dark background light text
-> CORRECT BEHAVIOR
Switch phone to Light mode
Notification bar turns light background & light text ie text is invisible
but content & toolbar remain dark
-> INCORRECT BEHAVIOR, it all should be light & notification bar text should be visible
Check the Settings menu, it’s got a weird hybrid color scheme light text & light background
-> INCORRECT BEHAVIOR, it should be Light, white background & dark text

Galaxy S21 FE, Android 14

Comment 2

[Mark]

It went wrong on its own this morning, similar symptoms. Phone still in Dark theme, Nightly switched to its broken "hybrid" theme with unreadable black text & black background in the notification bar and Settings menu; readable (but incorrect) black text & light background for content and toolbar.

Toggling Settings > Theme through Light, Dark and back to Follow Device Theme did not bring Fenix back to Dark theme even though phone was Dark, it remained in the "hybrid" theme until (I think) toggling phone Light then Dark fixed it.

I think Fenix has at least two Dark theme toggles and they don't always obey the "master" toggle which is connected to the device theme. I think notification bar and the Settings menu obey one Dark theme toggle; the content and the toolbar another. And then there is another problem that Fenix doesn't always follow the selected phone theme.

Comment 3

[Mark]

Attachment: Incorrect status bar coloring

Comment 4

[Mark]

Attachment: Incorrect Settings menu coloring

Comment 5

[Mark]

See also bug 1842385 bug 1871015 bug 1872306.

I think these all have the same underlying cause but with a couple of different visible behaviors

1. Fenix sometimes does not obey system dark/light theme
2. Fenix dark/light theme is sometimes not internally consistent (status bar, toolbar & web content have different themes at the same time)
3. Fenix status bar & Settings menu text/background sometimes incorrectly themed (eg dark text on dark background or light text on light background)

@devs is it worth rationalizing down to one bug? there are some limited STR above so copy them if you want to close this one & keep the oldest.

Cheers!

Comment 6

[Mark]

I think you can add bug 1811670 & bug 1797677 to that list

Comment 7

[miralobontiu]

I was not able to reproduce yet these issues.
Tested on both Nightly 123.0a1 from 1/12, and Beta 122.0b8, with a Google Pixel 6 (Android 14), and a Samsung Galaxy Note 8 (Android 9).

Could you retest please, and let us know if you still encounter these issues?
And, also, could you provide us a short video?

Thank you for the detailed report!

Comment 8

[Mark]

Interesting, I'll upload a video on my Galaxy S21 FE, Android 14, Fenix beta 122.0b8

I have simplified STR now, and I have checked it with a link opened from email (Aqua Mail) and Signal

The sequence is

• send yourself a link to bugzilla.mozilla.org in email or Signal or whatever
• set phone in Light theme
• make sure the link to bugzilla.mozilla.org is ready to tap
• reset Fenix Beta by clearing data and cache
• open Fenix Beta
• dismiss the onboarding
• make Fenix Beta the default browser
• switch to the Android Home screen
• set phone to Dark theme
• switch to the link in email, Signal or whatever, my video uses Signal
• tap the link
• the link opens in Fenix Beta in an incorrect hybrid mode with
  -- light content; light toolbar; light tabs tray INCORRECT
  -- broken status bar and Settings menu with unreadable dark text on dark background INCORRECT

Comment 9

[Mark]

Attachment: Incorrect dark mode on Galaxy S21 FE, Android 14

Comment 10

[Mark]

Edit, the link I sent to myself was the full url
https://bugzilla.mozilla.org/home
(in case it matters)

Comment 11

[Mark]

I do not see the issue on my Galaxy M32, Android 13, following these STR. Strange. Perhaps just a quirk of my S21 FE then. I will investigate some more.

Comment 12

[Lorand Janos]

Hi,
I can confirm this issue is reproducible on the latest Beta (122.0b9).
I did not reproduce on the latest Nightly build (123.0a1 from 2024-01-15).
I used a Samsung Galaxy S23 Ultra (Android 14).

Comment 13

[Mark]

I do see it on today's Nightly, I just confirmed now. So there must be some other factor at work for us to get different results.
I see it on Beta and Nightly on S21 FE, you only see it on Beta on S23 Ultra.
Hmmm, interesting.

Comment 14

[Mark]

My Galaxy S21 FE, Android 14, the issue occurs with all of Stable, Beta and Nightly, latest updates
My Galaxy M32, Android 13, the issue does not occur with any version of Firefox.

Something new in Android 14??? Or just Samsung's implementation???

Comment 15

[Mark]

Duplicate of bug 1852919? That bug is about Android 13 so my theory about only Android 14 is not probably correct.

Comment 16

[Mark]

Even easier STR
Set Nightly as the Assist app
Set the device to Light theme
Launch Nightly & leave in the foreground
Toggle the device theme to Dark from the quick settings menu
Do the Assist gesture
Type bugzilla.mozilla.org (autocomplete is OK)

If you have an affected device (it seems not all are affected)
The content appears Light but the chrome appears Dark
-> INCORRECT
Go to the Home screen, putting Nightly in the background
Bring Nightly back to the foreground
The chrome is messed up, the URL bar has gone light, the status bar & settings menu is dark text on dark background
-> INCORRECT

If you do the opposite and toggle from Dark to Light the opposite happens but the chrome doesn't get messed up after backgrounding

Comment 17

[Mark]

Also bug 1811611

Comment 19

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S4. However, the following bug duplicate has higher severity:

• Bug 1872306: S3

:boek, could you consider increasing the severity of this bug to S3?

For more information, please visit BugBot documentation.