1853102 - Crash dialog “Continue with add-ons disabled” option is truncated on some devices

Status: VERIFIED FIXED

(Fenix :: WebExtensions, defect)

Description

[Alex Cornestean]

Attachment: Oppo Reno 6.jpg

Steps to reproduce

1. Open Fenix Nightly
2. Make sure the extensions process is enabled by checking about:processes (which should list an "Extensions" process)
3. Open about:crashextensions in a tab and reload multiple times - 6 times
4. A "crash dialog" should appear

Expected behavior

Crash dialog options are fully displayed and are not truncated.

Actual behavior

The “Continue with add-ons disabled” option from the crash dialog modal is truncated.

Device information

• Firefox version: Fenix Nightly 119.0a1 GV: 119.0a1-20230913205335
• Android device model: Oppo Reno6 5G
• Android OS version: 13

Any additional information?

The issue appears to affect only certain devices.

For example, the issue occurs on an 6.43 inch screen size Oppo Reno6 5G with 409 PPI density but does not occur on an 6.3 inch screen size Google Pixel 7 with 416 PPI density. Both devices run at the same resolution – 1080x2400 pixels with a 20:9 ratio.

Comment 1

[Alex Cornestean]

Attachment: Google Pixel 7.png

Comment 2

[Lorand Janos]

I've also managed to reproduce the same issue with an Oppo Find X5 (Android 13).
Screen size: 6.55inches.
Screen resolution: 1080 x 2400 pixels with a 20:9 ratio.
Pixel density: ~402 PPI.

Comment 3

[Lorand Janos]

Attachment: Oppo Find X5.JPEG

Comment 4

[William Durand [:willdurand]]

Attachment: oneplus2.png

Comment 5

[William Durand [:willdurand]]

It looks like a regression from Bug 1852984 to me :/

Comment 6

[Alex Cornestean]

Issue occurs with light mode as well.

Comment 7

[Alex Cornestean]

Attachment: Oppo Reno6 Light Mode.jpg

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1852984

Comment 9

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1853102 - Crash dialog "Continue with add-ons disabled" option is truncated on some devices. (#3642)

Comment 10

[Alex Cornestean]

The issues has been fixed and verified on a Nightly debug build from https://firefox-ci-tc.services.mozilla.com/tasks/SRLmItZcR2CAAl-Npxpymg.

The options are no longer truncated in either light or dark mode, portrait or landscape. In landscape, the area with the options is scrollable to ensure both options are reachable by the user.

Comment 11

[Alex Cornestean]

Attachment: light-mode-portrait.jpg

Comment 12

[Alex Cornestean]

Attachment: dark-mode-portrait.jpg

Comment 13

[Alex Cornestean]

Attachment: light-mode-landscape.jpg

Comment 14

[Alex Cornestean]

Attachment: dark-mode-landscape.jpg

Comment 15

[William Durand [:willdurand]]

:mixedpuppy as per the uplift request process guide, I'd like to nominate the PR as a candidate to backport to the 118 branch because it fixes a UI regression... Are you OK with that? Thanks!

Comment 16

[Shane Caraveo (:mixedpuppy)]

(In reply to William Durand [:willdurand] from comment #15)

:mixedpuppy as per the uplift request process guide, I'd like to nominate the PR as a candidate to backport to the 118 branch because it fixes a UI regression... Are you OK with that? Thanks!

approved

Comment 17

[BMO Github Automation]

Authored by https://github.com/Amejia481
https://github.com/mozilla-mobile/firefox-android/commit/9e3d31b0abd0caffb078fce69555a5524d2d174d
[main] Bug 1853102 - Crash dialog "Continue with add-ons disabled" option is truncated on some devices.

Comment 18

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1853102 - Crash dialog "Continue with add-ons disabled" option is truncated on some devices. (backport #3642) (#3648)

Comment 19

[William Durand [:willdurand]]

Comment on attachment 9353259 [details] [review]
[mozilla-mobile/firefox-android] Bug 1853102 - Crash dialog "Continue with add-ons disabled" option is truncated on some devices. (backport #3642) (#3648)

Beta/Release Uplift Approval Request

• User impact if declined: None but we cannot start the beta rollout without this patch.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's low risk because it has tests and we verified the fix with QA. It's changing some UI in a dialog that shouldn't appear, but if it does, we want this dialog to have the text on each button displayed without truncation.
• String changes made/needed:
• Is Android affected?: Yes

Comment 20

[Pascal Chevrel:pascalc]

Comment on attachment 9353259 [details] [review]
[mozilla-mobile/firefox-android] Bug 1853102 - Crash dialog "Continue with add-ons disabled" option is truncated on some devices. (backport #3642) (#3648)

Approved for 118.0b9 (last beta)  thanks.

Comment 21

[BMO Github Automation]

Authored by https://github.com/Amejia481
https://github.com/mozilla-mobile/firefox-android/commit/d035a811964a15b5af56bf1b6d1dd41795880068
[releases_v118] Bug 1853102 - Crash dialog "Continue with add-ons disabled" option is truncated on some devices.

Authored by https://github.com/pascalchevrel
https://github.com/mozilla-mobile/firefox-android/commit/3620b9d3402e171a700abb1dfe0d4762c5252e47
[releases_v118] Merge pull request #3648 from mozilla-mobile/mergify/bp/releases_v118/pr-3642

Comment 22

[Alex Cornestean]

Verified as Fixed. Tested on the latest Nightly 119.0a1 (Build #2015974243) d7873c7294+, GV: 119.0a1-20230914215834, AS: 119.20230914050403 on an Oppo Reno6 5G running Android 13.

The crash dialog options are no longer truncated in either light, dark, portrait or landscape modes. In landscape mode, the options are now fully displayed with no need for scrolling, as before, on the debug build.

For more details, see the attached screenshots.

I will also verify the bug is fixed on Beta once it becomes available.

Comment 23

[Alex Cornestean]

Attachment: 1694759313700.jpg

Comment 24

[Alex Cornestean]

Verfied as Fixed. Tested on the latest Beta 118.0b9 (Build #2015974267) 23c3ed5b9b+, GV: 118.0-20230914180032, AS: 118.0, available from https://firefox-ci-tc.services.mozilla.com/tasks/index/mobile.v3.firefox-android.apks.fenix-beta.latest/arm64-v8a on an Oppo Reno6 5G running Android 13.

The crash dialog options are not truncated in either light, dark, portrait or landscape modes. In landscape mode, the options are fully displayed with no need for scrolling.

See the attached screenshot for more details.

Comment 25

[Alex Cornestean]

Attachment: screenshot.png

Comment 26

[Arturo Mejia [:amejia]]

Thanks Alex for verifying!