1846979 - Implement process crash UI

Status: VERIFIED FIXED

(Fenix :: WebExtensions, enhancement)

Description

[William Durand [:willdurand]]

Once Bug 1819737 lands, we'll have a new delegate method that will notify Fenix when a process crash has happened. When that is the case and when the process is stopped by Gecko, we'll need to show some UI to users asking them to either be "ok with continuing without extensions for the rest of the session" OR "try to restart" the extensions process again (which might cause it to crash again).

Comment 1

[William Durand [:willdurand]]

Attachment: Screenshot 2023-08-11 at 16.22.25.png

This is the WIP from UX, some things will change but the overall design will not.

Comment 2

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1846979 - Add extensions process crash dialog strings (#3387)

Comment 3

[William Durand [:willdurand]]

Attachment: updated ux spec

Here is the updated spec from UX. That's what we want to ship.

Comment 4

[BMO Github Automation]

Authored by Zac McKenney
https://github.com/mozilla-mobile/firefox-android/commit/0cc85ed36c62b5ea3516b8c96f3a01043cebc3c9
[main] Bug 1846979 - Add extensions process crash dialog strings.

Comment 5

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1846979 - Extensions process spawning disabled dialog (#3472)

Comment 6

[BMO Github Automation]

Authored by Zac McKenney
https://github.com/mozilla-mobile/firefox-android/commit/2c533231b6886b1359065b7adac11fa1139aa4dc
[main] Bug 1846979 - Add extensions process spawning disabled dialog

Comment 7

[William Durand [:willdurand]]

For QA...

Prerequisite:

The extensions process must be enabled on Firefox for Android. Currently the STR are:

1. install nimbus-cli
2. create a file named feature.json and add the following content into it: { "enabled": true }
3. run: nimbus-cli --app fenix --channel nightly test-feature extensions-process ./feature.json

That command in (3) will load the experiment in fenix and that should also enable the extensions process.

You can unlock the "debug menu" in fenix by taping a few times to the Firefox logo in "Settings > About Firefox Nightly", this will add a "Nimbus Experiments" menu item, and the "extensions-process" nimbus feature should be listed there.

STR:

1. With the extensions process enabled, install an add-on, e.g. uBlock Origin
2. Open a new tab and go to about:processes, there should be an extensions process
3. Open a new tab and go to about:crashextensions
4. Reload the tab in (3) to crash the extensions process again. Repeat 4 times. At this point, the process has crashed 5 times.
5. Reload the tab in (3) one more time

Expected: a dialog is shown (more or less like in Comment 3) and about:processes should not have any extensions process anymore

If you click "try restarting add-ons", you should expect the extensions process to be listed in about:processes again.

If you click "continue with add-ons disabled", no extensions process should be listed in about:processes.

Comment 8

[William Durand [:willdurand]]

:mixedpuppy as per the uplift request process guide (which explains why I need your approval ;-)), I'd like to nominate the PR #3472 as a candidate to backport to the 118 branch so that we have the whole UI for the experiment. Are you OK with that? Thanks!

Comment 9

[Shane Caraveo (:mixedpuppy)]

(In reply to William Durand [:willdurand] from comment #8)

:mixedpuppy as per the uplift request process guide (which explains why I need your approval ;-)), I'd like to nominate the PR #3472 as a candidate to backport to the 118 branch so that we have the whole UI for the experiment. Are you OK with that? Thanks!

approved

Comment 10

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1846979 - Add extensions process spawning disabled dialog (backport #3472) (#3513)

Comment 11

[William Durand [:willdurand]]

Comment on attachment 9351800 [details] [review]
[mozilla-mobile/firefox-android] Bug 1846979 - Add extensions process spawning disabled dialog (backport #3472) (#3513)

Beta/Release Uplift Approval Request

• User impact if declined: None.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch is covered by tests and has been manually verified. We'd need this patch in 118 because it adds UI in Fenix for an experiment (extensions process).
• String changes made/needed:
• Is Android affected?: Yes

Comment 12

[Alex Cornestean]

Verified as Fixed. Tested on the latest Nightly for Android (119.0a1/Build #2015972707, d110b3c281+)(GV: 119.0a1-20230906214643)(AS: 119.20230906050317) based on the STR from Comment 7.

Results:

• Crashing the extensions process 6 times consecutively will display the UI.
• Selecting “Try restarting add-ons” will restart the extensions process and it will be visible in about:processes
• Selecting “Continue with add-ons disabled” will not restart the extensions process and it will no longer be listed in about:processes
• In case “Continue with add-ons disabled” has been selected, the extensions process can be restarted by restarting the browser or by disabling/re-enabling an installed add-on.

For more details see the attached screenshot.

Comment 13

[Alex Cornestean]

Attachment: Screenshot.jpg

Comment 14

[Pascal Chevrel:pascalc]

Comment on attachment 9351800 [details] [review]
[mozilla-mobile/firefox-android] Bug 1846979 - Add extensions process spawning disabled dialog  (backport #3472) (#3513)

Approved for 118.0b6, thanks.

Comment 15

[BMO Github Automation]

Authored by Zac McKenney
https://github.com/mozilla-mobile/firefox-android/commit/1a386d0be60c1322c5dd1bd859debc66a567aca3
[releases_v118] Bug 1846979 - Add extensions process spawning disabled dialog

Authored by https://github.com/pascalchevrel
https://github.com/mozilla-mobile/firefox-android/commit/9154a7d3978662973ac106796767b9c560217665
[releases_v118] Merge pull request #3513 from mozilla-mobile/mergify/bp/releases_v118/pr-3472

Comment 16

[Alex Cornestean]

Verified as Fixed. Tested on the latest Beta for Android build available from https://firefox-ci-tc.services.mozilla.com/tasks/index/mobile.v3.firefox-android.apks.fenix-beta.latest/arm64-v8a (118.0b6/Build #2015972923, 5b0ad0d350+)(GV: 118.0-20230907180212)(AS: 118) based on the STR from Comment 7.

Results:

• Crashing the extensions process 6 times consecutively will display the UI.
• Selecting “Try restarting add-ons” will restart the extensions process and it will be visible in about:processes
• Selecting “Continue with add-ons disabled” will not restart the extensions process and it will no longer be listed in about:processes
• In case “Continue with add-ons disabled” has been selected, the extensions process can be restarted by restarting the browser or by disabling/re-enabling an installed add-on.

For more details see the attached screenshot.

Comment 17

[Alex Cornestean]

Attachment: screenshot beta.jpeg