1853227 - [Survey] The stepper element misses aria-label and is announced by screen readers as "busy"

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Anna Yeddi [:ayeddi]]

Preconditions:

• Set the browser.shopping.experience2023.enabled - TRUE
• Set the browser.shopping.experience2023.optedIn - 1
• Set the browser.shopping.experience2023.survey.pdpVisits - 4
• Set the browser.shopping.experience2023.survey.hasSeen - FALSE
• Enable a screen reader, i.e. NVDA on Windows

STR:

1. Reach the following PDP link: https://www.amazon.com/dp/B07V6ZSHF4?th=1
2. Ensure the microsurvey Help improve Firefox is shown in the Shopping sidebar (if it's not, try reloading the page. ^{I'm not sure how to prompt it reliably})
3. Navigate to the stepper element within the survey container (i.e. with NVDA on WinOS, press Tab key through the Shopping Sidebar to the Help improve Firefox radio button group, then press DownArrow keys to move the tracking focus to the stepper
4. Observe the announcement for this element to find out: how many steps are in the process and which step is currently open.

Expected:

• A screen reader would announce the current position and total number of steps, i.e. 1 of 2. Good example is the stepper on about:welcome that is announced by VoiceOver on macOS as: Progress: step 1 of 4, busy, progress indicator

Actual:

• The progress bar misses the current position and the total number of steps, as well as its role, and only announces busy. A screen reader user won't be aware what the purpose of this element, why is it busy, and how many steps are in the survey.

The HTML element has attrs: aria-label but this attribute is not being rendered, thus no accessible name is provided to the progressbar. More on the use of this role: https://w3c.github.io/aria/#progressbar

Comment 1

[Jason Prickett]

Attachment: Bug 1853227 - Fix missing stepper element aria label for survey r?pdahiya,#omc-reviewers

Comment 2

[Phabricator Automation]

Comment on attachment 9353968 [details]
Bug 1853227 - Fix missing stepper element aria label for survey r?pdahiya,#omc-reviewers

Revision D188625 was moved to bug 1853228. Setting attachment 9353968 [details] to obsolete.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/735d4e8f49c6
Fix missing stepper element aria label for survey r=pdahiya,omc-reviewers,fluent-reviewers,flod,shopping-reviewers,kpatenio

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/735d4e8f49c6

Comment 5

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Nightly 120.0a1 (2023-10-19) as well as our latest RC build 119.