Closed Bug 1853245 Opened 1 years ago Closed 1 year ago

convert .ini manifests to .toml: batch 7 remaining browser.ini r=jmaher

Tracking

(firefox120 fixed)

Status:

RESOLVED FIXED

Milestone:

120 Branch

Tracking Flags:

Tracking

Status

firefox120

---

fixed

People

(Reporter: tmarble, Assigned: jmaher)

References

(Blocks 1 open bug)

Details

Attachments

(4 files, 1 obsolete file)

Bug 1853245 - Migrate .ini manifests to .toml (Batch 7.25). r=aryx! 1 year ago Joel Maher ( :jmaher ) (UTC -8) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1853245 - Migrate .ini manifests to .toml (Batch 7.5). r=aryx! 1 year ago Joel Maher ( :jmaher ) (UTC -8) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1853245 - Migrate .ini to .toml browser-chrome (batch 7.75). r=aryx! 1 year ago Joel Maher ( :jmaher ) (UTC -8) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1853245 - Migrate .ini to .toml browser-chrome (batch 7.99). r=aryx! 1 year ago Joel Maher ( :jmaher ) (UTC -8) 48 bytes, text/x-phabricator-request		Details \| Review
Bug 1853245 - Migrate .ini to .toml browser-chrome - fix file-whitespace issue. r=aryx! 1 year ago Joel Maher ( :jmaher ) (UTC -8) 48 bytes, text/x-phabricator-request		Details \| Review

Tom Marble

Reporter

Description

•

1 years ago

Convert batch 7 of *.ini files to *.toml (see list below)

Success criteria:

INI files moved to TOML to preserve history
References to INI files replaced with TOML equivalents (e.g. in moz.build)

Files:

     1	./editor/libeditor/tests/browser.ini
     2	./extensions/permissions/test/browser.ini
     3	./gfx/layers/apz/test/mochitest/browser.ini
     4	./gfx/tests/browser/browser.ini
     5	./image/test/browser/browser.ini
     6	./ipc/glue/test/browser/browser.ini
     7	./js/xpconnect/tests/browser/browser.ini
     8	./layout/base/tests/browser.ini
     9	./layout/style/test/browser.ini
    10	./layout/tools/layout-debug/tests/browser/browser.ini
    11	./layout/xul/test/browser.ini
    12	./modules/libpref/test/browser/browser.ini
    13	./netwerk/cookie/test/browser/browser.ini
    14	./netwerk/test/browser/browser.ini
    15	./parser/htmlparser/tests/mochitest/browser.ini
    16	./python/mozbuild/mozbuild/test/backend/data/test-manifest-shared-support/child/browser.ini
    17	./python/mozbuild/mozbuild/test/frontend/data/test-manifest-keys-extracted/browser.ini
    18	./python/mozbuild/mozbuild/test/frontend/data/test-manifest-shared-missing/child/browser.ini
    19	./python/mozbuild/mozbuild/test/frontend/data/test-manifest-shared-support/child/browser.ini
    20	./remote/cdp/test/browser/browser.ini
    21	./remote/cdp/test/browser/dom/browser.ini
    22	./remote/cdp/test/browser/emulation/browser.ini
    23	./remote/cdp/test/browser/fetch/browser.ini
    24	./remote/cdp/test/browser/input/browser.ini
    25	./remote/cdp/test/browser/io/browser.ini
    26	./remote/cdp/test/browser/log/browser.ini
    27	./remote/cdp/test/browser/network/browser.ini
    28	./remote/cdp/test/browser/page/browser.ini
    29	./remote/cdp/test/browser/runtime/browser.ini
    30	./remote/cdp/test/browser/security/browser.ini
    31	./remote/cdp/test/browser/systemInfo/browser.ini
    32	./remote/cdp/test/browser/target/browser.ini
    33	./remote/shared/listeners/test/browser/browser.ini
    34	./remote/shared/messagehandler/test/browser/broadcast/browser.ini
    35	./remote/shared/messagehandler/test/browser/browser.ini
    36	./remote/shared/messagehandler/test/browser/webdriver/browser.ini
    37	./remote/shared/test/browser/browser.ini
    38	./remote/webdriver-bidi/test/browser/browser.ini
    39	./security/manager/ssl/tests/mochitest/browser/browser.ini
    40	./security/sandbox/test/browser.ini
    41	./services/fxaccounts/tests/browser/browser.ini
    42	./startupcache/test/browser/browser.ini
    43	./testing/modules/tests/browser/browser.ini
    44	./testing/mozbase/moztest/tests/data/srcdir/juniper/browser.ini
    45	./testing/mozbase/moztest/tests/data/srcdir/kiwi/browser.ini
    46	./toolkit/components/aboutconfig/test/browser/browser.ini
    47	./toolkit/components/aboutprocesses/tests/browser/browser.ini
    48	./toolkit/components/aboutthirdparty/tests/browser/browser.ini
    49	./toolkit/components/aboutwindowsmessages/tests/browser/browser.ini
    50	./toolkit/components/alerts/test/browser.ini
    51	./toolkit/components/antitracking/bouncetrackingprotection/test/browser/browser.ini
    52	./toolkit/components/antitracking/test/browser/browser.ini
    53	./toolkit/components/backgroundtasks/tests/browser/browser.ini
    54	./toolkit/components/certviewer/tests/browser/browser.ini
    55	./toolkit/components/cleardata/tests/browser/browser.ini
    56	./toolkit/components/contentprefs/tests/browser/browser.ini
    57	./toolkit/components/cookiebanners/test/browser/browser.ini
    58	./toolkit/components/credentialmanagement/tests/browser/browser.ini
    59	./toolkit/components/enterprisepolicies/tests/browser/browser.ini
    60	./toolkit/components/extensions/test/browser/browser.ini
    61	./toolkit/components/forgetaboutsite/test/browser/browser.ini
    62	./toolkit/components/glean/tests/browser/browser.ini
    63	./toolkit/components/httpsonlyerror/tests/browser/browser.ini
    64	./toolkit/components/messaging-system/schemas/SpecialMessageActionSchemas/test/browser/browser.ini
    65	./toolkit/components/messaging-system/schemas/TriggerActionSchemas/test/browser/browser.ini
    66	./toolkit/components/mozprotocol/tests/browser.ini
    67	./toolkit/components/narrate/test/browser.ini
    68	./toolkit/components/nimbus/test/browser/browser.ini
    69	./toolkit/components/normandy/test/browser/browser.ini
    70	./toolkit/components/passwordmgr/test/browser/browser.ini
    71	./toolkit/components/pdfjs/test/browser.ini
    72	./toolkit/components/pictureinpicture/tests/browser.ini
    73	./toolkit/components/places/tests/browser/browser.ini
    74	./toolkit/components/places/tests/browser/previews/browser.ini
    75	./toolkit/components/printing/tests/browser.ini
    76	./toolkit/components/processtools/tests/browser/browser.ini
    77	./toolkit/components/reader/test/browser.ini
    78	./toolkit/components/remotebrowserutils/tests/browser/browser.ini
    79	./toolkit/components/resistfingerprinting/tests/browser/browser.ini
    80	./toolkit/components/satchel/test/browser/browser.ini
    81	./toolkit/components/shopping/test/browser/browser.ini
    82	./toolkit/components/startup/tests/browser/browser.ini
    83	./toolkit/components/telemetry/tests/browser/browser.ini
    84	./toolkit/components/thumbnails/test/browser.ini
    85	./toolkit/components/tooltiptext/tests/browser.ini
    86	./toolkit/components/translations/tests/browser/browser.ini
    87	./toolkit/components/url-classifier/tests/browser/browser.ini
    88	./toolkit/components/viewsource/test/browser/browser.ini
    89	./toolkit/components/windowcreator/test/browser.ini
    90	./toolkit/components/windowwatcher/test/browser.ini
    91	./toolkit/content/tests/browser/browser.ini
    92	./toolkit/content/tests/browser/datetime/browser.ini
    93	./toolkit/crashreporter/test/browser/browser.ini
    94	./toolkit/modules/tests/browser/browser.ini
    95	./toolkit/mozapps/downloads/tests/browser/browser.ini
    96	./toolkit/mozapps/extensions/test/browser/browser.ini
    97	./toolkit/mozapps/extensions/test/xpinstall/browser.ini
    98	./toolkit/mozapps/update/tests/browser/browser.ini
    99	./toolkit/mozapps/update/tests/browser/manual_app_update_only/browser.ini
   100	./toolkit/xre/test/browser.ini
   101	./tools/profiler/tests/browser/browser.ini
   102	./uriloader/exthandler/tests/mochitest/browser.ini
   103	./widget/tests/browser/browser.ini

Tom Marble

Reporter

Updated

•

1 years ago

Blocks: 1821199

Comment 1

•

1 year ago

Attached file Bug 1853245 - Migrate .ini manifests to .toml (Batch 7.25). r=aryx! — Details

Phabricator Automation

Updated

•

1 year ago

Assignee: nobody → jmaher

Status: UNCONFIRMED → ASSIGNED

Ever confirmed: true

Pulsebot

Comment 2

•

1 year ago

Pushed by jmaher@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6753f9b9b2da Migrate .ini manifests to .toml (Batch 7.25). r=aryx,webdriver-reviewers,whimboo

Joel Maher ( :jmaher ) (UTC -8)

Assignee

Comment 3

•

1 year ago

Attached file Bug 1853245 - Migrate .ini manifests to .toml (Batch 7.5). r=aryx! — Details

Narcis Beleuzu [:NarcisB]

Comment 4

•

1 year ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/6753f9b9b2da

Status: ASSIGNED → RESOLVED

Closed: 1 year ago

status-firefox120: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → 120 Branch

Joel Maher ( :jmaher ) (UTC -8)

Assignee

Comment 5

•

1 year ago

I have a couple more patches to do here

Status: RESOLVED → REOPENED

Resolution: FIXED → ---

BugBot [:suhaib / :marco/ :calixte]

Updated

•

1 year ago

status-firefox120: fixed → affected

Joel Maher ( :jmaher ) (UTC -8)

Assignee

Comment 6

•

1 year ago

Attached file Bug 1853245 - Migrate .ini to .toml browser-chrome (batch 7.75). r=aryx! — Details

Pulsebot

Comment 7

•

1 year ago

Pushed by jmaher@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/96ff91b8355e Migrate .ini manifests to .toml (Batch 7.5). r=aryx,extension-reviewers,robwu

Pulsebot

Comment 8

•

1 year ago

Pushed by jmaher@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8265e6272d20 Migrate .ini to .toml browser-chrome (batch 7.75). r=aryx,extension-reviewers,application-update-reviewers,credential-management-reviewers,places-reviewers,profiler-reviewers,nalexander,canaltinova,Standard8,robwu,sgalich

Narcis Beleuzu [:NarcisB]

Comment 9

•

1 year ago

Backed out for breaking the Decision Task

Backout link: https://hg.mozilla.org/integration/autoland/rev/1019d4f9631452f203a8adfa3c8ccb784d81b6c4
Log link: https://treeherder.mozilla.org/logviewer?job_id=430806651&repo=autoland&lineNumber=2896

Flags: needinfo?(jmaher)

Pulsebot

Comment 10

•

1 year ago

Pushed by jmaher@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6ffc8bdec837 Migrate .ini to .toml browser-chrome (batch 7.75). r=aryx,extension-reviewers,application-update-reviewers,credential-management-reviewers,places-reviewers,profiler-reviewers,nalexander,canaltinova,Standard8,robwu,sgalich

Joel Maher ( :jmaher ) (UTC -8)

Assignee

Comment 11

•

1 year ago

small typo, thanks for backing this out

Flags: needinfo?(jmaher)

Cristian Tuns

Comment 12

•

1 year ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/96ff91b8355e
https://hg.mozilla.org/mozilla-central/rev/6ffc8bdec837

Status: REOPENED → RESOLVED

Closed: 1 year ago → 1 year ago

status-firefox120: affected → fixed

Resolution: --- → FIXED

Mike Kaply [:mkaply]

Comment 13

•

1 year ago

So it looks like all these files have CRLF line endings? Was that intentional?

Joel Maher ( :jmaher ) (UTC -8)

Assignee

Comment 14

•

1 year ago

no, that wasn't seen in phabricator, that is frustrating. I did these conversions on windows, I have one more patch almost ready for review on windows, let me look closer at the line endings before submitting it.

Mark Banner (:standard8)

Comment 15

•

1 year ago

(In reply to Joel Maher ( :jmaher ) (UTC -8) from comment #14)

no, that wasn't seen in phabricator, that is frustrating. I did these conversions on windows, I have one more patch almost ready for review on windows, let me look closer at the line endings before submitting it.

We should enable at least the file-perms and file-whitespace linters - I've filed bug 1856463 that can be used for the work.

Joel Maher ( :jmaher ) (UTC -8)

Assignee

Comment 16

•

1 year ago

Attached file Bug 1853245 - Migrate .ini to .toml browser-chrome (batch 7.99). r=aryx! — Details

Pulsebot

Comment 17

•

1 year ago

Pushed by jmaher@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/54a1341a95d6 Migrate .ini to .toml browser-chrome (batch 7.99). r=aryx,webdriver-reviewers,necko-reviewers,pip-reviewers,places-reviewers,mak,mconley,kershaw

Joel Maher ( :jmaher ) (UTC -8)

Assignee

Comment 18

•

1 year ago

Attached file Bug 1853245 - Migrate .ini to .toml browser-chrome - fix file-whitespace issue. r=aryx! (obsolete) — Details

Pulsebot

Comment 19

•

1 year ago

Pushed by sstanca@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d09e9295477f Migrate .ini to .toml browser-chrome - fix file-whitespace issue. r=aryx! CLOSED TREE

Norisz Fay [:noriszfay]

Comment 20

•

1 year ago

Backed out for causing python failure

Backout link

Push with failures

Failure log

Failure log for the lint failure fixed in d09e9295477f

Flags: needinfo?(jmaher)

Pulsebot

Comment 21

•

1 year ago

Pushed by jmaher@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6428a900f460 Migrate .ini to .toml browser-chrome (batch 7.99). r=aryx,webdriver-reviewers,necko-reviewers,pip-reviewers,places-reviewers,mak,mconley,kershaw

Joel Maher ( :jmaher ) (UTC -8)

Assignee

Comment 22

•

1 year ago

fixed all whitespace and ci unittest failures.

Flags: needinfo?(jmaher)

Cristina Horotan [:chorotan]

Comment 23

•

1 year ago

bugherder

https://hg.mozilla.org/mozilla-central/rev/6428a900f460

Phabricator Automation

Updated

•

1 year ago

Attachment #9356659 - Attachment is obsolete: true

You need to log in before you can comment on or make changes to this bug.