1821207 - convert .ini manifests to .toml

Status: RESOLVED FIXED

(Testing :: General, task)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

this should be able to be scripted, I imagine some steps would be:

1. read in .ini files, hack write them out; whatever doesn't match (specifically comments aligning with the wrong section) needs attention
2. read .ini, write .toml, ensure read+write .toml files are identical
3. read .toml, hack write .ini, diff what is different, should be same as #1;
4. manually edit the differences
5. for .toml files, write them out in alphanumeric sorted order for the test cases

there will be some cases that need to be handled differently, I imagine:

• relative path manifests (like include ../blah/blah.ini)
• tools that generate/copy .ini files
• probably others I cannot think of right now

The end result of this patch will be for most mochitest.ini, browser.ini, chrome.ini, xpcshell.ini we will rename them to *.toml and have them edited in proper .toml format.

Comment 1

[Geoff Lankow (:darktrojan)]

I filed a bug to do the same on comm-central, so you can let us know when we need to do something.

Comment 2

[Tom Marble]

Attachment: Bug 1821207 - convert .ini manifests to .toml (partial) r=jmaher

Comment 3

[Tom Marble]

Attachment: Bug 1821207 - convert .ini manifests to .toml (partial) r=jmaher

Comment 4

[Tom Marble]

Attachment: Bug 1821207 - convert .ini manifests to .toml (batch 1) r=jmaher

Updates manifestparser tests to explicity set use_toml

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3dd53f46f9eb
convert .ini manifests to .toml (partial) r=jmaher

Comment 6

[Serban Stanca [:SerbanS]]

Backed out for causing manifest.ini related build bustages.

• Backout link
• Push with failures
• Failure Log
• Failure line: KeyError: '/builds/worker/checkouts/gecko/testing/mozbase/manifestparser/tests/manifest.ini'

Comment 7

[Tom Marble]

Backout is okay -- KeyError fix coming in a future patch (for Bug 1821207)

Comment 8

[Tom Marble]

Attachment: Bug 1821207 - convert .ini manifests to .toml (partial + batch 1) r=jmaher

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ec48256d007f
convert .ini manifests to .toml (partial + batch 1) r=jmaher

Comment 10

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/ec48256d007f

Comment 11

[:Gijs (he/him)]

This now logs for every manifest read. E.g. executing ./mach addtest reads a test manifest, running ./mach build in some circumstances reads a lot of test manifests... was that intentional?

Comment 12

[Tom Marble]

Yes this is intentional. The amount of manifest reading has not changed, however during the transition (Bug 1821199) we use this log verbosity to ensure that ManifestParser is reading the new TOML manifests.