1853560 - [felt] Private windows are partially broken with Pocket button removed from toolbar

Status: VERIFIED FIXED

(Firefox :: Private Browsing, defect)

Description

[Kestrel]

STR:

1. Set browser.privatebrowsing.felt-privacy-v1 = true.
2. Remove the Pocket button from the toolbar or disable it with extensions.pocket.enabled = false.
3. Open a private window.
4. Click the hamburger menu.

Hamburger menu fails to open, initial private browsing page is blank purple.

Console error:

Uncaught TypeError: can't access property "remove", document.getElementById(...) is null
    PBUI_init chrome://browser/content/browser.js:8382
    onLoad chrome://browser/content/browser.js:1710

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=366fe4ef2cd3ed22efdda09ad0e5d7b44a4a31ca&tochange=8b6aebdd4f919dc1515c304bbf8824a178e3f0ae

Regressed by Bug 1846583.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:dwalker, since you are the author of the regressor, bug 1846583, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[DJ (:dwalker)]

Attachment: Bug 1853560 - Check for presence of pocket button before deletion. r?mhowell

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ffc1096d06f9
Check for presence of pocket button before deletion. r=mhowell

Comment 4

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/ffc1096d06f9

Comment 5

[Anca Soncutean, Desktop QA]

Reproduced with Fx 119.0a1 (2023-09-17) on Windows 10.
Verified fixed with Fx 120.0a1 (2023-10-02) and Fx 119.0b4 on Windows 10, macOS 13 and Ubuntu 22.