1853643 - "IP:Port" URL still interpreted as HTTP even with trimHttps, leading to inconsistency

Status: RESOLVED DUPLICATE of bug 1848715

(Firefox :: Address Bar, defect, P3)

Description

[Jan Alexander Steffens [:heftig]]

Say I'm connected to https://192.168.0.1:1234.

With trimHttps enabled, the address bar only displays 192.168.0.1:1234 but copying the entire location actually copies https://192.168.0.1:1234. This is fine.

However, when I then edit the location to say 192.168.0.1:12345 and press enter, it interprets this as http://192.168.0.1:12345 instead of the https://192.168.0.1:12345 I expected.

https_first and https_only modes do not help. I suppose IP:Port addresses are excluded here.

Comment 1

[Jan Alexander Steffens [:heftig]]

Whoops, accidentally fat-fingered Return while editing the subject. Editing the rest...

Comment 2

[Jan Alexander Steffens [:heftig]]

Chrome restores the https:// when starting to edit, so it's not a problem there.

Comment 3

[Marc Seibert (:mseibert)]

I filed a similar issue Bug 1847723. The problem is that Services.uriFixup.getFixupURIInfo always prepends http:// if there is no protocol explicitly given.

Comment 4

[Jan Alexander Steffens [:heftig]]

https_only_mode does help after enabling dom.security.https_only_mode.upgrade_local, but https_first is apparently never applied to addresses with a port.

Comment 5

[Marco Bonardo [:mak]]

What happens here is that by modifying the url it becomes something completely different, there's no given that 192.168.0.1:12345 uses the same protocol as 192.168.0.1:1234. Any assumption about a protocol here has a 50% chance of being wrong.
That's why I don't think this is a P2, we are doing our best with the information at hand, we can't know what the url is, we take the most likely (very few local servers are using https today, yet).

The work being done in bug 1812192 should help here, what we can do is to detect that the address bar added a protocol, and then allow a downgrade to http (or upgrade to https).

I'm tempted to just call this a dupe of bug 1812192, but let's keep it as a dep for now.

Comment 6

[BugBot [:suhaib / :marco]]

This bug has been marked as a regression. Setting status flag for Nightly to affected.

Comment 7

[Jan Alexander Steffens [:heftig]]

Now that trimHttps has been enabled by default, this is now affecting Nightly by default.

Comment 8

[Stuart Colville [:muffinresearch]]

Based on comment 5 can this be closed out?

Comment 9

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1853418

Comment 10

[Marco Bonardo [:mak]]

I think editing the url makes it a wontfix, though a better solution for the users will be Bug 1848715, where on focus we will untrim the url, then when editing or copying the protocol will be there. So duping there.