Closed Bug 1853418 Opened 7 months ago Closed 6 months ago

Enable https trimming and insecure connection label in Nightly.

Categories

(Firefox :: Address Bar, task, P2)

task

Tracking

()

VERIFIED FIXED
121 Branch
Tracking Status
firefox121 --- verified

People

(Reporter: mseibert, Assigned: mseibert)

References

(Blocks 2 open bugs, Regressed 3 open bugs)

Details

(Whiteboard: [fxprivacy] [sng])

Attachments

(10 files, 2 obsolete files)

48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review

The goal of this issue is to enable prefs "trimHttps" (introduced in Bug #1067293) and "security.insecure_connection_text.enabled", "security.insecure_connection_text.pbmode.enabled" (introduced in Bug #1310447).

A lot of tests need to be adapted in order to cover https and http trimming. Additionally some tests derive the site identity by looking at the icon class. The insecure connection label interferes with that.

Assignee: nobody → mseibert
Whiteboard: [fxprivacy] → [fxprivacy] [sng]
Summary: Enable https trimming and insecure connection label. → Enable https trimming and insecure connection label in Nightly.
Depends on: 1310447
Status: NEW → ASSIGNED
Severity: -- → N/A
Priority: -- → P2
Depends on: 1812192
Attachment #9353506 - Attachment description: WIP: Bug 1853418 - Enable https trimming and insecure connection label in Nightly. → Bug 1853418 - Enable https trimming and insecure connection label in Nightly.r=dao

To enable trimHttps and the insecure connection label a lot of tests need to be updated. Reasons for that is that a lot of tests assume that "http" is trimmed and "https" is not. A lot of tests had to be touched and in order to make the overall patch digestiable I split it into multiple (grouping by components).

The first patch that needs to be landed is "Bug 1853418 - Prepare Urlbar Tests" as this one contains helper functions for the other patches.

In a final step the "Bug 1853418 - Enable https trimming and insecure connection label in Nightly" should be landed, which essentially enables said prefs in nightly.

Keywords: leave-open
Attachment #9353506 - Attachment is obsolete: true

Backed out for causing bc failures on browser_closePanelOnClick.js

Backout link

Push with failures

Failure log

Flags: needinfo?(mseibert)
Flags: needinfo?(mseibert)

Comment on attachment 9358842 [details]
Bug 1853418 - Urlbar Test Utils Preparation.r=dao

New try run: https://treeherder.mozilla.org/jobs?repo=try&revision=33f3cb1ebb9abd24bc983980da239f944d5668b3

Unfortunately this does not seem to include the job that failed last night. I guess we'll just try landing this again and see what happens. :/

Flags: needinfo?(mseibert)
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/11bc759d0fb7
Urlbar Test Utils Preparation.r=dao
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d30146225672
Prepare netwerk tests.r=dao,necko-reviewers,valentin
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/046d1dae1745
Prepare Site-Identity and Statuspanel Tests.r=dao
Depends on: 1859813
Attachment #9357577 - Attachment is obsolete: true
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/785ce00db669
Enable https trimming and insecure connection label in Nightly.r=dao
Keywords: leave-open
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 121 Branch

Tested using the latest Fx 121.0a1 on Windows 10, Ubuntu 20.04 and macOS 12.
The following prefs are all enabled by default (true value):

  • browser.urlbar.trimHttps
  • security.insecure_connection_text.enabled
  • security.insecure_connection_text.pbmode.enabled
  1. HTTPS is correctly trimmed from URLs and http is correctly displayed for insecure links
  2. 'Not Secure' label is correctly displayed on the lock icon in normal and private browsing modes
  3. Pasted trimmed links is correctly done in URL bar as well as outside Firefox
Status: RESOLVED → VERIFIED

Did you want to nominate this for the Nightly release notes?

Flags: needinfo?(mseibert)

Release Note Request (optional, but appreciated)
[Why is this notable]: Enables “https” trimming instead of “http” when the Urlbar is unfocused.
[Affects Firefox for Android]: no
[Suggested wording]: URLs in the Address bar now have “https://” hidden by default. Additionally, a “Not Secure” label is shown for unsafe connections.
[Links (documentation, blog post, etc)]:

Flags: needinfo?(mseibert)

Note this will remain nightly-only until we address other concerns with related changes to https-first.
I think we may want better copy for the notes, considered recently some misinformation was spread around this change. Or we should just skip notes until we're ready for release.

Alright, just set the relnote-firefox flag to ? when you're ready.

Regressions: 1862156
Regressions: 1863958
Regressions: 1848715
Regressions: 1853643
Regressions: 1868477
Regressions: 1868605
Regressions: 1870768
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: