1853418 - Enable https trimming and insecure connection label in Nightly.

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P2)

Description

[Marc Seibert (:mseibert)]

The goal of this issue is to enable prefs "trimHttps" (introduced in Bug #1067293) and "security.insecure_connection_text.enabled", "security.insecure_connection_text.pbmode.enabled" (introduced in Bug #1310447).

A lot of tests need to be adapted in order to cover https and http trimming. Additionally some tests derive the site identity by looking at the icon class. The insecure connection label interferes with that.

Comment 1

[Marc Seibert (:mseibert)]

Attachment: Bug 1853418 - Enable https trimming and insecure connection label in Nightly.r=dao

Comment 2

[Marc Seibert (:mseibert)]

Attachment: Bug 1853418 - Prepare Site-Identity and Statuspanel Tests.r=dao

Comment 3

[Marc Seibert (:mseibert)]

Attachment: Bug 1853418 - Prepare Urlbar Tests.r=dao

Comment 4

[Marc Seibert (:mseibert)]

Attachment: Bug 1853418 - Prepare tab-related tests.r=dao

Comment 5

[Marc Seibert (:mseibert)]

Attachment: Bug 1853418 - Prepare netwerk tests.r=dao

Comment 6

[Marc Seibert (:mseibert)]

Attachment: Bug 1853418 - Prepare remaining tests.r=dao

Comment 7

[Marc Seibert (:mseibert)]

Attachment: Bug 1853418 - Enable https trimming and insecure connection label in Nightly.r=dao

Comment 8

[Marc Seibert (:mseibert)]

To enable trimHttps and the insecure connection label a lot of tests need to be updated. Reasons for that is that a lot of tests assume that "http" is trimmed and "https" is not. A lot of tests had to be touched and in order to make the overall patch digestiable I split it into multiple (grouping by components).

The first patch that needs to be landed is "Bug 1853418 - Prepare Urlbar Tests" as this one contains helper functions for the other patches.

In a final step the "Bug 1853418 - Enable https trimming and insecure connection label in Nightly" should be landed, which essentially enables said prefs in nightly.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1c43d6be9b10
Prepare Urlbar Tests.r=dao

Comment 10

[Norisz Fay [:noriszfay]]

Backed out for causing bc failures on browser_closePanelOnClick.js

Backout link

Push with failures

Failure log

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/444db85796e2
Prepare Urlbar Tests.r=dao

Comment 12

[Narcis Beleuzu [:NarcisB]]

Backed out for bc failure on browser_closePanelOnClick.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/aeef1b6cce72a720b2929b2f6c4de35348378a73
Log link: https://treeherder.mozilla.org/logviewer?job_id=432695401&repo=autoland&lineNumber=9941

Comment 13

[Marc Seibert (:mseibert)]

Attachment: Bug 1853418 - Urlbar Test Utils Preparation.r=dao

Comment 14

[Dão Gottwald [:dao]]

Comment on attachment 9358842 [details]
Bug 1853418 - Urlbar Test Utils Preparation.r=dao

New try run: https://treeherder.mozilla.org/jobs?repo=try&revision=33f3cb1ebb9abd24bc983980da239f944d5668b3

Unfortunately this does not seem to include the job that failed last night. I guess we'll just try landing this again and see what happens. :/

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/11bc759d0fb7
Urlbar Test Utils Preparation.r=dao

Comment 16

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/11bc759d0fb7

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d30146225672
Prepare netwerk tests.r=dao,necko-reviewers,valentin

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f186c6070b4
Prepare remaining tests.r=dao

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/046d1dae1745
Prepare Site-Identity and Statuspanel Tests.r=dao

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a42179c6b78
Prepare tab-related tests.r=dao

Comment 21

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d30146225672
https://hg.mozilla.org/mozilla-central/rev/2f186c6070b4
https://hg.mozilla.org/mozilla-central/rev/046d1dae1745
https://hg.mozilla.org/mozilla-central/rev/1a42179c6b78

Comment 22

[Marc Seibert (:mseibert)]

Attachment: Bug 1853418 - Prepare Urlbar Tests Part 1.r=dao

Comment 23

[Marc Seibert (:mseibert)]

Attachment: Bug 1853418 - Prepare Urlbar Tests Part 2.r=dao

Comment 24

[Marc Seibert (:mseibert)]

Attachment: Bug 1853418 - Prepare Urlbar Tests Part 3.r=dao

Comment 25

[Marc Seibert (:mseibert)]

Attachment: Bug 1853418 - Prepare Urlbar Tests Part 4.r=dao

Comment 26

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ebaa2ebadc63
Prepare Urlbar Tests Part 1.r=dao

Comment 27

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9b9338fa0b8
Prepare Urlbar Tests Part 2.r=dao

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4fb6485ac7d
Prepare Urlbar Tests Part 3.r=dao

Comment 29

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/ebaa2ebadc63
https://hg.mozilla.org/mozilla-central/rev/b9b9338fa0b8
https://hg.mozilla.org/mozilla-central/rev/c4fb6485ac7d

Comment 30

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cf7b87dc3489
Prepare Urlbar Tests Part 4.r=dao

Comment 31

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/785ce00db669
Enable https trimming and insecure connection label in Nightly.r=dao

Comment 32

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/cf7b87dc3489

Comment 33

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/785ce00db669

Comment 34

[Cristian Baica [:cbaica], Release Desktop QA]

Tested using the latest Fx 121.0a1 on Windows 10, Ubuntu 20.04 and macOS 12.
The following prefs are all enabled by default (true value):

• browser.urlbar.trimHttps
• security.insecure_connection_text.enabled
• security.insecure_connection_text.pbmode.enabled

1. HTTPS is correctly trimmed from URLs and http is correctly displayed for insecure links
2. 'Not Secure' label is correctly displayed on the lock icon in normal and private browsing modes
3. Pasted trimmed links is correctly done in URL bar as well as outside Firefox

Comment 35

[Ryan VanderMeulen [:RyanVM]]

Did you want to nominate this for the Nightly release notes?

Comment 36

[Marc Seibert (:mseibert)]

Release Note Request (optional, but appreciated)
[Why is this notable]: Enables “https” trimming instead of “http” when the Urlbar is unfocused.
[Affects Firefox for Android]: no
[Suggested wording]: URLs in the Address bar now have “https://” hidden by default. Additionally, a “Not Secure” label is shown for unsafe connections.
[Links (documentation, blog post, etc)]:

Comment 37

[Marco Bonardo [:mak]]

Note this will remain nightly-only until we address other concerns with related changes to https-first.
I think we may want better copy for the notes, considered recently some misinformation was spread around this change. Or we should just skip notes until we're ready for release.

Comment 38

[Ryan VanderMeulen [:RyanVM]]

Alright, just set the relnote-firefox flag to ? when you're ready.