Closed Bug 1853744 Opened 1 year ago Closed 1 year ago

Fix a-element-xhtml.xhtml ends in a number checker test failure

Categories

(Core :: Networking, defect, P2)

defect

Tracking

()

RESOLVED FIXED
120 Branch
Tracking Status
firefox120 --- fixed

People

(Reporter: edgul, Assigned: dotoole)

References

(Blocks 1 open bug)

Details

(Whiteboard: [necko-triaged])

Attachments

(1 file)

In the test testing/web-platform/meta/url/a-element-xhtml.xhtml.ini we have a failing case [Parsing: <http://999999999.> against <http://other.com/>].

The problem here is that this passes the EndsInANumber check, but fails ValidateIPv4Number.
We can get it to pass if we strip the last dot in NormalizeIPv4. And we should also change ValidateIPv4Number to not change the length anymore.

This is a followup to Bug 1723456

Severity: -- → S4
Priority: -- → P2
See Also: → 1723456
Whiteboard: [necko-triaged]
Assignee: nobody → dotoole
Status: NEW → ASSIGNED
Pushed by dotoole@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e7c16a228ce4 Stripped the last dot in NormalizeIPv4 and ValidateIPv4Number no longer changes length if last character is dot. r=valentin,necko-reviewers,edgul
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: