1853881 - Assert the margin for the stack quota is sufficient for the gap between 2 stack quota verifications

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P3)

Description

[Tooru Fujisawa [:arai]]

Bug 1853480 restores the stack quota for off-thread compilation, with a margin subtracted from the TaskController's stack size, the reason is that the stack quota is not checked for each function call in parser/compiler, but only in some functions which the execution frequently reaches.
We should assert that the margin is sufficient for the gap between those 2 stack quota checks.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1853881 - Part 1: Add JS::ThreadStackQuotaForSize and use it everywhere. r?nbp!

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1853881 - Part 2: Assert the stack margin is sufficient. r?nbp!

Depends on D191905

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d250b2f13783
Part 1: Add JS::ThreadStackQuotaForSize and use it everywhere. r=nbp
https://hg.mozilla.org/integration/autoland/rev/e9c3d57463a0
Part 2: Assert the stack margin is sufficient. r=nbp

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d250b2f13783
https://hg.mozilla.org/mozilla-central/rev/e9c3d57463a0