1853970 - 11.49 - 8.77% tresize / tresize + 1 more (Linux) regression on Fri September 15 2023

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Andrej (:aglavic)]

Perfherder has detected a talos performance regression from push 427a6983a14b5b36e6e679e78b466f96f9977049. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
11%	tresize	linux1804-64-shippable-qr	e10s fission stylo webrender	30.53 -> 34.04
11%	tresize	linux1804-64-shippable-qr	e10s fission stylo webrender	30.69 -> 33.99
9%	tresize	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	30.69 -> 33.38

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

For more information on performance sheriffing please see our FAQ.

Comment 1

[Andrej (:aglavic)]

To be clear this on https://treeherder.mozilla.org/jobs?repo=autoland&revision=427a6983a14b5b36e6e679e78b466f96f9977049
Which includes 427a6983a14b5b36e6e679e78b466f96f9977049 and aac846ab41a5080e71303cd75bd7df22c8fd99be

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1852084

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: WIP: Bug 1853970 - Try to extract background ourselves.

The idea was to be able to render the linear gradient natively, but that
didn't quite cut it, because GTK exposes regular linear-gradient()s as
images.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

https://treeherder.mozilla.org/perfherder/compare?originalProject=try&originalRevision=43d99b3061950dd1d39ce7c15dc90755db13432c&newProject=try&newRevision=bd67818cc53a81545a1f9e54655c82118a267888&page=1 is another attempt...

Comment 5

[Donal Meehan [:dmeehan]]

Setting Fx119 to fixed, the regressor was backed out
https://bugzilla.mozilla.org/show_bug.cgi?id=1852084#c13

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Fixed by backout.