1852084 - Navigator toolbox missing bottom border with System theme on Ubuntu

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Kestrel]

Attachment: No border between browser chrome and content

The System theme does not display a bottom border on the navigator toolbox on Ubuntu 23.04. #navigator-toolbox has border-bottom-width: 0px.

Light and Dark themes are not affected.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=3ccfd029bb7ad0acbb1f36e48d2366d9835a34eb&tochange=7b7144975b319945642a90653847a06d03f111b7

Regressed by Bug 1850827.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1850827, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Asif Youssuff]

This is also happening on Fedora, FYI.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1852084 - Don't use foreign drawing to draw titlebar. r=stransky

This approach works and is more consistent with how everything else
works, but we lose the titlebar gradient in Adwaita. It still looks good
tho, and gtk4 doesn't use gradient in the titlebar, so maybe it's just
fine, wdyt?

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1852084 - Cleanup image function parsing. r=#style,#layout

Depends on D187765

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1852084 - Add a -moz-themed(<appearance>) background-image. r=#style,#layout,#desktop-theme-reviewers

Some appearance values are really just a background.

Being able to draw them using background-image instead of appearance
allows us to preserve borders, etc.

Depends on D187850

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1852084 - Use background-image instead of native appearance to draw native titlebar on Linux. r=stransky

This should preserve native gradients etc, but allow borders, paddings and
so on.

Depends on D187851

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1aad95d98642
Cleanup image function parsing. r=boris

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/1aad95d98642

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/890cdd998771
Don't use foreign drawing to draw titlebar. r=desktop-theme-reviewers,dao

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/890cdd998771

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aac846ab41a5
Add a -moz-themed(<appearance>) background-image. r=boris
https://hg.mozilla.org/integration/autoland/rev/427a6983a14b
Use background-image instead of native appearance to draw native titlebar on Linux. r=desktop-theme-reviewers,dao

Comment 12

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/aac846ab41a5
https://hg.mozilla.org/mozilla-central/rev/427a6983a14b

Comment 13

[Iulian Moraru]

Backed out 2 changesets (bug 1852084) for causing bug 1853970.

• Push that was backed out

• Backout link

Comment 14

[Emilio Cobos Álvarez (:emilio)]

Okay, I think I'll call this fixed. Let's try to go with the non-native titlebar, along with bug 1854275 to not make it so obvious.

Comment 15

[Andra Esanu (needinfo me)]

(In reply to Pulsebot from comment #11)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aac846ab41a5
Add a -moz-themed(<appearance>) background-image. r=boris
https://hg.mozilla.org/integration/autoland/rev/427a6983a14b
Use background-image instead of native appearance to draw native titlebar on
Linux. r=desktop-theme-reviewers,dao

== Change summary for alert #39761 (as of Tue, 03 Oct 2023 05:12:24 GMT) ==

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)	Performance Profiles
4%	youtube SpeedIndex	linux1804-64-shippable-qr	fission warm webrender	1,250.05 -> 1,198.30	Before/After
3%	youtube SpeedIndex	linux1804-64-shippable-qr	fission warm webrender	1,248.13 -> 1,204.98	Before/After

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=39761