144.59 - 7.44% tp5o_webext XRes / tp5o_scroll + 2 more (Linux) regression on Thu September 14 2023
Categories
(Core :: Widget: Gtk, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr102 | --- | unaffected |
| firefox-esr115 | --- | unaffected |
| firefox117 | --- | unaffected |
| firefox118 | --- | unaffected |
| firefox119 | --- | affected |
People
(Reporter: aglavic, Unassigned)
References
(Regression)
Details
(4 keywords)
Perfherder has detected a talos performance regression from push 390acd4d11235e1abbed2035186461aa2cd6c906. As author of one of the patches included in that push, we need your help to address this regression.
Regressions:
| Ratio | Test | Platform | Options | Absolute values (old vs new) |
|---|---|---|---|---|
| 145% | tp5o_webext XRes | linux1804-64-shippable-qr | e10s fission stylo webrender | 1,085,005.55 -> 2,653,847.19 |
| 145% | tp5o XRes | linux1804-64-shippable-qr | e10s fission stylo webrender | 1,085,282.77 -> 2,654,195.14 |
| 145% | tp5o XRes | linux1804-64-shippable-qr | e10s fission stylo webrender | 1,085,131.07 -> 2,653,723.77 |
| 7% | tp5o_scroll | linux1804-64-shippable-qr | e10s fission stylo webrender | 2.65 -> 2.84 |
Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) may be backed out in accordance with our regression policy.
If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.
For more information on performance sheriffing please see our FAQ.
|
||
Comment 1•2 years ago
|
||
Set release status flags based on info from the regressing bug 1852918
|
||
Comment 2•2 years ago
|
||
This is related to Bug 1852724. Can you provide more info that the talos test actually checks? Does it check x resources used? In that case it makes sense as we need to create main window twice.
|
Reporter | |
Comment 4•2 years ago
•
|
||
Hi :stransky,
This performance regression was caused by bug 1852918, which was created because in bug 1852724 the title bar was not being displayed.
I think bug 1852724's changes, which resulted in the title bar not being displayed it artificially improved the score and as a result of fixing the bug returned our score back to where it was before, which is why the improvements and regressions of 1852724 and 1852918 are inverses of each other
I am going to close this bug and re-classify the alerts, I am going to close this bug and I apologize for all the confusion this has caused
Generally when we have a fix for a test fail it results in a backout and is clearly identifiable in the commit message and treeherder logs but this was not the case in this bug, but now that we know this can happen I will incorporate it into our perf-sheriffing workflow to not have the same confusion arise again
Description
•