Closed Bug 1854059 Opened 2 years ago Closed 2 years ago

Convert Suggest remote settings component to a BaseFeature

Categories

(Firefox :: Address Bar, task, P1)

task

Tracking

()

RESOLVED FIXED
120 Branch
Tracking Status
firefox120 --- fixed

People

(Reporter: adw, Assigned: adw)

References

Details

Attachments

(1 file)

Convert the Suggest remote settings component to a BaseFeature so it can be managed by QuickSuggest and easily disabled and enabled.

This is part 1 of integrating the new Suggest Rust component in desktop.

Blocks: 1854060

This converts QuickSuggestRemoteSettings into a BaseFeature so that it can
be managed by QuickSuggest and easily enabled and disabled depending on
whether the new Rust component is enabled.

Summary of major changes:

  • Rename QuickSuggestRemoteSettings to SuggestBackendRemoteSettings and make
    it a BaseFeature. In a follow-up, I'll also add a new SuggestBackendRust
    feature.
  • Introduce a quickSuggestRustEnabled Nimbus variable. The remote settings
    backend will be disabled if this variable is true. Nothing else uses the
    variable right now but a follow-up will.
  • Move DEFAULT_SUGGESTION_SCORE to UrlbarProviderQuickSuggest and make the
    provider ensure all suggestions have scores.
Blocks: 1851255
No longer blocks: 1854060
Pushed by dwillcoxon@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/876e891072a0 Convert Suggest remote settings component to a BaseFeature. r=daisuke
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 120 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: