Closed Bug 1854064 Opened 8 months ago Closed 8 months ago

Can't activate "All Folders" folder mode, JS error in setFolderPropertiesFromFolder() if server hostname is empty. Breaks 3pane

Categories

(Thunderbird :: Folder and Message Lists, defect, P1)

Product:
Thunderbird
Component:
Folder and Message Lists
Version:
Thunderbird 115
Type:
defect

Tracking

(thunderbird_esr115+ fixed, thunderbird119 fixed)

Status:
RESOLVED FIXED
Milestone:
120 Branch
Tracking Flags:
Tracking Status
thunderbird_esr115 + fixed
thunderbird119 --- fixed

People

(Reporter: javier, Assigned: mkmelin)

References

Details

Attachments

(3 files)

Captura de la consola de errores al hacer click en la opcion
41.27 KB, image/jpeg
Details
2023-09-18 at 16-49-36.mp4
2.33 MB, video/mp4
Details
Bug 1854064 - Don't load accounts that don't have a server hostname. r=john.bieling
48 bytes, text/x-phabricator-request
wsmwk
: approval-comm-beta+
wsmwk
: approval-comm-esr115+
Details | Review

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/116.0.0.0 Safari/537.36

Steps to reproduce:

Opción Ver > carpetas > todas las carpetas

Actual results:

Cuando activo la opción esta se vuelve a desactivar sola

Expected results:

Debería de mostrarse toda la lista de correos que tengo instalada y estas no aparecen.

(In reply to Francesco from comment #2)

Seems to fail here:
https://searchfox.org/comm-central/rev/bd56e46fbb19f0cd8a565a6ce324767521ab9dd7/mail/base/content/about3Pane.js#3931

Yes, but I don't know what I have to do or change to fix it.

The Thunderbird devs will need to fix it. In general, you have a folder without server type, so something is wrong. Some corrupt folder somewhere.

BTW, can you change the summary to: Can't activate folder mode "All folders", JS error in setFolderPropertiesFromFolder().

Summary: No puedo activar el botón VER TODAS LAS CARPETA por la lista de correos → No se puede activar el modo de carpeta "Todas las carpetas", error JS en setFolderPropertiesFromFolder()

(In reply to Francesco from comment #4)

The Thunderbird devs will need to fix it. In general, you have a folder without server type, so something is wrong. Some corrupt folder somewhere.

BTW, can you change the summary to: Can't activate folder mode "All folders", JS error in setFolderPropertiesFromFolder().

The problem was that I had some accounts without a server name, since I only had them to consult historical emails, but as soon as I reconfigured the server name in those accounts I was able to see the all folders option.

The problem was that I had some accounts without a server name,

What server name did you use?
I'm fixing something similar in bug 1825374

See Also: → 1825374
Summary: No se puede activar el modo de carpeta "Todas las carpetas", error JS en setFolderPropertiesFromFolder() → Can't activate "All Folders" folder mode, JS error in setFolderPropertiesFromFolder()

(In reply to Magnus Melin [:mkmelin] from comment #6)

The problem was that I had some accounts without a server name,

What server name did you use?
I'm fixing something similar in bug 1825374

The name of the server corresponding to the email account.
For example: mail.server.com, mail.server.es, mail.myserver.com...

But that is a server name. What did you mean by "without a server name"? Please be very specific with any additional dots commas or other tokens you may have put in there to make the account not try to connect.

See comment #5:

The problem was that I had some accounts without a server name, since I only had them to consult historical emails, but as soon as I reconfigured the server name in those accounts I was able to see the all folders option.

Apparently some folders were moved into the profile without being connected to an account.

So somehow you got blank hostname set in the settings for that account?

If you want to use the account only to consult history, what you have to do is fill in the server name field with anything else. For example, you can put only the history (without name) in all the accounts you need.

You can also simply put the domain name

Well, only setting the hostname to something invalid through the UI won't reproduce a problem for me at least. How did you set the server hostname?

Nor through setting the pref directly.
Are the accounts IMAP or POP3?

(In reply to Magnus Melin [:mkmelin] from comment #13)

Well, only setting the hostname to something invalid through the UI won't reproduce a problem for me at least. How did you set the server hostname?

You have to go to the menu > tools > account settings and in the account you want, click on the server configuration option and in the server name section is where you configure it.

(In reply to Magnus Melin [:mkmelin] from comment #14)

Nor through setting the pref directly.
Are the accounts IMAP or POP3?

In my case they are POP3, but it doesn't matter what type of account you have installed, it works in any case

Though setting the hostname pref to empty in the prefs.js file does make the 3pane go blank. I'll see what we need to fix that.

Status: UNCONFIRMED → NEW
Ever confirmed: true

(In reply to Javier from comment #15)

You have to go to the menu > tools > account settings and in the account you want, click on the server configuration option and in the server name section is where you configure it.

That doesn't let me save an empty hostname (server name)

Assignee: nobody → mkmelin+mozilla
status-thunderbird_esr115: --- → affected
Summary: Can't activate "All Folders" folder mode, JS error in setFolderPropertiesFromFolder() → Can't activate "All Folders" folder mode, JS error in setFolderPropertiesFromFolder() if server hostname is empty

(In reply to Magnus Melin [:mkmelin] from comment #18)

(In reply to Javier from comment #15)

You have to go to the menu > tools > account settings and in the account you want, click on the server configuration option and in the server name section is where you configure it.

That doesn't let me save an empty hostname (server name)

No, but you can put anything, for example your domain name (mydomain.com)

You can, but that doesn't reproduce any problem for me.

(In reply to Magnus Melin [:mkmelin] from comment #20)

You can, but that doesn't reproduce any problem for me.

No problem at the moment, you can change it at any time

Setting a blank hostname in the prefs never used to show folders for the account. (Tried back to version 91 at least).
But we shouldn't let having a broken account break the UI.

The UI doesn't allow such accounts. If somehow we got into the state of having no hostname,
the account is doomed and can never do anything useful, so don't load it at all.
If we allow such accounts, they will blow up the UI since we then end up with folders
that don't know which server they are belong to.

Status: NEW → ASSIGNED
status-thunderbird119: --- → affected
Keywords: checkin-needed-tb
Target Milestone: --- → 120 Branch
Attachment #9354538 - Attachment description: Bug 1854064 - Don't load accounts that don't have a server hostname. r=#thunderbird-reviewers → Bug 1854064 - Don't load accounts that don't have a server hostname. r=john.bieling

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/88770ab51410
Don't load accounts that don't have a server hostname. r=john.bieling

Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Keywords: checkin-needed-tb
Resolution: --- → FIXED
Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/7c4c1920c791
Follow-up, fix debug build bustage. rs=bustage-fix

good for beta?

Severity: -- → S2
tracking-thunderbird_esr115: --- → +
Flags: needinfo?(mkmelin+mozilla)
Priority: -- → P1
Summary: Can't activate "All Folders" folder mode, JS error in setFolderPropertiesFromFolder() if server hostname is empty → Can't activate "All Folders" folder mode, JS error in setFolderPropertiesFromFolder() if server hostname is empty. Breaks 3pane

Comment on attachment 9354538 [details]
Bug 1854064 - Don't load accounts that don't have a server hostname. r=john.bieling

[Approval Request Comment]
Regression caused by (bug #): the bug is not new, but the UI code in supernova is more sensitive to brokenness
User impact if declined: potential for blank 3pane
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): theoretically pretty safe. But better have it bake a bit on beta.

Flags: needinfo?(mkmelin+mozilla)
Attachment #9354538 - Flags: approval-comm-esr115?
Attachment #9354538 - Flags: approval-comm-beta?

Comment on attachment 9354538 [details]
Bug 1854064 - Don't load accounts that don't have a server hostname. r=john.bieling

[Triage Comment]
Approved for beta

Attachment #9354538 - Flags: approval-comm-beta? → approval-comm-beta+

Comment on attachment 9354538 [details]
Bug 1854064 - Don't load accounts that don't have a server hostname. r=john.bieling

[Triage Comment]
Approved for esr115

Attachment #9354538 - Flags: approval-comm-esr115? → approval-comm-esr115+

Can I uplift Bug 1851450? Will make the merge easier...

Flags: needinfo?(geoff)

Sure, it's safe enough. Don't forget to take both patches.

Flags: needinfo?(geoff)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: