Closed Bug 1854138 Opened 10 months ago Closed 5 months ago

Tab closing warning window on uBlock origin add-on settings page close even if I chose "stay on page"

Categories

(Thunderbird :: Add-Ons: General, defect)

Thunderbird 115
defect

Tracking

(thunderbird_esr115 wontfix)

RESOLVED FIXED
124 Branch
Tracking Status
thunderbird_esr115 --- wontfix

People

(Reporter: mare1203, Assigned: TbSync)

Details

Attachments

(2 files)

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/118.0

Steps to reproduce:

Not sure if it's related to this plugin, but clicking stay on page in this window closes the tab anyway.

I think that would be a bug in uBlock origin

Component: Untriaged → Add-Ons: General
Summary: Tab closing warning window → Tab closing warning window on uBlock origin add-on settings page close even if I chose "stay on page"

Ugh. The event is broken for content tabs.

Status: UNCONFIRMED → NEW
Ever confirmed: true

The return value of browser.permitUnload() was used wrongly.

Assignee: nobody → john
Status: NEW → ASSIGNED
Attachment #9380165 - Attachment description: Bug 1854138 - Fix onbeforeunload event not preventing closing of content tabs. r=#thunderbird-reviewers → Bug 1854138 - Fix onbeforeunload event not preventing content tabs from being closed. r=#thunderbird-reviewers
Target Milestone: --- → 124 Branch

Pushed by vineet@thunderbird.net:
https://hg.mozilla.org/comm-central/rev/18c450afb1ab
Fix onbeforeunload event not preventing content tabs from being closed. r=mkmelin

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: