1854255 - Enforce the use of const in JS through eslintrc

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Alessandro Castellani [:aleca]]

Code consistency and rule following clean up.
Starting from simple updates to tests and specific folders to do it in chunks.

Comment 1

[Alessandro Castellani [:aleca]]

Attachment: Bug 1854255 - Enable `prefer-const` as linting rule for some tests head files. r=#thunderbird-reviewers

Comment 2

[Alessandro Castellani [:aleca]]

Leaving this open as I will do this update in chunks for each folder that has its own eslintrc

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/888d449e17a2
Enable prefer-const as linting rule for some tests head files. r=vineet

Comment 4

[Alessandro Castellani [:aleca]]

Attachment: Bug 1854255 - Enforce prefer-const eslint rule in calendar tests. r=#thunderbird-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6a6a411a7a2d
Enforce prefer-const eslint rule in calendar tests. r=leftmostcat,babolivier

Comment 6

[Alessandro Castellani [:aleca]]

Attachment: Bug 1854255 - Enforce prefer-const eslint rule in mailnews/base tests. r=#thunderbird-reviewers

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/79b4291b20c8
Enforce prefer-const eslint rule in mailnews/base tests. r=vineet

Comment 8

[Alessandro Castellani [:aleca]]

Attachment: Bug 1854255 - Enforce prefer-const eslint rule in the whole mailnews/base. r=#thunderbird-reviewers

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f6a766e0feec
Enforce prefer-const eslint rule in the whole mailnews/base. r=leftmostcat

Comment 10

[Alessandro Castellani [:aleca]]

Attachment: Bug 1854255 - Enforce prefer-const eslint rule in the chat/ and mailnews/export/ directories. r=freaktechnik

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/11c57d7369c1
Enforce prefer-const eslint rule in the chat/ and mailnews/export/ directories. r=freaktechnik

Comment 12

[Alessandro Castellani [:aleca]]

Attachment: Bug 1854255 - Enforce prefer-const eslint rule in the whole mailnews/ directory. r=freaktechnik

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ef6629fe1cb9
Enforce prefer-const eslint rule in the whole mailnews/ directory. r=freaktechnik

Comment 14

[Alessandro Castellani [:aleca]]

Attachment: Bug 1854255 - Enforce prefer-const eslint rule in the whole mail/ directory. r=#thunderbird-reviewers

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a5e8e4ec4da8
Enforce prefer-const eslint rule in the whole mail/ directory. r=john.bieling

Comment 16

[Alessandro Castellani [:aleca]]

I was a bit too quick in closing this. We need just another patch to enable this pref globally and fix a few leftovers.

Comment 17

[Alessandro Castellani [:aleca]]

Attachment: Bug 1854255 - Enforce prefer-const eslint rule globally. r=#thunderbird-reviewers

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e56e77518918
Enforce prefer-const eslint rule globally. r=john.bieling,ikey