1854258 - In landscape mode, extra arrows appear in the menu (after installing an add-on and enabling "Delete browsing data on exit")

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, defect)

Description

[eclaudiu64]

Attachment: mobizen_20230920_232004.mp4

User Agent: Mozilla/5.0 (Android 11; Mobile; rv:109.0) Gecko/118.0 Firefox/118.0

Steps to reproduce:

1. The first time we activate an add-on and we can also put the setting: Clear browsing data on exit
2. I put the screen in landscape mode and pressed the menu.
3. After I went up and down the menu and it can be seen that in the menu, arrows appear in the categories, without the need.

Actual results:

Menu arrows appear on each option.

Expected results:

Don't show those arrows in the whole menu, just for the activated addon.

Comment 1

[Chris Peterson [:cpeterson]]

eclaudiu64 says this bug is a regression in 118. It's not reproducible in 117.1.

Bug 1854131 is another menu bug in landscape mode.

Comment 2

[Chris Peterson [:cpeterson]]

QA, can you reproduce?

I wasn't able to reproduce in Beta 118. I don't see the menu arrows shown in the recording. I'm using en-US, if the locale makes a difference.

Comment 3

[Chris Peterson [:cpeterson]]

I can reproduce this bug now. eclaudiu64 emailed these steps to reproduce:

1. Install the uBlock Origin add-on.
2. Open the Settings menu and select Delete browsing data on exit.
3. Open a web page.
4. Rotate the device to landscape orientation.
5. Open the three-dot menu.
6. See that there is an arrow > on the Add-ons menu (because you can open a sub-menu with a list of your installed add-ons).
7. Scroll all the way to the bottom of the menu until you see the Quit menu item.
8. Then scroll back to the top.

I then see unnecessary arrows > on Quit and Sync and save data menu items.

Comment 4

[Lorand Janos]

Hi!
I can confirm the issue is present on the latest Beta 118.0b9 (and 119.0b8), on the latest RC (118.0) and on the latest Nightly as well (119.0a1 from 2023-09-21).

On 118 I've seen the "Quit" button with an arrow next to it, and on 119 I had the "Print" button with an arrow next to it.

On RC 117.1.0 the issue was not reproducible.

Tested devices:

• Google Pixel 7 (Android 14)
• Oppo Find X5 (Android 13)
• Samsung Galaxy S23 Ultra (Android 13) - on this I couldn't check the issue as I had a different problem I will investigate about, I couldn't scroll down towards the bottom of the menu.

Comment 5

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1854258 – in menu, only show overflowImage when it's needed (#3900)

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:skhan, could you have a look please?

For more information, please visit BugBot documentation.

Comment 7

[Donal Meehan [:dmeehan]]

:maivduevskiy the PR was reviewed, is there anything blocking landing this?
We are in the final beta week for Fx119, next week is RC week.
If this lands, is it safe to consider for uplift for Fx119 or should it ride the train with Fx120?

Comment 8

[BMO Github Automation]

Authored by mike a
https://github.com/mozilla-mobile/firefox-android/commit/376b17ad217b7c31c83fcd652aae515fbb6e2b29
[main] Bug 1854258 – in menu, only show overflowImage when it's needed

Comment 9

[Adina Petridean QA [:apetridean]]

Verified as fixed on the latest Nightly ( 120.0a1 from 11.10.2023) with Google Pixel 7 PRO ( Android 14) and Sony Xperia ( Android 6).

Comment 10

[Adina Petridean QA [:apetridean]]

Attachment: arrow.mp4

Comment 11

[Mike a [:mavduevskiy]]

:dmeehan
Didn't want to land it before the long weekend in Canada :) It's a pritty minor thing, I don't think many users will benefit if we push it earlier. I would let it ride 120

Comment 12

[Donal Meehan [:dmeehan]]

(In reply to Mike a [:mavduevskiy] from comment #11)

:dmeehan
Didn't want to land it before the long weekend in Canada :) It's a pritty minor thing, I don't think many users will benefit if we push it earlier. I would let it ride 120

Thanks for the info