1854131 - Three-dot main menu falls off screen, disappears in landscape mode

Status: RESOLVED FIXED

(Fenix :: Toolbar, defect, P3)

Description

[killercontact1.7.4.0]

Attachment: bz-fenix-menu-landscape.webm

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Firefox/119.0

Steps to reproduce:

Force landscape mode, Samsung OneUI 5.1 Android 13

Actual results:

Orientation is wrong, it disappears off-screen. Tapping the fragment still visible takes it back.

Comment 1

[Chris Peterson [:cpeterson]]

Thanks for the bug report!

Which Firefox version are you using? Is this bug a recent regression or something you've seen before?

Comment 2

[Andrei Mocirean]

Hello,

I was able to reproduce the issue on the latest Nightly build (119.0a1), as well as on the latest Beta and RC builds, as well as on the RC 117 and RC 116. When the toolbar position is set to top, no issues are encountered and the UI looks just fine. The issue only occurs when using the "bottom" option for the toolbar position.

Devices used for testing:

• Samsung Galaxy S22 Ultra (Android 13)
• Samsung Galaxy S22 (Android 13)

Comment 3

[killercontact1.7.4.0]

(In reply to Chris Peterson [:cpeterson] from comment #1)

Thanks for the bug report!

Which Firefox version are you using? Is this bug a recent regression or something you've seen before?

Reproducible for several months on nightly, plus I see the second confirmation.

Comment 4

[Djfe]

The same thing happens in split-screen mode when Firefox is the app at the bottom.
If it's the top app, the issue doesn't happen.
verified on 120.0a1 (2.10.23)
118.1.0 (release) is not affected as far as I can tell, so it's a regression.
Though I found one edge case that release doesn't handle well when I'm split-screen mode, I can use the menu just fine. (edge case where I have to scroll twice to fully open the menu, whatever this is definitely before the regression)
I can also reproduce it on 119.0b4

Comment 5

[Djfe]

I managed to reproduce it now with the nightly app at the top of the screen (in split-screen mode)
I'm always using the navigation bar at the bottom. it doesn't happen with navigation bar at the top of the screen

Comment 6

[Djfe]

Attachment: Screenshot 1

Comment 7

[Djfe]

Attachment: Screenshot 2

this is the maximum I can scroll from the state in Screenshot 1

Comment 8

[Djfe]

Attachment: Screenshot 3

I made Firefox smaller, now it won't open a menu at all. the button flashes on click (circle) and that's it.
in all of my Screenshots only the bottom Firefox matters for this bug. the top app could be any other app

Comment 9

[jackyzy823]

Attachment: Screenshot_20231005-200207.png

Comment 10

[jackyzy823]

Attachment: Screenshot_20231005-200218.png

Even worse:

When rotate back to portrait mode, the menu appears like this.

Comment 11

[Djfe]

Bug 1837932 is not related, I think

Comment 12

[Djfe]

I just did some regression testing using Mozregression on my Pixel 7 Pro on Android 14:
2023-10-09T05:39:28.454000: INFO : Narrowed nightly regression window from [2023-05-02, 2023-05-04] (2 days) to [2023-05-03, 2023-05-04] (1 days) (~0 steps left)
2023-10-09T05:39:28.504000: INFO : The bisection is done.
2023-10-09T05:39:28.507000: INFO : Stopped

The rough comission window starts here:
https://github.com/mozilla-mobile/firefox-android/commits/main?before=430a9fd10df0c99789d22f7129c985da463b454a+1466&branch=main&qualified_name=refs%2Fheads%2Fmain

I have to assume the commit since mozregression supports only "opt" so far (no autoland/debug etc. to find an exact commit)

Looks likely to me:
https://github.com/mozilla-mobile/firefox-android/commit/47035e0d1956fa732f12f39e2e95f414627a6803
Bug 1812825

Hey Sergey, sorry to interrupt. Your commit from May might have broken the menu bar. We can't scroll to all entries when in landscape mode or while using Android's splitscreen feature.

You probably have better means to verify that it is or is not your commit. I've never build Firefox for Android before.

Comment 13

[Djfe]

Ups, I pasted the wrong commit URL, I meant to post this one:
https://github.com/mozilla-mobile/firefox-android/commit/917f0f14aa3c026c5e9aa3b5765b9aad9aa512b8

Comment 14

[killercontact1.7.4.0]

With Nightly 1220.a1 2015989218 it is now working better. The menu functions properly while in landscape mode, also in 270°. It closes when transforming from any landscape position into portrait or reverse.

Proposing to close this bug for being duplicate, in favour of https://bugzilla.mozilla.org/show_bug.cgi?id=1846349

Comment 16

[nrichards]

Forgive me if expanding the scope of this bug is inappropriate.

I can't see the Back Forward Share Reload buttons from the three dot menu when using the Pixel Fold, when unfolded using the widescreen interior screen. The buttons are simply missing. And otherwise the pop-up menu looks fine, and is placed in the corner correctly.

The button reappear from the app, on the outer portrait screen, when I fold the phone.

I have screenshots, though I don't know how to attach yet.

Comment 17

[nrichards]

Attachment: PixelFold-Missing-ButtonBar.jpeg

Comment 18

[nrichards]

Attachment: PixelFold-Correct-ButtonBar.jpeg

Comment 19

[nrichards]

Comment on attachment 9369072 [details]
PixelFold-Missing-ButtonBar.jpeg

NOTICE: This is a wide-screen layout, a landscape layout, not the typical portrait layout. 2208 × 1840.

Comment 24

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the following bug duplicate has higher severity:

• Bug 1833465: S2

:skhan, could you consider increasing the severity of this bug to S2?

For more information, please visit BugBot documentation.

Comment 25

[Alex Franchuk [:afranchuk]]

FWIW I think the severity should be S2: this makes the browser chrome unusable in landscape, which is pretty bad (though of course there is a workaround if you can go into portrait mode).

Comment 26

[BMO Github Automation]

Attachment: [mozilla-mobile/firefox-android] Bug 1854131 - Three-dot main menu falls off screen, disappears in landscape mode (#5663)

Comment 27

[careca]

I got this issue on 124.0b5 exact same as original post.

Comment 28

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 1854131 - Compare availableHeightToTop and availableHeightToBottom when positioning menu.

When the popup doesn't fit up or down, because both availableHeightToTop and availableHeightToBottom are both smaller than containerHeight choose the highest one to choose menu direction.

Comment 29

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/671417c0f761
Compare availableHeightToTop and availableHeightToBottom when positioning menu. r=android-reviewers,twhite

Comment 30

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/671417c0f761

Comment 31

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:adriana.maries, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox125 to wontfix.

For more information, please visit BugBot documentation.

Comment 32

[Vasilica Tamas QA [:vtamas]]

Attachment: ImportedPhoto_1711558294095.jpg

This issue was verified as fixed on Firefox 126 (2024-03-27) using a Google Pixel 7 (Android), Google Pixel 8 (Android 14) and Xiaomi 12T (Android 12). The main menu is correctly displayed and can be successfully scrolled.

Comment 34

[Mihai Adrian Carare [:mcarare]]

Reopened to be tested after https://phabricator.services.mozilla.com/D208615 lands.

Comment 35

[careca]

Seems to be fixed with 125.0b9.

Comment 36

[Delia Pop (Android QA)]

Attachment: media_20240515_182325_7465870000619623318.mp4

Verified as fixed on the latest Nightly 128.0a1 from 05/15 with Samsung Galaxy S22 Ultra (Android 14) and Samsung Galaxy A53 5G (Android 14) .
The main menu is correctly displayed and works as expected while in landscape mode.
I cannot reproduce the issue on latest Beta 127.0b1 and Release 126.0, either.
I'll close this issue as resolved and mark the latest versions accordingly.