1854420 - Split buttons in the chrome panels have a gap between the buttons

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Tim Giles [:tgiles]]

Attachment: image.png

Split buttons that use popupnotification.js have a gap between them when they shouldn't.

Comment 1

[Tim Giles [:tgiles]]

Since this is popupnotification.js code, moving to XUL Widgets

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1849192

:annhermy, since you are the author of the regressor, bug 1849192, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[Donal Meehan [:dmeehan]]

Setting Fx119 to fixed, the regressor was backed out
https://bugzilla.mozilla.org/show_bug.cgi?id=1849192#c4

Comment 4

[Ganna]

Attachment: Bug 1854420 - Split buttons in the chrome panels have a gap between the buttons.js r=tgiles

Depends on D183231

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f113adfb6ab5
Split buttons in the chrome panels have a gap between the buttons.js r=tgiles,desktop-theme-reviewers,reusable-components-reviewers,dao

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Ganna / Hanna: I sent a follow-up to fix a test to avoid backing out the whole stack. My understanding per the comments is that it's sort of expected to not rely on the button at the beginning to have inline-end margin. But maybe the test needs adjustments, or we need a rule removing that inline-end margin for the first button?

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c24c2ee2e29b
Fix test_moz_button_group.html to avoid backout of the whole stack and dependent bugs. r=emilio CLOSED TREE

Comment 8

[Hanna Jones [:hjones]]

Attachment: Bug 1854420 - re-add moz-button-group CSS rule to remove margins from slotted buttons r=emilio

Comment 9

[Hanna Jones [:hjones]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #6)

Ganna / Hanna: I sent a follow-up to fix a test to avoid backing out the whole stack. My understanding per the comments is that it's sort of expected to not rely on the button at the beginning to have inline-end margin. But maybe the test needs adjustments, or we need a rule removing that inline-end margin for the first button?

Thanks for the quick test fix and my bad for not catching that before landing! I pushed another change that should allow us to leave the test as is - I believe that 8px spacing is what we want, we just accidentally removed a rule that was removing all other margins from slotted buttons.

Comment 10

[Ganna]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #6)

Ganna / Hanna: I sent a follow-up to fix a test to avoid backing out the whole stack. My understanding per the comments is that it's sort of expected to not rely on the button at the beginning to have inline-end margin. But maybe the test needs adjustments, or we need a rule removing that inline-end margin for the first button?

Thanks for catching that! So sorry that I missed that. Thanks Hanna for a fix

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f113adfb6ab5
https://hg.mozilla.org/mozilla-central/rev/c24c2ee2e29b

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ce7d7cd4e72f
re-add moz-button-group CSS rule to remove margins from slotted buttons r=emilio,desktop-theme-reviewers,reusable-components-reviewers,tgiles

Comment 13

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ce7d7cd4e72f