1854427 - The header of the review checker sidebar does not remain in-view when scrolled

Status: RESOLVED WORKSFORME

(Firefox Graveyard :: Shopping, defect)

Description

[Peter Magyari (Desktop QA)]

Attachment: Screenshot 2023-09-21 at 19.22.30.png

Found in

• Firefox 119.0a1 (2023-09-21)

Tested platforms

• Affected platforms: All

Preconditions

• browser.shopping.experience2023.enabled- "true"
• browser.shopping.experience2023.optedIn - "1"

Steps to reproduce

1. Open Firefox Nightly.
2. Navigate to an Amazon/Walmart/Bestbuy product page. (example)
3. Click on the Show more button in the "Highlights from recent reviews" section of the review checker sidebar.
4. Scroll down inside the review checker sidebar.

Expected result

• According to the figma spec the header of the sidebar should remain in view regardless of the scroll position.

Actual result

• The header moves out of view as you scroll down.

Regression range

• Will return with a regression-range asap.

Comment 1

[Peter Magyari (Desktop QA)]

Mozregression returned the following pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c08cba545d2cfff90f54726bd536368b128cfb0b&tochange=a654205d84701ba611f22f0020be612e0db887c6

It seems like Bug 1852302 could be the culprit.

Niklas, could you take a look?
Thanks!

Comment 2

[:Gijs (back August 25; he/him)]

I think the patch in https://phabricator.services.mozilla.com/D188528 is fixing this?

Comment 3

[kpatenio]

I'm surprised that a regressor came up (I don't recall the header ever being in view when scrolling). Nonetheless, yes the patch Gijs linked is for Bug 1851839, which will keep the header stickied to the top.

Comment 4

[BugBot [:suhaib / :marco]]

:niklas, since you are the author of the regressor, bug 1852302, could you take a look?

For more information, please visit BugBot documentation.

Comment 5

[Peter Magyari (Desktop QA)]

I can confirm that this has indeed been fixed by the patch landed for Bug 1851839 so I'm closing this issue.