Temporarily disable some Tier 2 a11y_checks for Tabbed Browser
Categories
(Firefox :: Tabbed Browser, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox120 | --- | fixed |
People
(Reporter: ayeddi, Assigned: ayeddi)
References
Details
(Keywords: access)
Attachments
(1 file)
We are working on enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, we are going to skip the failing tests altogether and then handle each one of them individually.
This task is to skip with fail-if
condition of the failing tests while we continue investigation into the reasons these tests failed and to be able to backtrack these tests once they're resolved. A separate task to investigate the failed Tier 2 a11y_checks will be filed for an appropriate component.
Tests affected:
FAIL browser/modules/test/browser/browser_PartnerLinkAttribution.js Node is not focusable via the accessibility API searchbar-engine-one-off-item-engine-0 button searchbar-engine-one-off-item
FAIL browser/modules/test/browser/browser_UsageTelemetry_interaction.js Node is enabled but disabled via the accessibility API reload-button toolbarbutton toolbarbutton-1
FAIL browser/modules/test/browser/browser_UsageTelemetry_interaction.js Node is enabled but disabled via the accessibility API back-button toolbarbutton toolbarbutton-1 chromeclass-toolbar-additional
FAIL browser/modules/test/browser/browser_UsageTelemetry_interaction.js Interactive elements must be labeled 12foo toolbarbutton toolbarbutton-1 chromeclass-toolbar-additional
Jobs affected:
test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-a11y-checks-
${1-7} (Try run)
Some Tier 2 accessibility checks for click events fired on controls that should be keyboard accessible and have valid labels were failing for this component. They were captured by testing/mochitest/tests/SimpleTest/AccessibilityUtils.js
via bug 1692110. These failing tests should be temporarily skipped in the directory's browser.ini
file while we investigate these failures. For all confirmed bugs individual defects should be filed.
When the individual test failures are resolved and the individual bugs are closed, remove the fail-if
condition for a11y_checks
from the appropriate files/sections to ensure better test coverage and to avoid regressions in a11y of these components.
Assignee | ||
Comment 1•9 months ago
|
||
We are working on enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, we are going to skip the failing tests altogether and then handle each one of them individually.
This task is to skip with fail-if
condition of the failing tests while we continue investigation into the reasons these tests failed and to be able to backtrack these tests once they're resolved.
Related bugs:
- Disabling tests: meta bug 1848402
- Investigation and remediation for components with disabled tests: meta bugs 1848394 and 1854227, Tabbed Browser-specific meta bug 1854507
- Explore capturing click events for a11y_checks: bug 1692110
Depends on D188914
Updated•8 months ago
|
Updated•8 months ago
|
Pushed by ayeddi@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9d8b2e14c375 Temporarily disable some Tier 2 a11y_checks for Tabbed Browser. r=tabbrowser-reviewers,dao
Comment 3•8 months ago
|
||
bugherder |
Comment 4•8 months ago
|
||
Backed out for causing multiple tier 2 failures on a11y-checks.
https://bugzilla.mozilla.org/show_bug.cgi?id=1857672
https://bugzilla.mozilla.org/show_bug.cgi?id=1857666
https://bugzilla.mozilla.org/show_bug.cgi?id=1857664
https://bugzilla.mozilla.org/show_bug.cgi?id=1857665
https://bugzilla.mozilla.org/show_bug.cgi?id=1857707
Updated•8 months ago
|
Pushed by ayeddi@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ee2c96c10f8c Temporarily fail-if some Tier 2 a11y_checks for Tabbed Browser. r=tabbrowser-reviewers,dao
Comment 6•8 months ago
|
||
bugherder |
Assignee | ||
Updated•8 months ago
|
Description
•