1854507 - [meta] Investigate elements that are failing Tier 2 a11y_checks for Tabbed Browser

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, task, P3)

Description

[Anna Yeddi [:ayeddi] ⚠️ Online half days through May 23]

We are working on enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, the failing tests were failed-if by the bug 1854506.

This task is to track the investigation into the reasons each of these tests failed and to be able to backtrack these tests once they're resolved.

Individual bugs to block the following bugs

1. (all) this meta bug
2. (Interactive elements must be labeled / Node is enabled but disabled via the accessibility API) bug 1854227 (a11y_checks_labeled)
3. (Node is not accessible via accessibility API / Node is not focusable via the accessibility API / Node is enabled but disabled via the accessibility API) Bug 1848394 (a11y_checks_focusable)

Tests affected:

FAIL	browser/modules/test/browser/browser_PartnerLinkAttribution.js	Node is not focusable via the accessibility API	searchbar-engine-one-off-item-engine-0	button	searchbar-engine-one-off-item
FAIL	browser/modules/test/browser/browser_UsageTelemetry_interaction.js	Node is enabled but disabled via the accessibility API	reload-button	toolbarbutton	toolbarbutton-1
FAIL	browser/modules/test/browser/browser_UsageTelemetry_interaction.js	Node is enabled but disabled via the accessibility API	back-button	toolbarbutton	toolbarbutton-1 chromeclass-toolbar-additional
FAIL	browser/modules/test/browser/browser_UsageTelemetry_interaction.js	Interactive elements must be labeled	12foo	toolbarbutton	toolbarbutton-1 chromeclass-toolbar-additional

Jobs affected:

1. test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-a11y-checks-${1-7} (Try run)

---

Some Tier 2 accessibility checks for click events fired on controls that should be keyboard accessible and have valid labels were failing for this component. They were captured by testing/mochitest/tests/SimpleTest/AccessibilityUtils.js via bug 1692110. These failing tests should be temporarily skipped in the directory's browser.ini file while we investigate these failures. For all confirmed bugs individual defects should be filed.

When the individual test failures are resolved and the individual bugs are closed, remove the fail-if condition for a11y_checks from the appropriate files/sections to ensure better test coverage and to avoid regressions in a11y of these components.

Comment 1

[Anna Yeddi [:ayeddi] ⚠️ Online half days through May 23]

Bug 1868749 removed the browser/modules/test/browser/browser_PartnerLinkAttribution.js test file

Comment 2

[Anna Yeddi [:ayeddi] ⚠️ Online half days through May 23]

Since all the failed a11y_checks tests were resolved for Tabbed browser, I am closing this meta bug as fixed.