Temporarily disable some Tier 2 a11y_checks for Core: Credentials
Categories
(Core :: DOM: Credential Management, task, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox120 | --- | fixed |
People
(Reporter: ayeddi, Assigned: ayeddi)
References
Details
(Keywords: access)
Attachments
(1 file)
Bug 1854509 - Temporarily fail-if some Tier 2 a11y_checks for Core Credentials. r=bvandersloot,Jamie
48 bytes,
text/x-phabricator-request
|
Details | Review |
We are working on enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, we are going to skip the failing tests altogether and then handle each one of them individually.
This task is to skip with fail-if
condition of the failing tests while we continue investigation into the reasons these tests failed and to be able to backtrack these tests once they're resolved. A separate task to investigate the failed Tier 2 a11y_checks will be filed for an appropriate component.
Tests affected:
FAIL toolkit/components/credentialmanagement/tests/browser/browser_account_dialog.js Node is not accessible via accessibility API html:label identity-credential-list-item
FAIL toolkit/components/credentialmanagement/tests/browser/browser_provider_dialog.js Node is not accessible via accessibility API html:label identity-credential-list-item
Jobs affected:
test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-a11y-checks-
${1-7} (Try run)
Some Tier 2 accessibility checks for click events fired on controls that should be keyboard accessible and have valid labels were failing for this component. They were captured by testing/mochitest/tests/SimpleTest/AccessibilityUtils.js
via bug 1692110. These failing tests should be temporarily skipped in the directory's browser.ini
file while we investigate these failures. For all confirmed bugs individual defects should be filed.
When the individual test failures are resolved and the individual bugs are closed, remove the fail-if
condition for a11y_checks
from the appropriate files/sections to ensure better test coverage and to avoid regressions in a11y of these components.
Assignee | ||
Comment 1•8 months ago
|
||
We are working on enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, we are going to skip the failing tests altogether and then handle each one of them individually.
This task is to skip with fail-if
condition of the failing tests while we continue investigation into the reasons these tests failed and to be able to backtrack these tests once they're resolved.
Related bugs:
- Disabling tests: meta bug 1848402
- Investigation and remediation for components with disabled tests: meta bugs 1848394 and 1854227, Core: Credentials-specific bug 1854510
- Explore capturing click events for a11y_checks: bug 1692110
Depends on D188915
Updated•8 months ago
|
Updated•8 months ago
|
Pushed by ayeddi@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/828657f2ab73 Temporarily disable some Tier 2 a11y_checks for Core Credentials. r=bvandersloot
Comment 3•8 months ago
|
||
bugherder |
Comment 4•8 months ago
|
||
Backed out for causing multiple tier 2 failures on
Backout link
Push with failures
https://bugzilla.mozilla.org/show_bug.cgi?id=1857672
https://bugzilla.mozilla.org/show_bug.cgi?id=1857666
https://bugzilla.mozilla.org/show_bug.cgi?id=1857664
https://bugzilla.mozilla.org/show_bug.cgi?id=1857665
https://bugzilla.mozilla.org/show_bug.cgi?id=1857707
Updated•8 months ago
|
Pushed by ayeddi@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c0c53251899c Temporarily fail-if some Tier 2 a11y_checks for Core Credentials. r=bvandersloot
Comment 6•8 months ago
|
||
bugherder |
Assignee | ||
Updated•8 months ago
|
Description
•