1854510 - Investigate identity-credential-list-items that are failing Tier 2 a11y_checks for Core: Credentials

Status: RESOLVED FIXED

(Core :: DOM: Credential Management, task, P3)

Description

[Anna Yeddi [:ayeddi]]

We are working on enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, the failing tests were failed-if by the bug 1854509.

This task is to track the investigation into the reasons each of these tests failed and to be able to backtrack these tests once they're resolved.

Individual bugs to block the following bugs:

1. (all) this bug
2. (Node is not accessible via accessibility API / Node is not focusable via the accessibility API / Node is enabled but disabled via the accessibility API) Bug 1848394 (a11y_checks_focusable)

Tests affected:

FAIL	toolkit/components/credentialmanagement/tests/browser/browser_account_dialog.js	Node is not accessible via accessibility API		html:label	identity-credential-list-item
FAIL	toolkit/components/credentialmanagement/tests/browser/browser_provider_dialog.js	Node is not accessible via accessibility API		html:label	identity-credential-list-item

Jobs affected:

1. test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-a11y-checks-${1-7} (Try run)

---

Some Tier 2 accessibility checks for click events fired on controls that should be keyboard accessible and have valid labels were failing for this component. They were captured by testing/mochitest/tests/SimpleTest/AccessibilityUtils.js via bug 1692110. These failing tests should be temporarily skipped in the directory's browser.ini file while we investigate these failures. For all confirmed bugs individual defects should be filed.

When the individual test failures are resolved and the individual bugs are closed, remove the fail-if condition for a11y_checks from the appropriate files/sections to ensure better test coverage and to avoid regressions in a11y of these components.

Comment 1

[Anna Yeddi [:ayeddi]]

FYI identity-credential-list-item are only enabled in Nightly

Comment 2

[Anna Yeddi [:ayeddi]]

Attachment: Bug 1854510 - Remove the fail-if notation for passing a11y-checks in Core Credentials. r=bvandersloot!

Since the AccessibilityUtils will be able to account for a click on a label elements for radio buttons and checkboxes in the bug 1882380, we can remove the fail-if notation from two tests that were previously failing a11y-checks.

Depends on D205112

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e4b436fef25
Remove the fail-if notation for passing a11y-checks in Core Credentials. r=timhuang

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/5e4b436fef25