1854515 - [meta] Investigate 2 tests that are failing Tier 2 a11y_checks for New Tab Page

Status: NEW

(Firefox :: New Tab Page, task, P3)

Description

[Anna Yeddi [:ayeddi]]

We are working on enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110) and before that, we need to prepare the existing code base. While we triage and investigate the existent test that would fail once the a11y-checks are enabled in the CI, the failing test was failed-if by the bug 1854514.

This task is to track the investigation into the reasons this test failed and to be able to backtrack this test once it's resolved.

If separate bugs are needed, they are to block the following bugs:

1. (all) this bug
2. (Node is not accessible via accessibility API / Node is not focusable via the accessibility API / Node is enabled but disabled via the accessibility API) Bug 1848394 (a11y_checks_focusable)

Test affected:

Result	Path	Error	El ID	El tagName	El className
FAIL	browser/components/newtab/test/browser/browser_aboutwelcome_import.js	Node is not focusable via the accessibility API		BUTTON	primary
FAIL	browser/components/newtab/test/browser/browser_asrouter_toolbarbadge.js	Node is not accessible via accessibility API	fxa-toolbar-menu-button	toolbarbutton	toolbarbutton-1 chromeclass-toolbar-additional subviewbutton-nav

Jobs affected:

1. test-linux1804-64-qr/opt-mochitest-browser-chrome-swr-a11y-checks-${1-7} (Try run)

---

Some Tier 2 accessibility checks for click events fired on controls that should be keyboard accessible and have valid labels were failing for this component. They were captured by testing/mochitest/tests/SimpleTest/AccessibilityUtils.js via bug 1692110. These failing tests should be temporarily skipped in the directory's browser.ini file while we investigate these failures. For all confirmed bugs individual defects should be filed.

When the test failure is resolved and its associated bug is closed, remove the fail-if condition for a11y_checks from the appropriate file/section to ensure better test coverage and to avoid regressions in a11y of this component.

Comment 1

[Anna Yeddi [:ayeddi]]

Crash reported in bug 1857056

CRASH	browser/components/newtab/test/browser/browser_asrouter_cfr.js 
	application crashed [@ nsGlobalWindowInner::TryToObserveRefresh()::$_0::operator()]

Process type: main
Process pid: None
Crash dump filename: /tmp/tmpfw1u_xla.mozrunner/minidumps/7df4b0e0-4036-c573-4286-8262589bab43.dmp