1854747 - copying and pasting multiple images from the web in a row breaks previous ones

Status: VERIFIED FIXED

(Core :: DOM: Copy & Paste and Drag & Drop, defect)

Description

[Colin B.]

hi there! I'm one of the developers on cohost.org, and we received a bug report about pasted images for which we believe the root cause to be a clipboard behavior regression in a recent version of firefox.

I wrote a minimized repro on jsfiddle: https://jsfiddle.net/d9cegwbm/1/.

steps to reproduce:

1. open the repro.
2. open https://upload.wikimedia.org/wikipedia/commons/thumb/c/c1/Arizona_Diamondbacks_cap_logo.svg/1200px-Arizona_Diamondbacks_cap_logo.svg.png.
3. right click, copy the image; tab back to the repro, select the bottom-right pane and paste.
4. open https://upload.wikimedia.org/wikipedia/commons/0/0f/Boise_State_Athletic_%22B%22.png
5. right click, copy the image; tab back to the repro, select the bottom-right pane and paste.

expected behavior: both "A" and "B" should show up in the document.

observed behavior:

• chrome 117: works.
• firefox 102: works.
• firefox 117.0.1: doesn't work; after pasting "B", "A" becomes a broken image.

note that this issue only happens with copy-pasted image data from the web; if you copy-paste files from disk, everything works normally in firefox 117.

hope this is enough information to diagnose the issue! please feel free to contact me if there's any other help I can provide.

Comment 1

[Colin B.]

oh! I should also note: this appears to be particular to the copying web browser's clipboard handling, rather than the pasting browser. during the process of attempting to root cause the bug, I found that copying from images in firefox 117 tabs and pasting into chrome was also broken; conversely, copying from chrome into firefox 117 works fine.

Comment 2

[Colin B.]

one more note that I forgot to add: all of my testing was done on Windows 10 -- and our original reporter also uses Windows 10 -- in case this is a platform-specific bug.

Comment 3

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Core::DOM: Copy & Paste and Drag & Drop' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 4

[Colin B.]

a few more data points: the bug appears not to be present in Firefox 117.0.1 on Linux, or Firefox ESR 115.2.1 on Windows or Mac. I believe this is a Windows-specific bug, so I'm changing the platform on it.

Comment 5

[Edgar Chen [:edgar]]

(In reply to Colin B. from comment #1)

I found that copying from images in firefox 117 tabs and pasting into chrome was also broken.

Yes, I see also this way back to Firefox 70, so it's indeed something related to the data we put into system clipboard.
When copying image via contentmenu, we also put file type into system clipboard, where Chrome doesn't.

This issue didn't occur before is because we didn't get file type from clipboard, and after bug 1699743 we do, so now we run into the issue as Chrome. Not sure why we need to put file type into system clipboard while copying image through.

Comment 6

[BugBot [:suhaib / :marco]]

:evilpie, since you are the author of the regressor, bug 1699743, could you take a look?

For more information, please visit BugBot documentation.

Comment 7

[Edgar Chen [:edgar]]

(In reply to Edgar Chen [:edgar] from comment #5)

Not sure why we need to put file type into system clipboard while copying image through.

This is from https://searchfox.org/mozilla-central/rev/699a7704521354cac1e6a0679029c89ca899e25c/dom/base/nsCopySupport.cpp#504-507 which is to fix bug 664717.

Comment 8

[Edgar Chen [:edgar]]

Attachment: Bug 1854747 - Stop exposing the image data as file to clipboard; r?nika,evilpie

Comment 9

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 1699743

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/671cc9eb7842
Stop exposing the image data as file to clipboard; r=evilpie

Comment 11

[Narcis Beleuzu [:NarcisB]]

Backed out bc failure browser_save_filenames.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/bbccd8fb6efc43d30d61e6f28d8f1fe545b59d58
Log link: https://treeherder.mozilla.org/logviewer?job_id=430803343&repo=autoland&lineNumber=65907

Comment 12

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/jobs?repo=try&revision=a1cc162ab3b18f527b44d9f8d5804327a36ac0dc

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e91f547f0c7
Stop exposing the image data as file to clipboard; r=evilpie

Comment 14

[Cristina Horotan [:chorotan]]

Backed out changeset 1e91f547f0c7 (bug 1854747) for causing bc failures at browser_save_filenames.js

Backout: https://hg.mozilla.org/integration/autoland/rev/6d9a378efcee8715e59a32d21a70a64adfca6313

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=1e91f547f0c7431a171c52deaa4c34bec9a4d5a6

Failure log: https://treeherder.mozilla.org/logviewer?job_id=431491355&repo=autoland&lineNumber=12736

Comment 15

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&revision=54d19ee6e0fa6fbc9ad9464f94d53208526c179b

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35622e43aeba
Stop exposing the image data as file to clipboard; r=evilpie

Comment 17

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/35622e43aeba

Comment 18

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:edgar, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox119 to wontfix.

For more information, please visit BugBot documentation.

Comment 19

[Edgar Chen [:edgar]]

I don't plan to uplift this to beta as I would like to run full Nightly cycle to see if there is any feedback first.

Comment 20

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Attachment: image.png

Reproducible on a 2023-09-22 Nightly build on Windows 10.
Verified as fixed on Firefox Nightly 121.0a1 on Windows 10.
However, this issue is still reproducible on Firefox 120.0. Should I file a new bug for this behavior? Thank you.

Comment 21

[Edgar Chen [:edgar]]

The fix is only applied in Nightly and beta for now, bug 1857764 is filed to apply it to all channel.

Comment 22

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Thank you for the clarification! Just noted that the fix is implemented in early beta only, and I can confirm that the issue does not reproduce on Firefox 120.0b4. Sorry for the confusion. Marking as VERIFIED FIXED based on comments 20 and 21.