1855068 - Extend sanitizer functionality to fetch data sizes for clear data dialog

Status: RESOLVED FIXED

(Toolkit :: Data Sanitization, enhancement, P3)

Description

[Harshit Sohaney [:hsohaney]]

Attachment: mockup of data size

We should be able to show how much data is being cleared based on the time range selected within the clear recent history dialog.

Comment 1

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 1855068 - (Part 1) Added functionality to get all data sizes by time range. r?pbz

Comment 2

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 1855068 - (Part 2) Tests for data size display in new dialog. r?pbz

Depends on D190862

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The following patch is waiting for review from an inactive reviewer:

ID	Title	Author	Reviewer Status
D193845	Bug 1855068 - (Part 2) Tests for data size display in new dialog. r?pbz	hsohaney	pbz: Back Jan 2, 2024

:hsohaney, could you please find another reviewer?

For more information, please visit BugBot documentation.

Comment 4

[Harshit Sohaney [:hsohaney]]

The patch will be reviewed once Paul (@pbz) is back!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be41f5296dec
(Part 1) Added functionality to get all data sizes by time range. r=pbz,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/645f7ed438fb
(Part 2) Tests for data size display in new dialog. r=pbz

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/be41f5296dec
https://hg.mozilla.org/mozilla-central/rev/645f7ed438fb

Comment 7

[Noemi Erli[:noemi_erli]]

Backed out 4 changesets (Bug 1855068, Bug 1856412) for causing failures in test_SiteDataManager.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=linux%2C18.04%2Cx64%2Cwebrender%2Casan%2Copt%2Cxpcshell%2Ctests%2Cwithout%2Cfission%2Cenabled%2Ctest-linux1804-64-asan-qr%2Fopt-xpcshell-nofis%2Cx4&revision=645f7ed438fb8172e3e4db34d3d7821251ae066c&selectedTaskRun=CP97nv_oR9a7YAKPVl1RzA.0

Log: https://treeherder.mozilla.org/logviewer?job_id=442896701&repo=autoland&lineNumber=5001

Backout: https://hg.mozilla.org/integration/autoland/rev/1a93f0a64a7f897212da58c5753433922e0953cb

Comment 8

[Harshit Sohaney [:hsohaney]]

Sorry about this! I'm working on a fix to make the test pass near midnight.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d503faf45ca6
(Part 1) Added functionality to get all data sizes by time range. r=pbz,fluent-reviewers,flod
https://hg.mozilla.org/integration/autoland/rev/4d2a86b258e4
(Part 2) Tests for data size display in new dialog. r=pbz

Comment 10

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/d503faf45ca6
https://hg.mozilla.org/mozilla-central/rev/4d2a86b258e4