1856412 - Make all endpoints point to the same clear data dialog

Status: RESOLVED FIXED

(Toolkit :: Data Sanitization, task, P2)

Comment 1

[Harshit Sohaney [:hsohaney]]

Attachment: WIP: Bug 1856412 - Make all endpoints point to the same clear data dialog. WIP

Depends on D189947

Comment 2

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 1856412 - (Part 1) Make all clear history entrypoints point to the new clear history dialog. r?pbz

Depends on D190862

Comment 3

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 1856412 - (Part 2) Tests for new dialog UI from different endpoints. r?pbz

Depends on D192282

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The following patch is waiting for review from an inactive reviewer:

ID	Title	Author	Reviewer Status
D193846	Bug 1856412 - (Part 2) Tests for new dialog UI from different endpoints. r?pbz	hsohaney	pbz: Back Jan 2, 2024

:hsohaney, could you please find another reviewer?

For more information, please visit BugBot documentation.

Comment 5

[Harshit Sohaney [:hsohaney]]

The patch will be reviewed once Paul (@pbz) is back!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d040fd73abf
(Part 1) Make all clear history entrypoints point to the new clear history dialog. r=pbz,fluent-reviewers,settings-reviewers,flod,Gijs
https://hg.mozilla.org/integration/autoland/rev/dbaf2b0da226
(Part 2) Tests for new dialog UI from different endpoints. r=pbz

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/8d040fd73abf
https://hg.mozilla.org/mozilla-central/rev/dbaf2b0da226

Comment 8

[Noemi Erli[:noemi_erli]]

Backed out 4 changesets (Bug 1855068, Bug 1856412) for causing failures in test_SiteDataManager.js CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=linux%2C18.04%2Cx64%2Cwebrender%2Casan%2Copt%2Cxpcshell%2Ctests%2Cwithout%2Cfission%2Cenabled%2Ctest-linux1804-64-asan-qr%2Fopt-xpcshell-nofis%2Cx4&revision=645f7ed438fb8172e3e4db34d3d7821251ae066c&selectedTaskRun=CP97nv_oR9a7YAKPVl1RzA.0

Log: https://treeherder.mozilla.org/logviewer?job_id=442896701&repo=autoland&lineNumber=5001

Backout: https://hg.mozilla.org/integration/autoland/rev/1a93f0a64a7f897212da58c5753433922e0953cb

Comment 9

[Harshit Sohaney [:hsohaney]]

Sorry about that! Looks like there's an issue when the test is run between 12 am and 4 am because of overlap between TIMESPAN_TODAY and the other timespans. I'll work on a fix for this.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/180b4857ed08
(Part 1) Make all clear history entrypoints point to the new clear history dialog. r=pbz,fluent-reviewers,settings-reviewers,flod,Gijs
https://hg.mozilla.org/integration/autoland/rev/076f2f899363
(Part 2) Tests for new dialog UI from different endpoints. r=pbz

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/180b4857ed08
https://hg.mozilla.org/mozilla-central/rev/076f2f899363